Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for proseco p2 overlap change #209

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Update tests for proseco p2 overlap change #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sparkles/tests/test_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,7 @@ def test_check_guide_geometry(aca_review_table):
assert len(acar.messages) == 1
msg = acar.messages[0]
assert msg["category"] == "critical"
assert 'Guide indexes [4, 5, 6] clustered within 500" radius' in msg["text"]
assert 'Guide indexes [4, 7, 8] clustered within 500" radius' in msg["text"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not immediately anticipating that guide-related test would change, but these guide indexes are the overall catalog idx values, and acquisition-related changes fiddle with order of BOT stars in the list. I confirmed that these are the same 3 stars.


# Test for cluster of 3 500" rad stars in a 5 star case, but downgrade
# the warning for the case when the maneuver angle away is <= 5
Expand All @@ -915,7 +915,7 @@ def test_check_guide_geometry(aca_review_table):
assert len(acar.messages) == 1
msg = acar.messages[0]
assert msg["category"] == "warning"
assert 'Guide indexes [4, 5, 6] clustered within 500" radius' in msg["text"]
assert 'Guide indexes [4, 7, 8] clustered within 500" radius' in msg["text"]


def test_pickle():
Expand Down
2 changes: 1 addition & 1 deletion sparkles/tests/test_yoshi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def test_run_one_yoshi(proseco_agasc_1p7):
"n_warning": 1,
"n_caution": 0,
"n_info": 1,
"P2": 1.801521445484349,
"P2": 1.7923666714605953,
"guide_count": 3.8577301426624357,
}

Expand Down
Loading