-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new QGRaphicsItems (FieldOfView, Centroid) #6
Merged
Changes from 4 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0304415
Added new QGRaphicsItems (FieldOfView, Centroid)
javierggt 7db1073
typo
javierggt 17812ba
rename State -> StarFieldState
javierggt ac44f9d
ruff
javierggt f8cb0a4
fix typo
javierggt 53ac884
change line color in camera outline
javierggt 0f88fbc
factor out position calculation from graphic items
javierggt 2e278fd
remove code that is never run (and would fail)
javierggt 0d78dd5
docstrings
javierggt 11991ce
change centroid symbol and fixed FieldOfView.get_centroid_table
javierggt b9402f2
ruff
javierggt 5ef2e9a
ruff
javierggt e1439f3
remove menu bar and add quick config to context menu
javierggt 40f6aa4
change default centroid values so they are not shown
javierggt 62b5752
make sure state values are copied when resetting
javierggt 341ceb8
ruff
javierggt d8b0319
fixup when setting catalog in StarPlot (check dtype too)
javierggt 20a834d
show fid centroids after changing color
javierggt 6ab98f9
fixup
javierggt bcc262d
ruff
javierggt c2e8b8c
added .fiducial attribute to Centroid item and improved the way style…
javierggt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the fid light centroids excluded here? They are a bit less interesting, but if we're just trying to display where on the CCD stuff is happening it might make sense to just include them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I will add them back. I will use the same symbol but in red.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeanconn I just pushed this change in this branch (it was in a branch in the other PR). I am going to merge this PR. I have used this extensively and found no issues, and it is getting harder to keep track of things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want me to review again let me know.