This repository has been archived by the owner on Oct 3, 2021. It is now read-only.
Update nla-digbench-scaling (continuation of PR #1200) #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These coverage properties are highly redundant, why do we add these? We can always check for branch coverage. If we have a reachability violation, we can check for that kind of coverage. There is no need for having these weird coverage properties in every taskdef file.
hernanponcedeleon
previously approved these changes
Nov 11, 2020
|
Indeed, I will add it. |
hernanponcedeleon
approved these changes
Nov 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is easier to regenerate the tasks from the script than fixing the numerous merge conflicts over at #1200.
Since the coverage properties have been merged before #1200, we need to handle this case explicitly.
Property
coverage-error-call.prpis added in case the task contains a reachability violation.../properties/coverage-branches.prpis kept whenever it is in the corresponding task innla-digbench.