Fix condition variable wait #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,444 @@ | |||
| // based on the <boost/thread/win32/condition_variable.hpp> | |||
There was a problem hiding this comment.
Add the file's version of Boost in this comment
Comment on lines
+66
to
+73
| void lock() | ||
| { | ||
| if (_unlocked) | ||
| { | ||
| _lock.lock(); | ||
| _unlocked = false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there any possibility of lock() throwing?
There was a problem hiding this comment.
This is by design. The caller of the wait call can catch the throw and re-wait again.
Co-authored-by: jonathan-r-thorpe <64410119+jonathan-r-thorpe@users.noreply.github.com>
Co-authored-by: jonathan-r-thorpe <64410119+jonathan-r-thorpe@users.noreply.github.com>
…lth command timestamp
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows
boost::condition_variable_any::waitwould throw nested lock exceptions whenboost::shared_mutexhas reached themaximum number of exclusive_waiting locks. This problem occurs inside the
boost::basic_condition_variable::do_wait_untilwhen
relockeris out of scope. This could cause program termination due to unhandled exceptions.@garethsb reports this problem in #315.