Don't try and add billing address if there is no billing address attached to credit card #120
Conversation
…ched to credit card
| @@ -266,7 +266,7 @@ def transaction_options(source, options, submit_for_settlement = false) | |||
| params[:shipping] = braintree_shipping_address(options) | |||
| end | |||
|
|
|||
| if source.credit_card? | |||
| if source.credit_card? && options[:bliing_address].present? | |||
There was a problem hiding this comment.
It would be great to have a test for this.
Then you actually would have found your typo as well ;)
Add to wallet
|
@joeljackson I still like this change. Are you able to provide a spec and rebase with latest Then we are fine. Thanks for your contribution. |
|
Hi @tvdeyen, still interested in this change? If so would be interested in adding the spec and rebasing. |
…l might look like.
Existing card
| @@ -306,11 +306,11 @@ def transaction_options(source, options, submit_for_settlement = false) | |||
| params[:payment_method_nonce] = source.nonce | |||
| end | |||
|
|
|||
| if source.paypal? | |||
| if source.paypal? && options[:billing_address].present? | |||
There was a problem hiding this comment.
Shouldn't this be
options[:shipping_address].present?| <div><%= wallet_payment_source.payment_source.card_type %> - <%= wallet_payment_source.payment_source.display_number %></div> | ||
| <div><%= wallet_payment_source.payment_source.expiration_month %>/<%= wallet_payment_source.payment_source.expiration_year %></div> | ||
| <%- elsif wallet_payment_source.payment_source.paypal? %> | ||
| <div>Paypal</div> |
There was a problem hiding this comment.
Should be PayPal (Pal is also capitalized)
There was a problem hiding this comment.
Oh, Shoot. Didn't mean to include this here.
Will pull it out. See other pull request to see if we want to pull that in.
Thanks!
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
elia
changed the title
No description provided.