Solidus 4.4 / Rails 7.2 compatibility #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
lint-ruby-3.1
branch
from
b413b53 to
bc4fb35
Compare
tvdeyen
force-pushed
the
lint-ruby-3.1
branch
from
bcb53e7 to
c31148b
Compare
We install latest Solidus during linting code and this requires at least Ruby 3.1
By default we test extensions with latest Solidus, which due to Rails 7.2 support, requires at least Ruby 3.1
The solidusio/extensions CircleCI Orb sets the RAILS_VERSION to test the supported Solidus version. We should use that in order to not install latest Rails (8.0) versions we do not support yet.
tvdeyen
force-pushed
the
lint-ruby-3.1
branch
5 times, most recently
from
ffadb01 to
e65f687
Compare
Otherwise Rails 8.0 will be used
This controller lives in decorators, while it must live in lib/controllers/api so it can be conditionally loaded if api_available? This worked until now because solidus_support requires all decorators during start up. In Rails 7.2 it fails, because it cannot load the :authenticate_user method anymore.
The Rakefile includes all we need to run the tests. No need for anything different here. Let's reduce confusion.
This gem redefines the host apps ApplicationRecord class, which is very wrong! We introduce a namespaced BaseRecord and set the correct table_name_prefix on that class.
tvdeyen
force-pushed
the
lint-ruby-3.1
branch
from
e65f687 to
16360e6
Compare
That's how this is supposed to work, apparently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of fixes in single commits that make this extension work with Solidus 4.4 and Rails 7.2