Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use workspace package for landing page #1791

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Feb 10, 2025

Can this work, or will the manual overrides still be needed?

8241559

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 54e5777
🔍 Latest deploy log https://app.netlify.com/sites/solid-start-landing-page/deploys/67aa4716f7ff030008413ba5
😎 Deploy Preview https://deploy-preview-1791--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@birkskyum birkskyum force-pushed the use-workspace-for-landing-page branch from 33520c4 to 5605a5d Compare February 10, 2025 15:21
Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: 54e5777

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@birkskyum
Copy link
Member Author

birkskyum commented Feb 10, 2025

@atilafassina , if we set it to "workspace:*" on the main branch, will it still change it to 1.1.0?

@birkskyum birkskyum changed the title chore: use workspace for landing page chore: use workspace package for landing page Feb 10, 2025
@birkskyum birkskyum force-pushed the use-workspace-for-landing-page branch from 5605a5d to 54e5777 Compare February 10, 2025 18:36
@atilafassina atilafassina enabled auto-merge (squash) February 10, 2025 18:36
@atilafassina atilafassina merged commit 2624d45 into solidjs:main Feb 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants