Merge pull request #521 from solid-illiaaihistov/Replace-Dart-Code-Me…

…trics-with-Solid-Lints Replace dart code metrics with solid lints
solid-software · Feb 20, 2025 · 9132fa1 · 9132fa1
2 parents 4024950 + dd12cff
commit 9132fa1
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 51 deletions.
diff --git a/.github/workflows/code_check_for_flutter_vlc_player.yaml b/.github/workflows/code_check_for_flutter_vlc_player.yaml
@@ -20,31 +20,12 @@ jobs:
         working-directory: ./flutter_vlc_player
         run: flutter pub get
 
-      - name: Setup Dart Code Metrics
+      - name: Run Solid Lints
         working-directory: ./flutter_vlc_player
-        run: dart pub get dart_code_metrics
+        run: dart analyze
 
-      - name: Dart Code Metrics
-        working-directory: ./flutter_vlc_player
-        run: |
-          dirs_to_analyze=""
-          if [ -d lib ]; then dirs_to_analyze+=" lib"; fi
-          if [ -d test ]; then dirs_to_analyze+=" test"; fi
-          if [ -d example ]; then dirs_to_analyze+=" example"; fi
-          if [ dirs_to_analyze != "" ]
-          then
-            dart run dart_code_metrics:metrics \
-              analyze \
-              $dirs_to_analyze \
-              --fatal-warnings \
-              --fatal-performance \
-              --fatal-style
-            dart run dart_code_metrics:metrics \
-              check-unused-files \
-              $dirs_to_analyze \
-              --fatal-unused
-          fi
       - name: Check formatting
+        working-directory: ./flutter_vlc_player        
         run: dart format . --set-exit-if-changed
 
       - name: Run tests

diff --git a/.github/workflows/code_check_for_flutter_vlc_player_platform_interface.yaml b/.github/workflows/code_check_for_flutter_vlc_player_platform_interface.yaml
@@ -21,30 +21,10 @@ jobs:
         working-directory: ./flutter_vlc_player_platform_interface
         run: flutter pub get
 
-      - name: Setup Dart Code Metrics
+      - name: Run Solid Lints
         working-directory: ./flutter_vlc_player_platform_interface
-        run: dart pub get dart_code_metrics
+        run: dart analyze
 
-      - name: Dart Code Metrics
-        working-directory: ./flutter_vlc_player_platform_interface
-        run: |
-          dirs_to_analyze=""
-          if [ -d lib ]; then dirs_to_analyze+=" lib"; fi
-          if [ -d test ]; then dirs_to_analyze+=" test"; fi
-          if [ -d example ]; then dirs_to_analyze+=" example"; fi
-          if [ dirs_to_analyze != "" ]
-          then
-            dart run dart_code_metrics:metrics \
-              analyze \
-              $dirs_to_analyze \
-              --fatal-warnings \
-              --fatal-performance \
-              --fatal-style
-            dart run dart_code_metrics:metrics \
-              check-unused-files \
-              $dirs_to_analyze \
-              --fatal-unused
-          fi
       - name: Check formatting
         working-directory: ./flutter_vlc_player_platform_interface
         run: dart format . --set-exit-if-changed

diff --git a/flutter_vlc_player/example/lib/single_tab.dart b/flutter_vlc_player/example/lib/single_tab.dart
@@ -219,7 +219,7 @@ class _SingleTabState extends State<SingleTab> {
                     await Future<void>.delayed(const Duration(seconds: 1));
                     final tempVideo = await _loadVideoToFs();
                     await Future<void>.delayed(const Duration(seconds: 1));
-                    if (!mounted) break;
+                    if (!context.mounted) break;
                     ScaffoldMessenger.of(context).showSnackBar(
                       const SnackBar(
                         content: Text('Now trying to play...'),
@@ -229,7 +229,7 @@ class _SingleTabState extends State<SingleTab> {
                     if (await tempVideo.exists()) {
                       await _controller.setMediaFromFile(tempVideo);
                     } else {
-                      if (!mounted) break;
+                      if (!context.mounted) break;
                       ScaffoldMessenger.of(context).showSnackBar(
                         const SnackBar(
                           content: Text('File load error.'),
@@ -264,3 +264,9 @@ class _SingleTabState extends State<SingleTab> {
     await _controller.dispose();
   }
 }
+
+class MyClass {
+  final int _myField = 0;
+
+  int get myField => _myField;
+}
diff --git a/flutter_vlc_player/lib/src/vlc_player_controller.dart b/flutter_vlc_player/lib/src/vlc_player_controller.dart
@@ -572,7 +572,8 @@ class VlcPlayerController extends ValueNotifier<VlcPlayerValue> {
     _throwIfNotInitialized('getVolume');
     final volume = await vlcPlayerPlatform.getVolume(_viewId);
     value = value.copyWith(
-        volume: volume != null ? volume.clamp(0, _maxVolume) : null);
+      volume: volume?.clamp(0, _maxVolume),
+    );
 
     return volume;
   }

diff --git a/flutter_vlc_player/pigeons/messages.dart b/flutter_vlc_player/pigeons/messages.dart
@@ -71,7 +71,7 @@ class SnapshotMessage {
 
 class SpuTracksMessage {
   int? viewId;
-  Map? subtitles;
+  Map<Object?, Object?>? subtitles;
 }
 
 class SpuTrackMessage {
@@ -88,7 +88,7 @@ class AddSubtitleMessage {
 
 class AudioTracksMessage {
   int? viewId;
-  Map? audios;
+  Map<Object?, Object?>? audios;
 }
 
 class AudioTrackMessage {
@@ -105,7 +105,7 @@ class AddAudioMessage {
 
 class VideoTracksMessage {
   int? viewId;
-  Map? videos;
+  Map<Object?, Object?>? videos;
 }
 
 class VideoTrackMessage {
@@ -135,7 +135,7 @@ class RendererScanningMessage {
 
 class RendererDevicesMessage {
   int? viewId;
-  Map? rendererDevices;
+  Map<Object?, Object?>? rendererDevices;
 }
 
 class RenderDeviceMessage {