Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websocket ip from config to web client #15

Open
rkjdid opened this issue Aug 8, 2017 · 0 comments
Open

websocket ip from config to web client #15

rkjdid opened this issue Aug 8, 2017 · 0 comments
Labels
Milestone

Comments

@rkjdid
Copy link
Contributor

rkjdid commented Aug 8, 2017

right now the listenaddr specified in the config is passed to the html template, which is in turn used by the web-client for opening the websocket connection.

This is not needed, the client can simply re-use window.location.href instead which is simpler and also allows for ListenAddr to be set to 0.0.0.0 (which right now breaks the websocket)

thanks @krossov for reporting

@rkjdid rkjdid added this to the v0.5 milestone Oct 27, 2017
@rkjdid rkjdid added the bug label Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant