Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support java.util.concurrent.Executor (#515) #516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xyohn
Copy link

@xyohn xyohn commented Dec 7, 2023

Motivation:

SofaTracer does not support delegating java.util.concurrent.Executor

Modification:

add com.alipay.common.tracer.core.async.SofaTraceExecutor to support delegating java.util.concurrent.Executor

Result:

Fixes #515.

If there is no issue then describe the changes introduced by this PR.

Copy link

sofastack-cla bot commented Dec 7, 2023

Hi @xyohn, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@nobodyiam
Copy link
Member

@xzchaoo @glmapper Would you please help to take a look?

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (76e0574) 56.96% compared to head (c5dd1a4) 56.85%.

Files Patch % Lines
...ay/common/tracer/core/async/SofaTraceExecutor.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #516      +/-   ##
============================================
- Coverage     56.96%   56.85%   -0.12%     
  Complexity      213      213              
============================================
  Files           226      227       +1     
  Lines          6732     6737       +5     
  Branches        687      687              
============================================
- Hits           3835     3830       -5     
- Misses         2482     2491       +9     
- Partials        415      416       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Delegate java.util.concurrent.Executor
2 participants