Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加一个根据 DataID 清理 Data 上的 Publisher 数据,以及忽略客户端发送 Publisher 的能力 #362

Merged

Conversation

hui-cha
Copy link
Collaborator

@hui-cha hui-cha commented Jan 6, 2025

Motivation:
增加一个根据 DataID 清理 Data 上的 Publisher 数据,以及忽略客户端发送 Publisher 的能力。这个能力主要提供给注册中心用于在不需要推动业务改造的情况下,自主清理掉某些数据量很大,但是没有业务使用的 Publisher 数据,以降低 Session 和 Data 的水位。

Modification:
主要改动是
1、Meta 增加了一些 API 用于增加和删除 DataID 黑名单,黑名单的数据目前是存放在 ProviderData 中,Key 是 session.datainfoid.blacklist#@#9600#@#CONFIG
2、Meta 上增加黑名单的时候可以通过扩展 DataInfoIDBlacklistResource 类来增加一些针对黑名单的过滤规则,以尽量规避对重要 DataID 的误操作
3、Session 上增加了一个新的 FetchSystemPropertyService,用于从 Meta 同步 DataID 黑名单
4、在 Session 感知到黑名单后,会主动清理掉当前 Session 的 Publisher,并通知 Data 清理到对应 Publisher 的数据
5、Session 上增加了一个新的 WrapperInterceptor,用于在客户端发送新的 Publisher 的时候进行拦截
6、针对新增内容增加了单测

Copy link

coderabbitai bot commented Jan 6, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hui-cha
Copy link
Collaborator Author

hui-cha commented Jan 6, 2025

当前 PR 和 #361 这个 PR 是同一个事情,#361 关闭掉

@hui-cha hui-cha closed this Jan 6, 2025
@hui-cha hui-cha reopened this Jan 6, 2025
@huanglongchao
Copy link
Contributor

LGTM

@huanglongchao huanglongchao merged commit 141842b into sofastack:release/v6.6.0 Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants