-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
增加一个根据 DataID 清理 Data 上的 Publisher 数据,以及忽略客户端发送 Publisher 的能力 #362
增加一个根据 DataID 清理 Data 上的 Publisher 数据,以及忽略客户端发送 Publisher 的能力 #362
Conversation
…quests from clients
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
LGTM |
Motivation:
增加一个根据 DataID 清理 Data 上的 Publisher 数据,以及忽略客户端发送 Publisher 的能力。这个能力主要提供给注册中心用于在不需要推动业务改造的情况下,自主清理掉某些数据量很大,但是没有业务使用的 Publisher 数据,以降低 Session 和 Data 的水位。
Modification:
主要改动是
1、Meta 增加了一些 API 用于增加和删除 DataID 黑名单,黑名单的数据目前是存放在 ProviderData 中,Key 是 session.datainfoid.blacklist#@#9600#@#CONFIG
2、Meta 上增加黑名单的时候可以通过扩展 DataInfoIDBlacklistResource 类来增加一些针对黑名单的过滤规则,以尽量规避对重要 DataID 的误操作
3、Session 上增加了一个新的 FetchSystemPropertyService,用于从 Meta 同步 DataID 黑名单
4、在 Session 感知到黑名单后,会主动清理掉当前 Session 的 Publisher,并通知 Data 清理到对应 Publisher 的数据
5、Session 上增加了一个新的 WrapperInterceptor,用于在客户端发送新的 Publisher 的时候进行拦截
6、针对新增内容增加了单测