Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faulty unparse output #10

Open
soegaard opened this issue Apr 12, 2013 · 0 comments
Open

Faulty unparse output #10

soegaard opened this issue Apr 12, 2013 · 0 comments

Comments

@soegaard
Copy link
Owner

The program:
#lang bracket
DeclareVars(x,a);
Expand(((x-1)^a)/(1-x));
Outputs:
(-1+x)^a/1-x

The parentheses are missing in the denominator.
SuzanneSoy referenced this issue in SuzanneSoy/scribble-math Aug 10, 2016
Fix our parsing strategy so it is the same as (or very similar to) TeX's
0c9e973 
Summary:
Rewrote the parser to make this work, and added a bunch of tests to make sure
this does work. In the process, refactored all of our functions into a separate
file, functions.js. Added a bunch of comments to Parser.js. Also, update jasmine
so we can make our tests better, and add a lint_blacklist.txt to not lint bad
jasmine stuff.

Fixes #10
Fixes #12

Test Plan:
- Make sure all of the tests still work, and all of the new ones work also
- Make sure huxley screenshots didn't change

Reviewers: alpert

Reviewed By: alpert

Differential Revision: http://phabricator.khanacademy.org/D12989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soegaard