Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some visual overflow issues on smaller viewports #16

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

achou11
Copy link
Contributor

@achou11 achou11 commented Jan 18, 2023

Fixes the following (all screenshots use Firefox reponsive design mode on Firefox MacOS with viewport setting iPhone 12/13 Pro Max iOS 14.6, 428x926):

  1. Title header font size a little too large for mobile viewports. Changes from 60px to 48px for @media (max-width: 768px) media query
  • Before

    image
  • After

    image
  1. Overflow issues for code blocks on Firefox. overflow: overlay is deprecated and no longer applied on Firefox, causing an issue.
  • Before

    image
  • After (don't worry, scrollbar will show up when scrolling within the block, just didn't capture in screenshot)

    image

@heapwolf heapwolf merged commit 1f65ca5 into socketsupply:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants