Skip to content

Commit 2b9abbb

Browse files
chore: restore the debug package in the dev bundle
The debug package was not included anymore in the dev bundle since the migration from webpack to rollup ([1]) in version 6.0.0. [1]: 27de300 See also: 4683a95
1 parent e105551 commit 2b9abbb

File tree

5 files changed

+175
-29
lines changed

5 files changed

+175
-29
lines changed

package-lock.json

+122
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
"@babel/preset-env": "^7.12.7",
6666
"@fails-components/webtransport": "^0.1.7",
6767
"@rollup/plugin-babel": "^5.3.0",
68+
"@rollup/plugin-commonjs": "^21.0.0",
6869
"@rollup/plugin-node-resolve": "^13.0.5",
6970
"@sinonjs/fake-timers": "^7.1.2",
7071
"@types/debug": "^4.1.12",
@@ -96,7 +97,7 @@
9697
"test:node": "mocha --bail --require test/support/hooks.js test/index.js test/webtransport.mjs",
9798
"test:node-fetch": "USE_FETCH=1 npm run test:node",
9899
"test:browser": "zuul test/index.js",
99-
"build": "rollup -c support/rollup.config.umd.js && rollup -c support/rollup.config.esm.js",
100+
"build": "rimraf ./dist && rollup -c support/rollup.config.umd.js && rollup -c support/rollup.config.esm.js",
100101
"bundle-size": "node support/bundle-size.js",
101102
"format:check": "prettier --check 'lib/**/*.ts' 'test/**/*.js' 'test/webtransport.mjs' 'support/**/*.js'",
102103
"format:fix": "prettier --write 'lib/**/*.ts' 'test/**/*.js' 'test/webtransport.mjs' 'support/**/*.js'",

support/rollup.config.umd.js

+47-24
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
const { nodeResolve } = require("@rollup/plugin-node-resolve");
22
const { babel } = require("@rollup/plugin-babel");
33
const { terser } = require("rollup-plugin-terser");
4+
const commonjs = require("@rollup/plugin-commonjs");
45

56
const version = require("../package.json").version;
67
const banner = `/*!
@@ -9,41 +10,63 @@ const banner = `/*!
910
* Released under the MIT License.
1011
*/`;
1112

12-
module.exports = {
13-
input: "./build/esm/browser-entrypoint.js",
14-
output: [
15-
{
13+
module.exports = [
14+
{
15+
input: "./build/esm-debug/browser-entrypoint.js",
16+
output: {
1617
file: "./dist/engine.io.js",
1718
format: "umd",
1819
name: "eio",
1920
sourcemap: true,
2021
banner,
2122
},
22-
{
23+
plugins: [
24+
nodeResolve({
25+
browser: true,
26+
}),
27+
commonjs(),
28+
babel({
29+
babelHelpers: "bundled",
30+
presets: [["@babel/env"]],
31+
plugins: [
32+
"@babel/plugin-transform-object-assign",
33+
[
34+
"@babel/plugin-transform-classes",
35+
{
36+
loose: true,
37+
},
38+
],
39+
],
40+
}),
41+
],
42+
},
43+
{
44+
input: "./build/esm/browser-entrypoint.js",
45+
output: {
2346
file: "./dist/engine.io.min.js",
2447
format: "umd",
2548
name: "eio",
2649
sourcemap: true,
2750
plugins: [terser()],
2851
banner,
2952
},
30-
],
31-
plugins: [
32-
nodeResolve({
33-
browser: true,
34-
}),
35-
babel({
36-
babelHelpers: "bundled",
37-
presets: [["@babel/env"]],
38-
plugins: [
39-
"@babel/plugin-transform-object-assign",
40-
[
41-
"@babel/plugin-transform-classes",
42-
{
43-
loose: true,
44-
},
53+
plugins: [
54+
nodeResolve({
55+
browser: true,
56+
}),
57+
babel({
58+
babelHelpers: "bundled",
59+
presets: [["@babel/env"]],
60+
plugins: [
61+
"@babel/plugin-transform-object-assign",
62+
[
63+
"@babel/plugin-transform-classes",
64+
{
65+
loose: true,
66+
},
67+
],
4568
],
46-
],
47-
}),
48-
],
49-
};
69+
}),
70+
],
71+
},
72+
];

test/support/hooks.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const { createServer } = require("http");
66
const { attach } = require("engine.io");
77
const { rollup } = require("rollup");
88

9-
const rollupConfig = require("../../support/rollup.config.umd.js");
9+
const rollupConfig = require("../../support/rollup.config.umd.js")[1];
1010
const { serialize } = require("cookie");
1111

1212
let httpServer, engine;
@@ -29,7 +29,7 @@ exports.mochaHooks = {
2929

3030
rollup(rollupConfig).then(async (bundle) => {
3131
await bundle.write({
32-
...rollupConfig.output[1],
32+
...rollupConfig.output,
3333
file: "./test/support/public/engine.io.min.js",
3434
sourcemap: false,
3535
});

test/support/server.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ const server = require("engine.io").attach(http, {
1010
});
1111
const { rollup } = require("rollup");
1212

13-
const rollupConfig = require("../../support/rollup.config.umd.js");
13+
const rollupConfig = require("../../support/rollup.config.umd.js")[1];
1414

1515
rollup(rollupConfig).then(async (bundle) => {
1616
await bundle.write({
17-
...rollupConfig.output[1],
17+
...rollupConfig.output,
1818
file: "./test/support/public/engine.io.min.js",
1919
sourcemap: false,
2020
});

0 commit comments

Comments
 (0)