From a531208710e4964a7bf04747054fcffed572dc46 Mon Sep 17 00:00:00 2001
From: Matus Tomlein <matus.tomlein@gmail.com>
Date: Mon, 11 Nov 2024 16:22:40 +0100
Subject: [PATCH] Fix ignored label property in the startHtml5MediaTracking
 call (#1378)

---
 ...label_in_media_tracking_2024-11-11-15-16.json | 10 ++++++++++
 .../browser-plugin-media-tracking/src/player.ts  |  7 +++++--
 .../tests/test.test.ts                           | 16 ++++++++++++++++
 3 files changed, 31 insertions(+), 2 deletions(-)
 create mode 100644 common/changes/@snowplow/browser-plugin-media-tracking/issue-fix_ignored_label_in_media_tracking_2024-11-11-15-16.json

diff --git a/common/changes/@snowplow/browser-plugin-media-tracking/issue-fix_ignored_label_in_media_tracking_2024-11-11-15-16.json b/common/changes/@snowplow/browser-plugin-media-tracking/issue-fix_ignored_label_in_media_tracking_2024-11-11-15-16.json
new file mode 100644
index 000000000..b0131e443
--- /dev/null
+++ b/common/changes/@snowplow/browser-plugin-media-tracking/issue-fix_ignored_label_in_media_tracking_2024-11-11-15-16.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@snowplow/browser-plugin-media-tracking",
+      "comment": "Fix ignored label property in the startHtml5MediaTracking call",
+      "type": "none"
+    }
+  ],
+  "packageName": "@snowplow/browser-plugin-media-tracking"
+}
\ No newline at end of file
diff --git a/plugins/browser-plugin-media-tracking/src/player.ts b/plugins/browser-plugin-media-tracking/src/player.ts
index da1dfe0f9..e40b6abba 100644
--- a/plugins/browser-plugin-media-tracking/src/player.ts
+++ b/plugins/browser-plugin-media-tracking/src/player.ts
@@ -59,12 +59,15 @@ function htmlContext(el: HTMLMediaElement): (() => SelfDescribingJson)[] {
 }
 
 export function setUpListeners(config: ElementConfig) {
-  const { id, video } = config;
+  const { id, video, label } = config;
 
   startMediaTracking({
     ...config,
     id,
-    player: updatePlayer(video),
+    player: {
+      label,
+      ...updatePlayer(video)
+    },
     context: (config.context ?? []).concat(htmlContext(video)),
   });
 
diff --git a/plugins/browser-plugin-media-tracking/tests/test.test.ts b/plugins/browser-plugin-media-tracking/tests/test.test.ts
index a1b7e2898..12d254a75 100644
--- a/plugins/browser-plugin-media-tracking/tests/test.test.ts
+++ b/plugins/browser-plugin-media-tracking/tests/test.test.ts
@@ -312,4 +312,20 @@ describe('MediaTrackingPlugin', () => {
 
     expect(eventQueue.length).toBe(0);
   });
+
+  it("adds label to tracked event", async () => {
+    const video = document.createElement('video');
+    video.id = id;
+    document.body.appendChild(video);
+
+    startHtml5MediaTracking({ id: 'id', label: 'foo', video, captureEvents: [MediaEventType.Play] });
+
+    video.play();
+
+    let playerContext = eventQueue[0].context.find(
+      (c) => c.schema === 'iglu:com.snowplowanalytics.snowplow/media_player/jsonschema/2-0-0'
+    )?.data;
+
+    expect(playerContext?.label).toEqual('foo');
+  });
 });