Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required fields to the initial checks helper macro in Unified #96

Merged

Conversation

ilias1111
Copy link
Collaborator

@ilias1111 ilias1111 commented Dec 13, 2024

Description

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Checklist

  • πŸ’£ Is your change a breaking change?
  • πŸ“– I have updated the CHANGELOG.md

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ““ internal package docs (ymls, macros, readme, if applicable)
  • πŸ“• I have raised a Snowplow documentation PR if applicable (Link here)
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@ilias1111 ilias1111 requested a review from a team as a code owner December 13, 2024 10:22
@ilias1111 ilias1111 changed the base branch from main to Release/snowplow-unified/0.5.1 December 13, 2024 10:22
@ilias1111 ilias1111 changed the title Update context_existance_check.sql Add required fields to the initial checks helper macro in Unified Dec 13, 2024
Copy link
Collaborator

@agnessnowplow agnessnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilias1111 ilias1111 merged commit 8a615b2 into Release/snowplow-unified/0.5.1 Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants