Unify web and mobile model #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnessnowplow
force-pushed
the
feature/unify
branch
9 times, most recently
from
9df2c51 to
e349747
Compare
agnessnowplow
requested review from
matus-tomlein,
emielver,
rlh1994 and
georgewoodhead
rlh1994
reviewed
Sep 22, 2023
matus-tomlein
approved these changes
Oct 5, 2023
rlh1994
reviewed
Oct 9, 2023
rlh1994
reviewed
Oct 9, 2023
There was a problem hiding this comment.
While we're tidying things, just as few ideas:
- We don't really need the cluster_by macros anymore now the models are all a single file, we could just add them directly to the config?
- I really don't get why
allow_refreshis not part of the utils package at this point... - Once it's settled I'd like to just have a look at all our macros and work out if there's any we could combine, make more flexible, combine in file only (to make it clearer where things are maybe), or pull back into the models now that we don't have 4 versions of each file (where they don't differ by warehouse). Also just consistency things like we should make sure all columns don't have trailing commas etc.
models/base/manifest/snowplow_unified_base_quarantined_sessions.sql
Outdated
Show resolved
Hide resolved
rlh1994
reviewed
Oct 9, 2023
|
rlh1994
reviewed
Oct 10, 2023
|
Update on the state: Thanks for all the feedback so far! Things should solidify from now as everything has been added including integration tests and even the optional modules from both web and mobile that was not even planned at this stage. The app errors module still needs revision as it does not come with integration tests and I merged the this run tables for it. Other than that I consider it done (minus a final revision on wording and local final redshift tests). |
agnessnowplow
force-pushed
the
feature/unify
branch
from
2c113df to
51505e9
Compare
rlh1994
approved these changes
Oct 18, 2023
integration_tests/models/expected/snowplow_unified_sessions_expected_stg.sql
Outdated
Show resolved
Hide resolved
tests/page_screen_views/snowplow_tests_page_screen_view_in_session_values.sql
Outdated
Show resolved
Hide resolved
rlh1994
reviewed
Oct 23, 2023
rlh1994
reviewed
Oct 23, 2023
agnessnowplow
force-pushed
the
feature/unify
branch
from
c1adc6c to
3ae6bac
Compare
agnessnowplow
force-pushed
the
feature/unify
branch
from
3ae6bac to
0d5f67e
Compare
agnessnowplow
force-pushed
the
feature/unify
branch
from
0d5f67e to
ce14afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status:
Integration tests are added (Redshift tested locally). Not expecting more changes apart from PR points.
optional modules:
Internal Documentation PR:
-snowplow/documentation#631 (comment)