Close macro issues #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlh1994
force-pushed
the
chore/prefix-macro-calls
branch
2 times, most recently
from
bf01421 to
731794d
Compare
rlh1994
force-pushed
the
chore/prefix-macro-calls
branch
from
731794d to
9be57a2
Compare
rlh1994
force-pushed
the
chore/prefix-macro-calls
branch
from
9be57a2 to
8581213
Compare
rlh1994
force-pushed
the
chore/prefix-macro-calls
branch
from
8581213 to
4e079e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds prefixes to macro all macro calls to make it easier for users who extract the models. It also adds more column-list macro calls where possible in place of manually listing, not this adds 2 new columns which were not included in the manual list and re-orders some columns to simplify the sql. Finally, it fixes the issue where the model can fail when there is no data if list all events is enabled, I've added an extra test layer to check for this in the future.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #25
https://snplow.atlassian.net/browse/PE-6008
Closes #26
https://snplow.atlassian.net/browse/PE-5991
Closes #27
https://snplow.atlassian.net/browse/PE-6009
Checklist
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?