Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headset to the list of recognized platforms #22

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Add headset to the list of recognized platforms #22

merged 1 commit into from
Jan 22, 2024

Conversation

matus-tomlein
Copy link
Contributor

Description

Ahead of adding the visionOS support in the iOS tracker, this PR adds the new headset platform value to the list of recognized platforms.

What type of PR is this? (check all applicable)

  • 🍕 Feature

Checklist

  • 🎉 I have verified that these changes work locally
  • 💣 Is your change a breaking change?
  • 📖 I have updated the CHANGELOG.md

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 internal package docs (ymls, macros, readme, if applicable)
  • 📕 I have raised a Snowplow documentation PR if applicable (Link here if required)
  • 🙅 no documentation needed

@matus-tomlein matus-tomlein requested a review from a team as a code owner January 22, 2024 08:51
rlh1994
rlh1994 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@rlh1994 rlh1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A real 8 story point ticket of work!

@matus-tomlein matus-tomlein merged commit 021848c into release/snowplow-unified/0.2.0 Jan 22, 2024
4 checks passed
@matus-tomlein matus-tomlein deleted the issue/update_platform branch January 22, 2024 12:28
agnessnowplow pushed a commit that referenced this pull request Jan 30, 2024
@matus-tomlein @agnessnowplow
Add headset to the list of recognized platforms (#22)
30c6b90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlh1994 rlh1994 rlh1994 approved these changes

@agnessnowplow agnessnowplow Awaiting requested review from agnessnowplow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matus-tomlein @rlh1994