Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider screen view ID from the screen view context #14

Closed
matus-tomlein opened this issue Jan 2, 2024 · 0 comments
Closed

Consider screen view ID from the screen view context #14

matus-tomlein opened this issue Jan 2, 2024 · 0 comments
Assignees
@matus-tomlein
Labels
status:needs_triage Needs maintainer triage.

Comments

@matus-tomlein
Copy link
Contributor

Currently the screen view ID is only read from the screen view event – see here. This means that we don’t attribute any other events than the screen view event to the screen view.

In addition to reading the ID from the screen view event, we should also accept it from the screen context so that events other than the screen view can be attributed to the screen.
@matus-tomlein matus-tomlein self-assigned this Jan 2, 2024
@github-actions github-actions bot added the status:needs_triage Needs maintainer triage. label Jan 2, 2024
matus-tomlein added a commit that referenced this issue Jan 2, 2024
@matus-tomlein
Consider screen view ID from the screen view context (close #14)
74151e3
matus-tomlein added a commit that referenced this issue Jan 2, 2024
@matus-tomlein
Consider screen view ID from the screen view context (close #14)
1d8f8af
@matus-tomlein matus-tomlein mentioned this issue Jan 2, 2024
Merged
9 tasks
matus-tomlein added a commit that referenced this issue Jan 4, 2024
@matus-tomlein
Consider screen view ID from the screen view context (close #14)
13ea5c8 
PR #15
matus-tomlein added a commit that referenced this issue Jan 8, 2024
@matus-tomlein
Consider screen view ID from the screen view context (close #14)
60c5b57 
PR #15
@agnessnowplow agnessnowplow mentioned this issue Jan 30, 2024
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matus-tomlein matus-tomlein

Labels
status:needs_triage Needs maintainer triage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matus-tomlein