Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: have crt* located by dlopen and make repo a flake #156

Merged
merged 2 commits into from
Dec 17, 2023

Conversation

Kaisia-Estrel
Copy link
Contributor

No description provided.

@mauro-balades mauro-balades self-requested a review December 13, 2023 15:36
@mauro-balades mauro-balades added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 13, 2023
src/builder/linker/linux/ld.cc Show resolved Hide resolved
pcre2
libllvm
libbacktrace
libxml2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xml?

flake.nix Outdated Show resolved Hide resolved
flake.lock Outdated Show resolved Hide resolved
@emm312
Copy link
Contributor

emm312 commented Dec 14, 2023

LGTM

@mauro-balades
Copy link
Member

LGTM

There are still pending changes

@emm312
Copy link
Contributor

emm312 commented Dec 14, 2023

LGTM

There are still pending changes

i meant the code looked good

@mauro-balades
Copy link
Member

mauro-balades commented Dec 14, 2023 via email

Signed-off-by: Perigord <90542764+Perigord-Kleisli@users.noreply.github.com>
@mauro-balades mauro-balades merged commit 44e14cd into snowball-lang:dev Dec 17, 2023
1 of 5 checks passed
@mauro-balades
Copy link
Member

mauro-balades commented Dec 17, 2023

it does work! 🥳 Thanks a lot!

@mauro-balades
Copy link
Member

I still don't know why XML is required though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants