Make repo a flake and make ld-linux be dynamically located #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it doesn't exist
mauro-balades
requested changes
Dec 12, 2023
| mkdir -p bin/Release | ||
|
|
||
| #HACK: uses RelWithDebInfo since normal realease causes a segfault | ||
| cmake \ |
There was a problem hiding this comment.
Shound't we cann the release script here?
| fs::path ld_linux_path; | ||
|
|
||
| void* handle = dlopen("ld-linux-x86-64.so.2", RTLD_LAZY); | ||
| if (!handle) { DEBUG_CODEGEN("Error getting library path: %s", dlerror()); } |
There was a problem hiding this comment.
Nice! This is really cool! Instead of DEBUG_CODEGEN we should raise an error instead, I can do that once I arrive at home since DEBUG_CODEGEN does not exist in release builds
mauro-balades
added
enhancement
|
sorry, there are bugs, if you want, you can open a new PR with the same commits. I pinged u on discord to discuss about this problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note that the executable is built with
RelWithDebInfoinstead ofRelease. That's becauseReleaseseems to cause a segfault. I haven't found out why it occurs, I but I've found it happens inTransformer::visitGlobal