Skip to content

Commit

Permalink
Fixed printing install script
Browse files Browse the repository at this point in the history
  • Loading branch information
mauro-balades committed Dec 25, 2023
1 parent 8dafb55 commit 6f10f6e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion scripts/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,6 @@ printf " ${green}snowball-stdlib${normal} - standard library for snowball\n\n

log info "Snowball successfully installed at: $(pwd)"
log info "Snowball is ready to use! type: \`snowball --help\` to check that it works."
echo "\n===================== GREAT! =====================\n"
printf "\n\t===================== GREAT! =====================\n\n"
log info "Checkoutt the documentation at: https://snowball-lang.gitbook.io/docs/fundamentals/hello-world"
log info "Happy coding! 🐱"
4 changes: 2 additions & 2 deletions src/os/Driver/getOutputFilename.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ std::string Driver::getOutputFilename(std::string input, app::Options::EmitType
#ifdef __APPLE__
std::string output = input;
switch (type) {
case app::Options::EmitType::EXECUTABLE: output; break;
case app::Options::EmitType::EXECUTABLE: break;
case app::Options::EmitType::OBJECT:
if (isStatic)
output += ".a";
Expand All @@ -21,7 +21,7 @@ std::string Driver::getOutputFilename(std::string input, app::Options::EmitType
#elif __linux__
std::string output = input;

Check warning on line 22 in src/os/Driver/getOutputFilename.cc

View workflow job for this annotation

GitHub Actions / cpp-linter

src/os/Driver/getOutputFilename.cc:22:24 [performance-unnecessary-value-param]

parameter 'input' is passed by value and only copied once; consider moving it to avoid unnecessary copies
switch (type) {
case app::Options::EmitType::EXECUTABLE: output; break;
case app::Options::EmitType::EXECUTABLE: break;
case app::Options::EmitType::OBJECT:
if (isStatic)

Check warning on line 26 in src/os/Driver/getOutputFilename.cc

View workflow job for this annotation

GitHub Actions / cpp-linter

src/os/Driver/getOutputFilename.cc:26:20 [readability-braces-around-statements]

statement should be inside braces
output += ".a";
Expand Down

0 comments on commit 6f10f6e

Please sign in to comment.