Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added #15803: Category Field to Asset Related Mails #15854

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

NebelKreis
Copy link
Contributor

Description

This pull request introduces the Category field to the emails generated for asset Check-in, Check-out, Acceptance, Decline and Requests. Previously, these emails included asset details like model and tag, but without the category, it was sometimes difficult to identify the type of asset. By including the category, the emails provide clearer and more actionable information.

Key-Changes:

  • Added the Category field to the templates of:
    • Check-in emails
    • Check-out emails
    • Asset acceptance/decline emails
    • Request confirmation emails
  • Adjusted the email generation logic to pull and include the category from the database.

Fixes #15803

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit Tests: Verified that the new category field is correctly included in the email templates and rendered with valid data.
  • Manual Testing:
    • Sent test emails for check-in, check-out, acceptance, delcine and requests.
    • Confirmed that the category is displayed properly for each type of email.

Test Configuration:

  • PHP version: 8.1.2
  • MySQL version: 8.0.33
  • Webserver version: Apache 2.4.57
  • OS version: Ubuntu 22.04

Checklist:

Copy link

what-the-diff bot commented Nov 20, 2024

PR Summary

  • Enhancement in Asset Information Display
    The update adds a new feature in the check-in and check-out views of an asset. Now these views will also display the category name of the asset, but only if such information is available. It will help in quick identification of the type of asset being dealt with.

@NebelKreis NebelKreis marked this pull request as ready for review November 20, 2024 10:23
@snipe snipe merged commit 5522def into snipe:develop Nov 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants