Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: First stab at allowing semi-colons for importer delimiter #15605

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

snipe
Copy link
Owner

@snipe snipe commented Oct 2, 2024

This is a WIP for #15542. Definitely not ready for testing yet. :( This Livewire stuff is nasty.

Todo:

  • Translate the text comma, semicolon, etc to actual symbols

Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Oct 2, 2024

PR Summary

  • Improved File Import Flexibility:
    • Changes to the ImportController.php and Importer.php allow setting a custom delimiter during CSV file imports. This makes the import process more adaptable to different file formats.
  • Improved User Experience:
    • Updates to importer.blade.php allow users to select the delimiter before submitting their file. This offers a more intuitive and user-friendly interface.
  • Enhanced Layout Organization and Responsiveness:
    • Changes to the HTML structure in importer.blade.php have improved the layout's organization and responsiveness, making the webpage easier to interact with.
  • Code Quality Improvements:
    • Minor but essential cleanup and formatting changes in backups.blade.php created a cleaner and more readable codebase.

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@uberbrady uberbrady marked this pull request as draft October 7, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant