Merge pull request #5 from giuliofoletto/better-logging

Avoid logging to root logger
snip3rnick · Mar 11, 2024 · f30d9e3 · f30d9e3
2 parents 01cd2b1 + ab4ea83
commit f30d9e3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/HardwareMonitor/Util.py b/HardwareMonitor/Util.py
@@ -6,6 +6,7 @@
 from HardwareMonitor.Hardware import Computer, IVisitor, IComputer, IHardware, IParameter, ISensor, HardwareType, SensorType
 from System.Collections.Generic import IList, IDictionary
 
+logger = logging.getLogger("PyHardwareMonitor")
 
 # ------------------------------------------------------------------------------
 def _get_name_to_type(obj):
@@ -81,7 +82,7 @@ def UpdateHardwareSafe(hardware: IHardware):
         hardware.Update()
     except:
         if hardware.Identifier not in _UPDATE_WARNING_CACHE:
-            logging.warning(f"Unable to update HardwareMonitor sensors for {hardware.Identifier} ('{hardware.Name}')")
+            logger.warning(f"Unable to update HardwareMonitor sensors for {hardware.Identifier} ('{hardware.Name}')")
             _UPDATE_WARNING_CACHE.add(hardware.Identifier)
 
 

diff --git a/HardwareMonitor/__init__.py b/HardwareMonitor/__init__.py
@@ -6,11 +6,11 @@
 from   pathlib import Path
 
 
-logging.basicConfig(format='%(levelname)s: %(message)s')
+logger = logging.getLogger("PyHardwareMonitor")
 
 
 if not ctypes.windll.shell32.IsUserAnAdmin():
-    logging.warning("Admin privileges are required for 'HarwareMonitor' to work properly")
+    logger.warning("Admin privileges are required for 'HardwareMonitor' to work properly")
 
 ASSEMBLY_NAME = "LibreHardwareMonitor"