Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand pre-commit hook? #450

Open
KonradHoeffner opened this issue Dec 19, 2024 · 1 comment
Open

expand pre-commit hook? #450

KonradHoeffner opened this issue Dec 19, 2024 · 1 comment

Comments

@KonradHoeffner
Copy link
Collaborator

Right now we only run prettier and oxlint on commit, however it is still possible to commit code that breaks the build, e.g. with failed tests or broken typecheck.
Should we add this to the pre-commit hook?
The problem would be if we want to commit unfinished code to another branch.

@KonradHoeffner KonradHoeffner added this to the next milestone Dec 19, 2024
@KonradHoeffner KonradHoeffner changed the title expend pre-commit hook? expand pre-commit hook? Dec 19, 2024
@Yagnap
Copy link
Collaborator

Yagnap commented Jan 13, 2025

git commit --no-verify should cover the case of commiting unfinished code

@Yagnap Yagnap modified the milestones: next, 25.06 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants