feat(ivc): impl cyclefold::ivc #414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
chaosma
reviewed
Feb 9, 2025
| .map_err(Error::WhileProtoGalaxyAccCreation)?; | ||
|
|
||
| // At zero step cyclefold ivc - output protogalaxy-accumulator is input | ||
| // protogalaxy-accumulator. Bug proof still should be valid. |
| .W_commitments | ||
| .iter() | ||
| .copied() | ||
| .zip_eq(pp.primary_initial_trace.u.W_commitments.iter().copied()), |
There was a problem hiding this comment.
what are the definition of primary_initial-acc and pp.primary_initial_trace,
are these two the same?
| // delegate the `W_commitment` calculations to the `upport_circuit` we need `gamma` to | ||
| // repeat them. We take advantage of the fact that `gamma` is generated last and thus | ||
| // retrieve it | ||
| let gamma = random_oracle.squeeze::<CMain::ScalarExt>(MAX_BITS); |
There was a problem hiding this comment.
is gamma already squeezed in fn ProtoGalaxy::prove?
Here it squeeze a new challenge and hence will be different from the gamma generated in ProtoGalaxy::prove.
Why are they the same?
| z_i: *primary_z_current, | ||
| z_0: *primary_z_0, | ||
|
|
||
| // next fields not used in absorb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #368
Close #369
Close #370
Close #372
Close #373
Close #374
Overview
Implementation of the cyclefold with test
Issue Link / Motivation
Changes Overview