feat(ivc): impl `cyclefold::sfc` #413

cyphersnake · 2025-01-08T16:00:16Z

Motivation
This PR combines all the changes for operability #373

Overview

Renamed PairedPlonkInstance and PairedTrace to SupportPlonkInstance and SupportTrace for better alignment with the functionality
Added alignment for W_commitments & challenes, since we don't know them at the "before zero step" stage, this takes 300 extra rows
Changed Input absorption order for consistency from nifs::{sangria,protogalaxy} (Some fields are now converted to bn, oncircuit only)

coderabbitai · 2025-01-08T16:00:24Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

**Motivation** This PR combines all the changes for operability #373 **Overview** - Renamed `PairedPlonkInstance` and `PairedTrace` to `SupportPlonkInstance` and `SupportTrace` for better alignment with the functionality - Added alignment for W_commitments & challenes, since we don't know them at the "before zero step" stage, this takes 300 extra rows - Changed `Input` absorption order for consistency from nifs::{sangria,protogalaxy} (Some fields are now converted to bn, oncircuit only)

chaosma · 2025-02-09T01:45:32Z

src/ivc/cyclefold/sfc/input/assigned.rs

@@ -237,34 +340,79 @@ impl<F: PrimeField> PairedPlonkInstance<F> {
            })
            .collect::<Result<Vec<_>, Halo2PlonkError>>()?;

+        iter::repeat((F::ZERO, F::ZERO))
+            .take(W_COMMITMENTS_MAX_LEN - W_commitments.len())


the number of W_commitments is known during the circuit setup phase which depends on the user-defined circuit. It seems we don't need to pad.

chaosma · 2025-02-09T01:46:22Z

src/ivc/cyclefold/sfc/input/assigned.rs

+            region,
+            || "",
+            iter::repeat(F::ZERO).take(W_CHALLENGES_MAX_LEN - challenges.len()),
+        )?;


similar as padding of W_Commitments above

chaosma · 2025-02-09T01:51:30Z

src/ivc/cyclefold/sfc/input/mod.rs

    pub(crate) W_commitments: Vec<(F, F)>,
-    pub(crate) instances: Vec<Vec<BigUint<F>>>,
-    pub(crate) challenges: Vec<BigUint<F>>,
+    // should be bn, but for absorb use original value and make bn oncircuit


I understand 'should be bn' part. don't get 'but for ... and make bn oncircuit' part

chaosma · 2025-02-09T01:53:36Z

src/ivc/cyclefold/sfc/input/mod.rs

@@ -112,8 +111,13 @@ impl<F: PrimeField, RO: ROTrait<F>> AbsorbInRO<F, RO> for PairedPlonkInstance<F>
        } = self;

        ro.absorb_field_iter(W_commitments.iter().flat_map(|(x, y)| [x, y]).copied())
-            .absorb_iter(instances.iter().flatten())
-            .absorb_iter(challenges.iter());
+            .absorb_field_iter(


will absorb_field_iter absorb the field element as BigUInt to be consistency with on-circuit absorb"?

chaosma · 2025-02-09T01:56:15Z

src/ivc/cyclefold/sfc/input/mod.rs

            .absorb_field(*ex)
            .absorb_field(*ey)
-            .absorb_field(*u);
+            .absorb_field(F::ZERO);


why absorb zero here?

chaosma · 2025-02-09T02:16:22Z

src/ivc/cyclefold/sfc/mod.rs

+
+        let mut self_ = self.input.clone();
+
+        self_.step += 1;


IIUC, instances is return the instance of current step.
can you remind me that before call fn instances, what data the self hold/account for?

chaosma · 2025-02-09T02:34:43Z

src/ivc/cyclefold/sfc/input/assigned.rs

-        let expected_l0 = mg.conditional_select(region, &zero, &poly_L_values[0], &is_zero_term)?;
-        let expected_l0 = bn_chip
+        let expected_l0 = mg.conditional_select(region, &zero, &poly_L_values[0], &is_zero_step)?;
+        let expected_l0_limbs = bn_chip


how is it handled at step=0? both l0 and l1 are zero?

chaosma · 2025-02-09T02:45:09Z

src/ivc/cyclefold/sfc/input/assigned.rs

            self.self_trace.input_accumulator.ins.W_commitments.iter(),
            self.self_trace.incoming.W_commitments.iter(),
-            self.paired_trace.incoming.iter(),
+            self.support_trace.incoming.iter(),


IIRC, the new_acc.ins.W_commitments here are still old one and need to be updated here.

chaosma · 2025-02-09T02:49:41Z

src/ivc/cyclefold/sfc/input/assigned.rs

            .from_assigned_value_to_limbs(region, &expected_l1)
            .map_err(|err| {
                error!("while make from L1 biguint form: {err:?}");
                Halo2PlonkError::Synthesis
            })?;

-        for (acc_W, incoming_W, trace, new_acc_W) in itertools::multizip((
+        for (acc_W, incoming_W, trace, new_acc_W, index) in itertools::multizip((


It might be a good idea to add a comment of how many delegation of ecc multiplication have been used somewhere. maybe here or in function comment

cyphersnake requested a review from chaosma January 8, 2025 16:00

cyphersnake self-assigned this Jan 8, 2025

cyphersnake force-pushed the feat-cyclefold-sfc branch from 360ca6e to 5bb8218 Compare January 8, 2025 16:04

chaosma reviewed Feb 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ivc): impl `cyclefold::sfc` #413

feat(ivc): impl `cyclefold::sfc` #413

cyphersnake commented Jan 8, 2025 •

edited

Loading

coderabbitai bot commented Jan 8, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

chaosma Feb 9, 2025

chaosma Feb 9, 2025

chaosma Feb 9, 2025

chaosma Feb 9, 2025

chaosma Feb 9, 2025

chaosma Feb 9, 2025

chaosma Feb 9, 2025

chaosma Feb 9, 2025

chaosma Feb 9, 2025

feat(ivc): impl cyclefold::sfc #413

Are you sure you want to change the base?

feat(ivc): impl cyclefold::sfc #413

Conversation

cyphersnake commented Jan 8, 2025 • edited Loading

coderabbitai bot commented Jan 8, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feat(ivc): impl `cyclefold::sfc` #413

feat(ivc): impl `cyclefold::sfc` #413

cyphersnake commented Jan 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)