Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integration): integrate with Snarkify platform #1

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat(integration): integrate with Snarkify platform #1

wants to merge 8 commits into from

Conversation

ErdongChen61
Copy link
Collaborator

@ErdongChen61 ErdongChen61 commented Oct 23, 2024 •
edited
Loading

Integrate with Snarkify platform.

It is a quick implementation to support Scroll SDK in Snarkify platform.

@ErdongChen61 ErdongChen61 self-assigned this Oct 23, 2024
@ErdongChen61 ErdongChen61 reopened this Oct 23, 2024
cyphersnake
cyphersnake requested changes Oct 28, 2024
View reviewed changes
Copy link

@cyphersnake cyphersnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing critical, however, I don't have much context for this integration.

If you need more than general comments, please add details in the PR description

src/bin/snarkify.rs Outdated Show resolved Hide resolved
src/bin/snarkify.rs Outdated Show resolved Hide resolved
src/bin/snarkify.rs Show resolved Hide resolved
src/bin/snarkify.rs Outdated Show resolved Hide resolved
src/bin/snarkify.rs Outdated
},
Err(e) => {
return self
.build_prove_error_response(&req, &format!("Failed to request proof: {}", e))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Displaying error via display sometimes gives too little detail, I would duplicate at least in log {error:?} (debug version)

src/bin/snarkify.rs Show resolved Hide resolved
@ErdongChen61
Copy link
Collaborator Author

ErdongChen61 commented Oct 28, 2024 •
edited
Loading

Nothing critical, however, I don't have much context for this integration.

If you need more than general comments, please add details in the PR description

thanks @cyphersnake! General comments are enough. I am basically following the examples given from Scroll here: https://github.com/scroll-tech/scroll-proving-sdk/blob/haoyu/sindri_tokio/examples/cloud.rs

The idea to implement ProvingService trait to accept proof requests from Scroll SDK and generate the proofs from our platform.

@cyphersnake
Copy link

(If ready for re-review, please re-request a review at Reviews section of PR)

@ErdongChen61
Copy link
Collaborator Author

(If ready for re-review, please re-request a review at Reviews section of PR)

This PR is deprecated. I will import the scroll-proving-sdk as dependency here: snarkify/scroll-proving-agent#1

@ErdongChen61 ErdongChen61 marked this pull request as draft October 30, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyphersnake cyphersnake cyphersnake requested changes

@Gigatron Gigatron Awaiting requested review from Gigatron

Requested changes must be addressed to merge this pull request.

Assignees

@ErdongChen61 ErdongChen61

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErdongChen61 @cyphersnake