atproto: drop trailing slash from PDS serviceEndpoint in DID docs

for #1595, snarfed/arroba@21d676c
snarfed · Feb 28, 2025 · 8ad553a · 8ad553a
1 parent 83d228b
commit 8ad553a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/atproto.py b/atproto.py
@@ -227,7 +227,7 @@ class ATProto(User, Protocol):
     ''
     LOGO_HTML = '<img src="/oauth_dropins_static/bluesky.svg">'
     ''
-    PDS_URL = f'https://atproto{common.SUPERDOMAIN}/'
+    PDS_URL = f'https://atproto{common.SUPERDOMAIN}'
     """Note that PDS hostname is atproto.brid.gy here, not bsky.brid.gy. Bluesky
     team currently has our hostname as atproto.brid.gy in their federation
     test. also note that PDS URL shouldn't include trailing slash.

diff --git a/tests/test_atproto.py b/tests/test_atproto.py
@@ -1396,7 +1396,7 @@ def test_set_username(self, mock_post, mock_get, mock_create_task, _):
             'services': {
                 'atproto_pds': {
                     'type': 'AtprotoPersonalDataServer',
-                    'endpoint': 'https://pds.local/',
+                    'endpoint': 'https://pds.local',
                 },
             },
             'prev': 'orig',

diff --git a/tests/test_protocol.py b/tests/test_protocol.py
@@ -462,7 +462,7 @@ def test_targets_checks_blocklisted_per_protocol(self):
         user = self.make_user(id='fake:user', cls=Fake, enabled_protocols=['atproto'])
 
         did_doc = copy.deepcopy(DID_DOC)
-        did_doc['service'][0]['serviceEndpoint'] = 'http://localhost/'
+        did_doc['service'][0]['serviceEndpoint'] = 'http://localhost'
         self.store_object(id='did:plc:foo', raw=did_doc)
 
         # store Objects so we don't try to fetch them remotely