chore: improve naming in tests

snapp-incubator · Sep 7, 2024 · ccc1a9b · ccc1a9b
1 parent 5c44add
commit ccc1a9b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/internal/controller/service/helpers.go b/internal/controller/service/helpers.go
@@ -51,8 +51,7 @@ var (
 )
 
 func init() {
-	err := cilium_labelsfilter.ParseLabelPrefixCfg([]string{""}, "")
-	if err != nil {
+	if err := cilium_labelsfilter.ParseLabelPrefixCfg([]string{""}, ""); err != nil {
 		log.Log.Info("error preparing cilium label filters", "error", err)
 	}
 }

diff --git a/internal/controller/service/helpers_test.go b/internal/controller/service/helpers_test.go
@@ -35,15 +35,15 @@ func TestBuildCNP_LabelFilter(t *testing.T) {
 		want    map[string]string
 	}{
 
-		{name: "ShuoldNotBeFiltered",
+		{name: "ShouldNotBeFiltered",
 			given: map[string]string{"app": "test", "stack": "backend"},
 			want:  map[string]string{"k8s.app": "test", "k8s.stack": "backend"}},
 
-		{name: "ShuoldBeFiltered",
+		{name: "ShouldBeFiltered_statefulset.kubernetes.io/pod-name",
 			given: map[string]string{"statefulset.kubernetes.io/pod-name": "test", "stack": "backend"},
 			want:  map[string]string{"k8s.stack": "backend"}},
 
-		{name: "ShuoldBeFiltered",
+		{name: "ShouldBeFiltered_k8s.io",
 			given: map[string]string{"k8s.io/fake": "test", "stack": "backend"},
 			want:  map[string]string{"k8s.stack": "backend"}},
 	}