New Access and Cache Architecture #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamMHD
requested review from
navidnabavi,
pedy4000,
ssttehrani,
m-yosefpor and
ZeynabRezaei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After these change the usual behavior about
AccessBindingwill change. From Now on we believe that it's better to useAccessBindingas a web service owner object to grant access to other namespaces and then limit token's access to services using token specs.Other than this, these changes will help multi-namespace management and behavior so we can manage to have same web services across different namespaces.
Also many code-style and refactors happened in this PR.
IMPORTANT NOTE: these changes are breaking and will change CRDs so this will be a backward compatibility breaker but Cerberus is young and we are going to accept these changes for now.