Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change access-forbidden to access-limited #33

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

navidnabavi
Copy link
Contributor

Access forbidden message may cause confusion for customers and users. I changed to to 'access-limited'

@navidnabavi navidnabavi requested a review from SamMHD January 7, 2024 11:34
…on, access forbidden message may cause confusion for customers and users
@navidnabavi navidnabavi force-pushed the better-message-load-shedding branch from d7182cf to 6aa155c Compare January 7, 2024 11:37
@SamMHD
Copy link
Collaborator

SamMHD commented Jan 7, 2024

Good point @navidnabavi 👍

thank you for the fix.

Copy link
Collaborator

@SamMHD SamMHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good code quality, thank you for the changes. I'll approve but please answer questions in the review and we can procced to merge.

pkg/auth/authenticator_test.go Show resolved Hide resolved
pkg/auth/authenticator_test.go Outdated Show resolved Hide resolved
pkg/auth/authenticator_test.go Show resolved Hide resolved
@navidnabavi navidnabavi force-pushed the better-message-load-shedding branch from df72d98 to 0361165 Compare January 7, 2024 19:26
@navidnabavi navidnabavi merged commit 7289e87 into main Jan 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants