-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: broken build; update to core22 #23
Conversation
@lucyllewy any idea why pack is failing? |
Looks like the pack is failing because
Maybe we need the |
I don't know why it failed in the CI. It succeeded on my system. (my wired internet is offline until I move home so I will prolly struggle to get a look at it for a bit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just commenting here to remove this from my review queue :-)
Please let me know when you'd like a new review.
I've updated the branch so you can add it back to your queue now. |
* Broken build fixed by upgrading to core22 * Add `npm-deps` part with a face `package.json` to work-around the npm plugin weirdness breaking the build step ordering that we need. Signed-off-by: Lucy Llewellyn <lucyllewy@ubuntu.com>
2609bd0
to
8e1719b
Compare
Feels like if we're going to trick the npm plugin with a fake package.json, maybe we should just not use the npm plugin at all and just override the build? Might also be worth looking at the proxy config for yarn - I don't think this will immediately work for lp builds - see the (recent) signal snap commit history which has some clues in it! |
I successfully built with |
also the fake package.json is purely to get nodejs installed and kept up to date. Its the easiest way to keep it updated without trying to duplicate effort and code by copying the npm plugin's download logic. |
npm-deps
part with a facepackage.json
to work-around the npm plugin weirdness breaking the build step ordering that we need.fixes: #21
fixes: #22