From 5cba90f97815a74e2b456943d2bd0726adc36af0 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Thu, 27 Apr 2023 12:00:36 +0000 Subject: [PATCH 01/57] Update mail to version 2.8.1 --- Gemfile.lock | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index bd04e54ef..1b9b14a5b 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -301,8 +301,11 @@ GEM loofah (2.20.0) crass (~> 1.0.2) nokogiri (>= 1.5.9) - mail (2.7.1) + mail (2.8.1) mini_mime (>= 0.1.1) + net-imap + net-pop + net-smtp marcel (1.0.2) matrix (0.4.2) method_source (1.0.0) From 16eb13e815270b5c97f8f37c0d69b295de26d443 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Thu, 27 Apr 2023 12:05:20 +0000 Subject: [PATCH 02/57] Update responders to version 3.1.0 --- Gemfile.lock | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index bd04e54ef..74e6c1d06 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -411,7 +411,7 @@ GEM puma (5.6.4) nio4r (~> 2.0) racc (1.6.2) - rack (2.2.6.4) + rack (2.2.7) rack-openid (1.4.2) rack (>= 1.1.0) ruby-openid (>= 2.1.8) @@ -460,9 +460,9 @@ GEM regexp_parser (2.5.0) request_store (1.5.1) rack (>= 1.4) - responders (3.0.1) - actionpack (>= 5.0) - railties (>= 5.0) + responders (3.1.0) + actionpack (>= 5.2) + railties (>= 5.2) rest-client (2.1.0) http-accept (>= 1.7.0, < 2.0) http-cookie (>= 1.0.2, < 2.0) From e734dbd3d6a9975a88540fe095bd2a2aea370d77 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 1 May 2023 07:45:27 +0000 Subject: [PATCH 03/57] Update rubocop to version 1.50.2 --- Gemfile.lock | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index bd04e54ef..de790a77f 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -382,8 +382,8 @@ GEM paper_trail (12.3.0) activerecord (>= 5.2) request_store (~> 1.1) - parallel (1.22.1) - parser (3.1.2.0) + parallel (1.23.0) + parser (3.2.2.1) ast (~> 2.4.1) pdf-core (0.9.0) pdf-inspector (1.3.0) @@ -457,7 +457,7 @@ GEM recaptcha (5.10.0) json redcarpet (3.6.0) - regexp_parser (2.5.0) + regexp_parser (2.8.0) request_store (1.5.1) rack (>= 1.4) responders (3.0.1) @@ -495,17 +495,18 @@ GEM rspec-mocks (~> 3.11) rspec-support (~> 3.11) rspec-support (3.12.0) - rubocop (1.30.1) + rubocop (1.50.2) + json (~> 2.3) parallel (~> 1.10) - parser (>= 3.1.0.0) + parser (>= 3.2.0.0) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.18.0, < 2.0) + rubocop-ast (>= 1.28.0, < 2.0) ruby-progressbar (~> 1.7) - unicode-display_width (>= 1.4.0, < 3.0) - rubocop-ast (1.18.0) - parser (>= 3.1.1.0) + unicode-display_width (>= 2.4.0, < 3.0) + rubocop-ast (1.28.0) + parser (>= 3.2.1.0) rubocop-rails (2.15.0) activesupport (>= 4.2.0) rack (>= 1.1) @@ -514,7 +515,7 @@ GEM rubocop (~> 1.19) ruby-oembed (0.16.1) ruby-openid (2.9.2) - ruby-progressbar (1.11.0) + ruby-progressbar (1.13.0) ruby-rc4 (0.1.5) ruby-vips (2.1.4) ffi (~> 1.12) From ada8d5a68c63c010ef761d64b4599961dd45a3cc Mon Sep 17 00:00:00 2001 From: Andrew Kvalheim Date: Tue, 28 Feb 2023 16:42:26 -0800 Subject: [PATCH 04/57] Add missing form labels Lost during 81853d1 --- app/views/proposals/_form.html.haml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/views/proposals/_form.html.haml b/app/views/proposals/_form.html.haml index ad81e0c25..3b80f5378 100644 --- a/app/views/proposals/_form.html.haml +++ b/app/views/proposals/_form.html.haml @@ -13,6 +13,7 @@ = f.label :subtitle = f.text_field :subtitle, class: 'form-control' .form-group + %label{for: 'users_selectize-selectized'} Speakers = f.select :speaker_ids, f.object.speakers.pluck(:username, :id), {}, { multiple: true, class: "form-control", id: "users_selectize", placeholder: "Speakers" } %span.help-block The people responsible for the event, beside you. You can only select existing users. @@ -63,7 +64,8 @@ Require participants to register to your event - if display_registration && action_is_edit .form-group - = f.number_field :max_attendees + = f.label :max_attendees + = f.number_field :max_attendees, class: 'form-control' %span.help-block - message = @event.room ? "Value must be between 1 and #{@event.room.size}" : 'Check room capacity after scheduling.' = 'The maximum number of participants. ' + message From c403247b795039648a78984ba9c51e81068911ee Mon Sep 17 00:00:00 2001 From: Andrew Kvalheim Date: Tue, 28 Feb 2023 17:10:10 -0800 Subject: [PATCH 05/57] Restore detailed event form for admins In #2987 the detailed view of the event form was inadvertently lost, presumably due to #2975 masking the problem. --- app/views/proposals/_form.html.haml | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/app/views/proposals/_form.html.haml b/app/views/proposals/_form.html.haml index 3b80f5378..e1c40e8a5 100644 --- a/app/views/proposals/_form.html.haml +++ b/app/views/proposals/_form.html.haml @@ -1,5 +1,8 @@ -- action_is_edit = @event.persisted? -- display_registration = current_user&.is_admin? || @program.cfp&.enable_registrations? +:ruby + action_is_edit = @event.persisted? + user_is_admin = current_user&.is_admin? + display_details = user_is_admin || action_is_edit + display_registration = user_is_admin || @program.cfp&.enable_registrations? %h4 Proposal Information @@ -8,7 +11,7 @@ = f.label :title %abbr{title: 'This field is required'} * = f.text_field :title, autofocus: true, required: true, class: 'form-control' -- if action_is_edit +- if display_details .form-group = f.label :subtitle = f.text_field :subtitle, class: 'form-control' @@ -32,7 +35,7 @@ = f.select :language, @languages, { include_blank: false}, { class: 'select-help-toggle form-control' } = render 'shared/select_help_text', f: f, for: :event_type_id, options: @conference.program.event_types do |event_type| = event_type.description -- if action_is_edit +- if display_details - if @conference.program.difficulty_levels.any? = f.label :difficulty_level = f.select :difficulty_level_id, @conference.program.difficulty_levels.map{|level| [level.title, level.id ] }, {include_blank: false}, { class: 'select-help-toggle form-control' } @@ -53,7 +56,7 @@ %span#abstract-maximum-word-count 250 words. - - if display_registration && action_is_edit + - if display_registration && display_details %h4 Event Registration %hr @@ -62,14 +65,14 @@ %label = f.check_box :require_registration Require participants to register to your event - - if display_registration && action_is_edit + - if display_registration && display_details .form-group = f.label :max_attendees = f.number_field :max_attendees, class: 'form-control' %span.help-block - message = @event.room ? "Value must be between 1 and #{@event.room.size}" : 'Check room capacity after scheduling.' = 'The maximum number of participants. ' + message - - if action_is_edit && current_user.has_any_role?(:admin, { name: :organizer, resource: @conference }, { name: :cfp, resource: @conference }) + - if display_details && current_user.has_any_role?(:admin, { name: :organizer, resource: @conference }, { name: :cfp, resource: @conference }) .checkbox %label = f.check_box :is_highlight From 694f397857a5393f7bbcfefe2a97a38c566a05c3 Mon Sep 17 00:00:00 2001 From: Andrew Kvalheim Date: Mon, 12 Sep 2022 10:02:15 -0700 Subject: [PATCH 06/57] Add test of admin editing a user Fails with: 1) User admin behaves like admin ability edits a user Failure/Error: raise ActionController::MissingExactTemplate, message ActionController::MissingExactTemplate: Admin::UsersController#edit is missing a template for request formats: text/html re #2975 --- spec/features/user_spec.rb | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/spec/features/user_spec.rb b/spec/features/user_spec.rb index 5644010f3..0bc07888d 100644 --- a/spec/features/user_spec.rb +++ b/spec/features/user_spec.rb @@ -3,12 +3,24 @@ require 'spec_helper' feature User do + let(:admin) { create(:admin) } + let!(:user) { create(:user) } shared_examples 'admin ability' do - + scenario 'edits a user', feature: true, js: true do + visit admin_users_path + within "tr#user_#{user.id}" do + click_on 'Edit' + end + fill_in 'Name', with: 'Edited Name' + click_button 'Update User' + expect(flash).to include('Updated Edited Name') + end end describe 'admin' do + before { sign_in admin } + it_behaves_like 'admin ability', :admin end end From 9f72c5b75b32ef3f9ea3bebb5909bd76a9018ae7 Mon Sep 17 00:00:00 2001 From: Andrew Kvalheim Date: Mon, 12 Sep 2022 11:26:24 -0700 Subject: [PATCH 07/57] Add test of conference organizer adding a proposal Fails with: 1) Event as an conference organizer create a proposal Failure/Error: raise ActionController::MissingExactTemplate, message ActionController::MissingExactTemplate: Admin::EventsController#new is missing a template for request formats: text/html re #2975 --- spec/features/proposals_spec.rb | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/spec/features/proposals_spec.rb b/spec/features/proposals_spec.rb index 26d55844a..c1c1326f8 100644 --- a/spec/features/proposals_spec.rb +++ b/spec/features/proposals_spec.rb @@ -27,6 +27,15 @@ sign_in organizer end + scenario 'adds a proposal', feature: true, js: true do + visit admin_conference_program_events_path(conference.short_title) + click_on 'Add Event' + fill_in 'Title', with: 'Organizer-Created Proposal' + fill_in 'Abstract', with: 'This proposal was created by an organizer.' + click_button 'Create Proposal' + expect(flash).to eq('Event was successfully submitted.') + end + scenario 'rejects a proposal', feature: true, js: true do visit admin_conference_program_events_path(conference.short_title) expect(page).to have_content 'Example Proposal' From 3ae1275fb5a18d9e6c54aa6ffe8b286538c3f21b Mon Sep 17 00:00:00 2001 From: Andrew Kvalheim Date: Wed, 14 Sep 2022 10:50:55 -0700 Subject: [PATCH 08/57] Restore views for Admin::EventsController#new and Admin::UsersController#edit 1. Restore views lost during 81853d1: git restore --source 4a16836 \ app/views/admin/users/_form.html.haml \ app/views/application/edit.html.haml \ app/views/application/new.html.haml mv app/views/application/edit.html.haml app/views/admin/users/ mv app/views/application/new.html.haml app/views/admin/events/ 2. Convert from Formtastic: - app/views/admin/users/_form.html.haml 3. Add header as in 81853d1: - app/views/admin/events/new.html.haml 4. Substitute partial unified in 88b5596: - app/views/admin/events/new.html.haml resolves #2975 --- app/views/admin/events/new.html.haml | 10 ++++++ app/views/admin/users/_form.html.haml | 44 +++++++++++++++++++++++++++ app/views/admin/users/edit.html.haml | 1 + 3 files changed, 55 insertions(+) create mode 100644 app/views/admin/events/new.html.haml create mode 100644 app/views/admin/users/_form.html.haml create mode 100644 app/views/admin/users/edit.html.haml diff --git a/app/views/admin/events/new.html.haml b/app/views/admin/events/new.html.haml new file mode 100644 index 000000000..edf9a1d0f --- /dev/null +++ b/app/views/admin/events/new.html.haml @@ -0,0 +1,10 @@ +.row + .col-md-12 + .page-header + %h1 + New Event +.row + .col-md-8 + = form_for(@event, url: @url) do |f| + = render partial: 'proposals/form', locals: { f: f } + = render partial: 'shared/user_selectize' diff --git a/app/views/admin/users/_form.html.haml b/app/views/admin/users/_form.html.haml new file mode 100644 index 000000000..51a50069a --- /dev/null +++ b/app/views/admin/users/_form.html.haml @@ -0,0 +1,44 @@ += form_for [:admin, @user] do |f| + %h4 Basic Information + - unless @user.new_record? + .pull-right + %b + Confirmed? + - if can? :toggle_confirmation, @user + = check_box_tag @user.id, @user.id, @user.confirmed?, + url: "#{toggle_confirmation_admin_user_path(@user.id)}?user[to_confirm]=", + class: 'switch-checkbox', + readonly: false + - else + = check_box_tag @user.id, @user.id, @user.confirmed?, + url: "#{toggle_confirmation_admin_user_path(@user.id)}?user[to_confirm]=", + class: 'switch-checkbox', + readonly: true + .checkbox + %label + = f.check_box :is_admin + Is admin + %span.help-block An admin can create a new conference, manage users and make other users admins. + .form-group + = f.label :name + = f.text_field :name, class: 'form-control' + - if @user.new_record? + .form-group + = label_tag :username + = text_field_tag :username, class: 'form-control' + .form-group + = f.label :email, required: true + %abbr{title: 'This field is required'} * + = f.email_field :email, required: true, class: 'form-control' + - if @user.new_record? + .form-group + = f.label :password + = f.password_field :password, class: 'form-control' + .form-group + = f.label :affiliation + = f.text_field :affiliation, class: 'form-control' + .form-group + = f.label :biography + = f.text_area :biography, rows: 10, data: { provide: 'markdown' }, class: 'form-control' + %span.help-block= markdown_hint + = f.submit nil, class: 'btn btn-primary' diff --git a/app/views/admin/users/edit.html.haml b/app/views/admin/users/edit.html.haml new file mode 100644 index 000000000..729927996 --- /dev/null +++ b/app/views/admin/users/edit.html.haml @@ -0,0 +1 @@ += render partial: 'form' From 8a5ab111a21627905736f001bc62e63702d75c93 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Fri, 5 May 2023 10:35:52 +0000 Subject: [PATCH 09/57] Update zeitwerk to version 2.6.8 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index feb68562b..494725978 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -624,7 +624,7 @@ GEM chronic (>= 0.6.3) xpath (3.2.0) nokogiri (~> 1.8) - zeitwerk (2.6.7) + zeitwerk (2.6.8) PLATFORMS ruby From 35d4af34b0a47f5361d7ffcb730607bfef4b75f8 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Fri, 5 May 2023 10:41:22 +0000 Subject: [PATCH 10/57] Update rails-assets-tinycolor to version 1.6.0 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index feb68562b..35f59e4f2 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -17,7 +17,7 @@ GEM rails-assets-momentjs (2.29.4) rails-assets-spectrum (1.8.0) rails-assets-jquery (>= 1.7.2) - rails-assets-tinycolor (1.4.1) + rails-assets-tinycolor (1.6.0) rails-assets-to-markdown (3.1.1) rails-assets-trianglify (1.2.0) rails-assets-waypoints (4.0.1) From 7e5dbeb1cd1d4cc5d02c4862beb4a3336ff53c76 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 09:45:34 +0000 Subject: [PATCH 11/57] Update mini_portile2 to version 2.8.2 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index ee38e6957..761d155a1 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -317,7 +317,7 @@ GEM rake mini_magick (4.12.0) mini_mime (1.1.2) - mini_portile2 (2.8.1) + mini_portile2 (2.8.2) minitest (5.18.0) momentjs-rails (2.29.4.1) railties (>= 3.1) From 60c0190c61e0b1f0b02e55d60af3753e670b2d6c Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 09:55:35 +0000 Subject: [PATCH 12/57] Update globalid to version 1.1.0 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 761d155a1..2abb40622 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -230,7 +230,7 @@ GEM sassc (~> 2.0) geckodriver-helper (0.24.0) archive-zip (~> 0.7) - globalid (1.0.1) + globalid (1.1.0) activesupport (>= 5.0) gravtastic (3.2.6) haml (5.2.2) From 9e36aa9721e5af5c87910cbee3cb495a7d6e1a4f Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Mon, 8 May 2023 13:46:49 +0200 Subject: [PATCH 13/57] Regenerate rubocop TODO --- .rubocop_todo.yml | 424 ++++++++++++++++++++++++---------------------- 1 file changed, 220 insertions(+), 204 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b4637d3e6..7ac6e2389 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,13 +1,13 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2022-02-10 16:47:29 UTC using RuboCop version 1.25.1. +# on 2023-05-08 11:46:10 UTC using RuboCop version 1.50.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include. # Include: **/*.gemfile, **/Gemfile, **/gems.rb Bundler/OrderedGems: @@ -15,14 +15,14 @@ Bundler/OrderedGems: - 'Gemfile' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: IndentationWidth. Layout/AssignmentIndentation: Exclude: - 'app/helpers/format_helper.rb' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/ClosingParenthesisIndentation: Exclude: - 'app/controllers/conference_registrations_controller.rb' @@ -30,8 +30,8 @@ Layout/ClosingParenthesisIndentation: - 'app/models/commercial.rb' - 'spec/controllers/users/omniauth_callbacks_controller_spec.rb' -# Offense count: 14 -# Cop supports --auto-correct. +# Offense count: 5 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment. Layout/CommentIndentation: Exclude: @@ -40,36 +40,35 @@ Layout/CommentIndentation: - 'app/models/conference.rb' - 'app/models/program.rb' - 'app/models/track.rb' - - 'spec/features/volunteers_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/EmptyLineAfterGuardClause: Exclude: - 'app/controllers/subscriptions_controller.rb' - 'app/models/program.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/EmptyLineAfterMagicComment: Exclude: - 'spec/models/conference_spec.rb' -# Offense count: 108 -# Cop supports --auto-correct. +# Offense count: 102 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, no_empty_lines Layout/EmptyLinesAroundBlockBody: Enabled: false # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/EmptyLinesAroundExceptionHandlingKeywords: Exclude: - 'app/models/payment.rb' # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. Layout/ExtraSpacing: Exclude: @@ -81,14 +80,14 @@ Layout/ExtraSpacing: - 'spec/models/conference_spec.rb' # Offense count: 43 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses Layout/FirstArgumentIndentation: Enabled: false # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_brackets Layout/FirstArrayElementIndentation: @@ -96,7 +95,7 @@ Layout/FirstArrayElementIndentation: - 'app/models/conference.rb' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_braces Layout/FirstHashElementIndentation: @@ -106,7 +105,7 @@ Layout/FirstHashElementIndentation: - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: normal, indented_internal_methods Layout/IndentationConsistency: @@ -115,7 +114,7 @@ Layout/IndentationConsistency: - 'app/models/event.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: IndentationWidth, EnforcedStyle. # SupportedStyles: spaces, tabs Layout/IndentationStyle: @@ -123,28 +122,46 @@ Layout/IndentationStyle: - 'app/controllers/admin/resources_controller.rb' # Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: Width, IgnoredPatterns. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Width, AllowedPatterns. Layout/IndentationWidth: Exclude: - 'app/controllers/users_controller.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment. Layout/LeadingCommentSpace: Exclude: - 'app/models/comment.rb' +# Offense count: 18 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: space, no_space +Layout/LineContinuationSpacing: + Exclude: + - 'app/controllers/admin/booths_controller.rb' + - 'app/controllers/admin/cfps_controller.rb' + - 'app/controllers/admin/commercials_controller.rb' + - 'app/controllers/admin/difficulty_levels_controller.rb' + - 'app/controllers/admin/event_types_controller.rb' + - 'app/controllers/admin/registrations_controller.rb' + - 'app/controllers/admin/splashpages_controller.rb' + - 'app/controllers/admin/venue_commercials_controller.rb' + - 'app/controllers/admin/venues_controller.rb' + - 'app/controllers/conference_registrations_controller.rb' + - 'app/models/cfp.rb' + # Offense count: 32 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: aligned, indented Layout/LineEndStringConcatenationIndentation: Enabled: false # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineArrayBraceLayout: @@ -152,13 +169,13 @@ Layout/MultilineArrayBraceLayout: - 'app/controllers/conference_registrations_controller.rb' # Offense count: 5 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/MultilineBlockLayout: Exclude: - 'app/serializers/conference_serializer.rb' # Offense count: 7 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineHashBraceLayout: @@ -167,22 +184,22 @@ Layout/MultilineHashBraceLayout: - 'config/routes.rb' - 'spec/models/event_spec.rb' -# Offense count: 35 -# Cop supports --auto-correct. +# Offense count: 33 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineMethodCallBraceLayout: Enabled: false -# Offense count: 55 -# Cop supports --auto-correct. +# Offense count: 47 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: aligned, indented, indented_relative_to_receiver Layout/MultilineMethodCallIndentation: Enabled: false # Offense count: 18 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: aligned, indented Layout/MultilineOperationIndentation: @@ -193,7 +210,7 @@ Layout/MultilineOperationIndentation: - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' # Offense count: 64 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/SpaceAfterComma: Exclude: - 'app/views/admin/booths/_all_booths.xlsx.axlsx' @@ -206,7 +223,7 @@ Layout/SpaceAfterComma: - 'lib/tasks/data_demo.rake' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: space, no_space Layout/SpaceAroundEqualsInParameterDefault: @@ -215,13 +232,13 @@ Layout/SpaceAroundEqualsInParameterDefault: - 'app/models/event.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/SpaceAroundKeyword: Exclude: - 'config/initializers/feature.rb' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/SpaceAroundMethodCallOperator: Exclude: - 'spec/features/cfp_ability_spec.rb' @@ -230,7 +247,7 @@ Layout/SpaceAroundMethodCallOperator: - 'spec/models/program_spec.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator. # SupportedStylesForExponentOperator: space, no_space Layout/SpaceAroundOperators: @@ -239,7 +256,7 @@ Layout/SpaceAroundOperators: - 'lib/tasks/data.rake' # Offense count: 139 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space # SupportedStylesForEmptyBraces: space, no_space @@ -247,7 +264,7 @@ Layout/SpaceBeforeBlockBraces: Enabled: false # Offense count: 7 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/SpaceBeforeComma: Exclude: - 'app/views/admin/booths/_all_booths.xlsx.axlsx' @@ -259,14 +276,14 @@ Layout/SpaceBeforeComma: - 'lib/tasks/data_demo.rake' # Offense count: 5 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment. Layout/SpaceBeforeFirstArg: Exclude: - 'app/controllers/admin/booths_controller.rb' # Offense count: 8 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets. # SupportedStyles: space, no_space, compact # SupportedStylesForEmptyBrackets: space, no_space @@ -276,7 +293,7 @@ Layout/SpaceInsideArrayLiteralBrackets: - 'config/routes.rb' # Offense count: 44 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. # SupportedStyles: space, no_space # SupportedStylesForEmptyBraces: space, no_space @@ -296,7 +313,7 @@ Layout/SpaceInsideBlockBraces: - 'spec/models/user_spec.rb' # Offense count: 37 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact # SupportedStylesForEmptyBraces: space, no_space @@ -318,7 +335,7 @@ Layout/SpaceInsideHashLiteralBraces: - 'spec/models/payment_spec.rb' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: space, compact, no_space Layout/SpaceInsideParens: @@ -326,13 +343,13 @@ Layout/SpaceInsideParens: - 'app/views/admin/registrations/index.xlsx.axlsx' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/SpaceInsidePercentLiteralDelimiters: Exclude: - 'Gemfile' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: final_newline, final_blank_line Layout/TrailingEmptyLines: @@ -341,7 +358,7 @@ Layout/TrailingEmptyLines: - 'lib/tasks/roles.rake' # Offense count: 13 -# Configuration parameters: IgnoredMethods. +# Configuration parameters: AllowedMethods, AllowedPatterns. Lint/AmbiguousBlockAssociation: Exclude: - 'spec/controllers/admin/conferences_controller_spec.rb' @@ -353,7 +370,7 @@ Lint/AmbiguousBlockAssociation: - 'spec/models/user_spec.rb' # Offense count: 13 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Lint/AmbiguousOperatorPrecedence: Exclude: - 'app/controllers/application_controller.rb' @@ -396,43 +413,49 @@ Lint/IneffectiveAccessModifier: - 'app/models/commercial.rb' - 'app/models/conference.rb' +# Offense count: 4 +# This cop supports unsafe autocorrection (--autocorrect-all). +Lint/NonAtomicFileOperation: + Exclude: + - 'spec/support/save_feature_failures.rb' + # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Lint/RedundantCopDisableDirective: Exclude: - 'spec/support/save_feature_failures.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. Lint/UnusedBlockArgument: Exclude: - 'lib/tasks/user.rake' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. Lint/UnusedMethodArgument: Exclude: - 'config/initializers/fuckups.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Lint/UriRegexp: Exclude: - 'app/models/commercial.rb' - 'app/models/contact.rb' # Offense count: 127 -# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. +# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: Max: 72 -# Offense count: 313 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. -# IgnoredMethods: refine +# Offense count: 28 +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode. +# AllowedMethods: refine Metrics/BlockLength: - Max: 1341 + Max: 211 # Offense count: 1 # Configuration parameters: CountBlocks. @@ -444,13 +467,13 @@ Metrics/BlockNesting: Metrics/ClassLength: Max: 652 -# Offense count: 29 -# Configuration parameters: IgnoredMethods. +# Offense count: 27 +# Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: Max: 16 # Offense count: 152 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 56 @@ -459,8 +482,8 @@ Metrics/MethodLength: Metrics/ModuleLength: Max: 174 -# Offense count: 26 -# Configuration parameters: IgnoredMethods. +# Offense count: 24 +# Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/PerceivedComplexity: Max: 19 @@ -472,7 +495,7 @@ Naming/AccessorMethodName: # Offense count: 2 # Configuration parameters: ForbiddenDelimiters. -# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$)) +# ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$)) Naming/HeredocDelimiterNaming: Exclude: - 'spec/factories/users.rb' @@ -480,7 +503,7 @@ Naming/HeredocDelimiterNaming: # Offense count: 2 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. -# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to +# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to Naming/MethodParameterName: Exclude: - 'app/models/conference.rb' @@ -497,7 +520,7 @@ Naming/PredicateName: - 'app/models/contact.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: PreferredName. Naming/RescuedExceptionsVariableName: Exclude: @@ -505,9 +528,9 @@ Naming/RescuedExceptionsVariableName: - 'app/models/payment.rb' # Offense count: 9 -# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers. +# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns. # SupportedStyles: snake_case, normalcase, non_integer -# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339 +# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64 Naming/VariableNumber: Exclude: - 'app/models/program.rb' @@ -526,13 +549,12 @@ RSpec/AnyInstance: - 'spec/controllers/proposals_controller_spec.rb' - 'spec/controllers/tracks_controller_spec.rb' -# Offense count: 351 -# Cop supports --auto-correct. +# Offense count: 350 +# This cop supports safe autocorrection (--autocorrect). RSpec/Capybara/CurrentPathExpectation: Exclude: - 'spec/features/base_controller_spec.rb' - 'spec/features/cfp_ability_spec.rb' - - 'spec/features/commercials_spec.rb' - 'spec/features/conference_registration_spec.rb' - 'spec/features/info_desk_ability_spec.rb' - 'spec/features/organization_admin_ability_spec.rb' @@ -544,8 +566,8 @@ RSpec/Capybara/CurrentPathExpectation: - 'spec/features/track_organizer_ability_spec.rb' - 'spec/features/user_ability_spec.rb' -# Offense count: 162 -# Cop supports --auto-correct. +# Offense count: 159 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnabledMethods. RSpec/Capybara/FeatureMethods: Enabled: false @@ -557,7 +579,7 @@ RSpec/ContextWording: Enabled: false # Offense count: 73 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: SkipBlocks, EnforcedStyle. # SupportedStyles: described_class, explicit RSpec/DescribedClass: @@ -578,7 +600,7 @@ RSpec/DescribedClass: - 'spec/serializers/track_serializer_spec.rb' # Offense count: 11 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowConsecutiveOneLiners. RSpec/EmptyLineAfterExample: Exclude: @@ -591,13 +613,13 @@ RSpec/EmptyLineAfterExample: - 'spec/models/survey_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/EmptyLineAfterExampleGroup: Exclude: - 'spec/controllers/admin/users_controller_spec.rb' # Offense count: 11 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/EmptyLineAfterFinalLet: Exclude: - 'spec/controllers/admin/event_schedules_controller_spec.rb' @@ -609,7 +631,7 @@ RSpec/EmptyLineAfterFinalLet: - 'spec/models/ticket_spec.rb' # Offense count: 17 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/EmptyLineAfterHook: Exclude: - 'spec/controllers/admin/booths_controller_spec.rb' @@ -624,7 +646,7 @@ RSpec/EmptyLineAfterHook: - 'spec/models/program_spec.rb' # Offense count: 8 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/EmptyLineAfterSubject: Exclude: - 'spec/ability/ability_spec.rb' @@ -636,19 +658,18 @@ RSpec/EmptyLineAfterSubject: - 'spec/models/survey_spec.rb' - 'spec/models/track_spec.rb' -# Offense count: 218 +# Offense count: 213 # Configuration parameters: CountAsOne. RSpec/ExampleLength: Max: 187 -# Offense count: 18 -# Cop supports --auto-correct. +# Offense count: 15 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: CustomTransform, IgnoredWords. RSpec/ExampleWording: Exclude: - 'spec/controllers/admin/organizations_controller_spec.rb' - 'spec/controllers/admin/registration_periods_controller_spec.rb' - - 'spec/controllers/application_controller_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/format_helper_spec.rb' @@ -658,7 +679,7 @@ RSpec/ExampleWording: - 'spec/models/ticket_spec.rb' # Offense count: 37 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: method_call, block RSpec/ExpectChange: @@ -678,7 +699,7 @@ RSpec/ExpectChange: - 'spec/models/event_spec.rb' - 'spec/models/user_spec.rb' -# Offense count: 10 +# Offense count: 9 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly. # Include: **/*_spec*rb*, **/spec/**/* RSpec/FilePath: @@ -690,12 +711,11 @@ RSpec/FilePath: - 'spec/features/proposals_spec.rb' - 'spec/features/ticket_purchases_spec.rb' - 'spec/features/venues_spec.rb' - - 'spec/features/volunteers_spec.rb' - 'spec/models/comment_spec.rb' - 'spec/models/openid.rb' -# Offense count: 169 -# Cop supports --auto-correct. +# Offense count: 172 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: implicit, each, example RSpec/HookArgument: @@ -707,7 +727,7 @@ RSpec/IdenticalEqualityAssertion: - 'spec/controllers/admin/conferences_controller_spec.rb' # Offense count: 140 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: is_expected, should RSpec/ImplicitExpect: @@ -728,7 +748,7 @@ RSpec/ImplicitExpect: - 'spec/models/user_spec.rb' # Offense count: 39 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: single_line_only, single_statement_only, disallow RSpec/ImplicitSubject: @@ -765,34 +785,33 @@ RSpec/InstanceVariable: - 'spec/models/user_spec.rb' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/LeadingSubject: Exclude: - 'spec/ability/ability_spec.rb' - 'spec/models/conference_spec.rb' - 'spec/models/ticket_spec.rb' -# Offense count: 59 +# Offense count: 61 RSpec/LetSetup: Enabled: false -# Offense count: 13 +# Offense count: 12 # Configuration parameters: . # SupportedStyles: have_received, receive RSpec/MessageSpies: EnforcedStyle: receive -# Offense count: 2 +# Offense count: 1 RSpec/MultipleDescribes: Exclude: - - 'spec/controllers/application_controller_spec.rb' - 'spec/models/conference_spec.rb' -# Offense count: 277 +# Offense count: 270 RSpec/MultipleExpectations: Max: 97 -# Offense count: 247 +# Offense count: 249 # Configuration parameters: AllowSubject. RSpec/MultipleMemoizedHelpers: Max: 32 @@ -810,8 +829,8 @@ RSpec/NamedSubject: RSpec/NestedGroups: Max: 7 -# Offense count: 85 -# Cop supports --auto-correct. +# Offense count: 83 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: not_to, to_not RSpec/NotToNot: @@ -822,16 +841,8 @@ RSpec/OverwritingSetup: Exclude: - 'spec/controllers/admin/booths_controller_spec.rb' -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers. -# SupportedStyles: inflected, explicit -RSpec/PredicateMatcher: - Exclude: - - 'spec/features/code_of_conduct_spec.rb' - # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/Rails/AvoidSetupHook: Exclude: - 'spec/features/versions_spec.rb' @@ -853,7 +864,7 @@ RSpec/RepeatedExampleGroupBody: - 'spec/models/conference_spec.rb' # Offense count: 10 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: and_return, block RSpec/ReturnFromStub: @@ -861,7 +872,7 @@ RSpec/ReturnFromStub: - 'spec/helpers/events_helper_spec.rb' # Offense count: 19 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/ScatteredLet: Exclude: - 'spec/ability/ability_spec.rb' @@ -902,29 +913,20 @@ Security/Open: - 'app/pdfs/ticket_pdf.rb' # Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: separated, grouped -Style/AccessorGrouping: +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/ArrayIntersect: Exclude: - - 'app/models/payment.rb' + - 'app/models/admin_ability.rb' -# Offense count: 12 -# Cop supports --auto-correct-all. +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: MinBranchesCount. Style/CaseLikeIf: Exclude: - - 'app/controllers/admin/roles_controller.rb' - - 'app/controllers/admin/users_controller.rb' - - 'app/helpers/application_helper.rb' - - 'app/helpers/versions_helper.rb' - - 'app/models/user.rb' - - 'app/views/admin/booths/booths.xlsx.axlsx' - 'app/views/admin/events/events.xlsx.axlsx' - - 'app/views/admin/tracks/tracks.xlsx.axlsx' - - 'lib/tasks/version.rake' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: is_a?, kind_of? Style/ClassCheck: @@ -932,7 +934,7 @@ Style/ClassCheck: - 'app/models/email_settings.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/ColonMethodCall: Exclude: - 'app/models/commercial.rb' @@ -944,7 +946,7 @@ Style/CombinableLoops: - 'db/migrate/20140820093735_migrating_supporter_registrations_to_ticket_users.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: Keywords, RequireColon. # Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE Style/CommentAnnotation: @@ -952,7 +954,7 @@ Style/CommentAnnotation: - 'spec/controllers/admin/versions_controller_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions. # SupportedStyles: assign_to_condition, assign_inside_condition Style/ConditionalAssignment: @@ -961,26 +963,26 @@ Style/ConditionalAssignment: - 'db/migrate/20140610165551_migrate_data_person_to_user.rb' - 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb' -# Offense count: 501 +# Offense count: 518 # Configuration parameters: AllowedConstants. Style/Documentation: Enabled: false # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/EmptyCaseCondition: Exclude: - 'app/helpers/format_helper.rb' - 'app/helpers/versions_helper.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/EmptyLiteral: Exclude: - 'spec/models/conference_spec.rb' # Offense count: 7 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: compact, expanded Style/EmptyMethod: @@ -993,41 +995,42 @@ Style/EmptyMethod: - 'db/migrate/20130206192339_rename_attending_social_events_with_partner.rb' - 'db/migrate/20130216122155_set_registration_defaults_to_false.rb' -# Offense count: 3 -# Cop supports --auto-correct. +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). Style/Encoding: Exclude: - 'app/uploaders/picture_uploader.rb' - 'spec/models/conference_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/ExpandPathArguments: Exclude: - 'bin/bundle' - 'bin/rspec' - 'spec/spec_helper.rb' -# Offense count: 41 -# Cop supports --auto-correct. +# Offense count: 39 +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). Style/GlobalStdStream: Exclude: - 'config/environments/production.rb' -# Offense count: 29 -# Configuration parameters: MinBodyLength. +# Offense count: 28 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals. Style/GuardClause: Enabled: false # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: braces, no_braces Style/HashAsLastArrayItem: @@ -1036,7 +1039,7 @@ Style/HashAsLastArrayItem: - 'app/models/user.rb' # Offense count: 5 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowSplatArgument. Style/HashConversion: Exclude: @@ -1050,41 +1053,41 @@ Style/HashLikeCase: Exclude: - 'app/helpers/versions_helper.rb' -# Offense count: 358 -# Cop supports --auto-correct. +# Offense count: 367 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys -# SupportedShorthandSyntax: always, never, either +# SupportedShorthandSyntax: always, never, either, consistent Style/HashSyntax: Enabled: false # Offense count: 2 -# Cop supports --auto-correct-all. +# This cop supports unsafe autocorrection (--autocorrect-all). Style/HashTransformValues: Exclude: - 'app/controllers/admin/comments_controller.rb' - 'app/helpers/chart_helper.rb' -# Offense count: 61 -# Cop supports --auto-correct. +# Offense count: 60 +# This cop supports safe autocorrection (--autocorrect). Style/IfUnlessModifier: Enabled: false -# Offense count: 10 -# Cop supports --auto-correct. +# Offense count: 8 +# This cop supports unsafe autocorrection (--autocorrect-all). Style/LineEndConcatenation: Exclude: - 'spec/features/conference_spec.rb' - 'spec/features/registration_periods_spec.rb' # Offense count: 1 -# Cop supports --auto-correct-all. +# This cop supports unsafe autocorrection (--autocorrect-all). Style/MapToHash: Exclude: - 'app/controllers/admin/comments_controller.rb' # Offense count: 9 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline Style/MethodDefParentheses: @@ -1093,13 +1096,20 @@ Style/MethodDefParentheses: - 'app/models/user.rb' - 'lib/tasks/demo_data_for_development.rake' +# Offense count: 3 +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/MinMaxComparison: + Exclude: + - 'app/helpers/format_helper.rb' + - 'app/models/cfp.rb' + # Offense count: 1 Style/MixinUsage: Exclude: - 'spec/spec_helper.rb' # Offense count: 7 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/MultilineIfModifier: Exclude: - 'app/controllers/conferences_controller.rb' @@ -1109,7 +1119,7 @@ Style/MultilineIfModifier: - 'app/models/registration_period.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: literals, strict Style/MutableConstant: @@ -1118,7 +1128,7 @@ Style/MutableConstant: - 'lib/tasks/migrate_config.rake' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowedMethods. # AllowedMethods: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with Style/NestedParenthesizedCalls: @@ -1127,14 +1137,14 @@ Style/NestedParenthesizedCalls: - 'spec/models/conference_spec.rb' # Offense count: 27 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, MinBodyLength. # SupportedStyles: skip_modifier_ifs, always Style/Next: Enabled: false # Offense count: 115 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedOctalStyle. # SupportedOctalStyles: zero_with_o, zero_only Style/NumericLiteralPrefix: @@ -1148,14 +1158,14 @@ Style/NumericLiteralPrefix: - 'spec/serializers/event_serializer_spec.rb' # Offense count: 7 -# Cop supports --auto-correct. -# Configuration parameters: Strict, AllowedNumbers. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Strict, AllowedNumbers, AllowedPatterns. Style/NumericLiterals: MinDigits: 15 # Offense count: 36 -# Cop supports --auto-correct-all. -# Configuration parameters: EnforcedStyle, IgnoredMethods. +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns. # SupportedStyles: predicate, comparison Style/NumericPredicate: Exclude: @@ -1177,24 +1187,23 @@ Style/OptionalArguments: Exclude: - 'app/models/event.rb' -# Offense count: 8 +# Offense count: 7 # Configuration parameters: AllowedMethods. # AllowedMethods: respond_to_missing? Style/OptionalBooleanParameter: Exclude: - 'app/controllers/admin/events_controller.rb' - - 'app/helpers/application_helper.rb' - 'app/helpers/format_helper.rb' - 'app/models/event.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/OrAssignment: Exclude: - 'app/controllers/schedules_controller.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions. Style/ParenthesesAroundCondition: Exclude: @@ -1202,8 +1211,8 @@ Style/ParenthesesAroundCondition: - 'app/controllers/application_controller.rb' - 'app/helpers/format_helper.rb' -# Offense count: 19 -# Cop supports --auto-correct. +# Offense count: 17 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: PreferredDelimiters. Style/PercentLiteralDelimiters: Exclude: @@ -1219,11 +1228,10 @@ Style/PercentLiteralDelimiters: - 'app/models/track.rb' - 'app/uploaders/picture_uploader.rb' - 'config/deploy.rb' - - 'config/initializers/formtastic.rb' - 'spec/models/program_spec.rb' # Offense count: 1 -# Cop supports --auto-correct-all. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: short, verbose Style/PreferredHashMethods: @@ -1231,54 +1239,61 @@ Style/PreferredHashMethods: - 'lib/tasks/migrate_config.rake' # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowedCompactTypes. # SupportedStyles: compact, exploded Style/RaiseArgs: EnforcedStyle: compact # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/RandomWithOffset: Exclude: - 'spec/factories/sponsors.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/RedundantAssignment: Exclude: - 'app/helpers/application_helper.rb' - 'app/helpers/format_helper.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/RedundantCondition: Exclude: - 'app/helpers/versions_helper.rb' - 'app/models/ticket.rb' +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantConstantBase: + Exclude: + - 'config/environments/production.rb' + - 'spec/spec_helper.rb' + # Offense count: 3 -# Cop supports --auto-correct-all. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: SafeForConstants. Style/RedundantFetchBlock: Exclude: - 'config/puma.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/RedundantParentheses: Exclude: - 'app/controllers/admin/base_controller.rb' # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/RedundantRegexpEscape: Exclude: - 'spec/models/room_spec.rb' - 'spec/models/user_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowMultipleReturnValues. Style/RedundantReturn: Exclude: @@ -1286,8 +1301,14 @@ Style/RedundantReturn: - 'app/controllers/admin/events_controller.rb' - 'app/controllers/admin/organizations_controller.rb' +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantStringEscape: + Exclude: + - 'app/models/conference.rb' + # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, AllowInnerSlashes. # SupportedStyles: slashes, percent_r, mixed Style/RegexpLiteral: @@ -1295,7 +1316,7 @@ Style/RegexpLiteral: - 'app/uploaders/picture_uploader.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: implicit, explicit Style/RescueStandardError: @@ -1304,7 +1325,7 @@ Style/RescueStandardError: - 'lib/tasks/migrate_config.rake' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: only_raise, only_fail, semantic Style/SignalException: @@ -1313,7 +1334,7 @@ Style/SignalException: - 'spec/support/flash.rb' # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowModifier. Style/SoleNestedConditional: Exclude: @@ -1325,20 +1346,20 @@ Style/SoleNestedConditional: - 'db/migrate/20151018152439_create_programs_table.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: RequireEnglish. -# SupportedStyles: use_perl_names, use_english_names +# SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names Style/SpecialGlobalVars: EnforcedStyle: use_perl_names -# Offense count: 31 -# Cop supports --auto-correct-all. +# Offense count: 28 +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Mode. Style/StringConcatenation: Enabled: false -# Offense count: 35 -# Cop supports --auto-correct. +# Offense count: 25 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: @@ -1354,7 +1375,7 @@ Style/StringLiterals: - 'lib/tasks/user.rake' # Offense count: 14 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: single_quotes, double_quotes Style/StringLiteralsInInterpolation: @@ -1364,21 +1385,22 @@ Style/StringLiteralsInInterpolation: - 'app/views/admin/events/_confirmed_events.xlsx.axlsx' - 'lib/tasks/dump_db.rake' -# Offense count: 109 -# Cop supports --auto-correct. +# Offense count: 110 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, MinSize. # SupportedStyles: percent, brackets Style/SymbolArray: Enabled: false -# Offense count: 10 -# Cop supports --auto-correct-all. -# Configuration parameters: AllowMethodsWithArguments, IgnoredMethods. -# IgnoredMethods: respond_to, define_method +# Offense count: 11 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments. +# AllowedMethods: define_method Style/SymbolProc: Exclude: - 'app/controllers/admin/comments_controller.rb' - 'app/controllers/admin/questions_controller.rb' + - 'app/controllers/admin/tracks_controller.rb' - 'app/models/ability.rb' - 'app/models/admin_ability.rb' - 'db/migrate/20140730104658_migrate_roles_for_cancancan.rb' @@ -1386,7 +1408,7 @@ Style/SymbolProc: - 'spec/support/flash.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, AllowSafeAssignment. # SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex Style/TernaryParentheses: @@ -1394,7 +1416,7 @@ Style/TernaryParentheses: - 'app/helpers/format_helper.rb' # Offense count: 21 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyleForMultiline. # SupportedStylesForMultiline: comma, consistent_comma, no_comma Style/TrailingCommaInHashLiteral: @@ -1402,23 +1424,17 @@ Style/TrailingCommaInHashLiteral: - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' - 'spec/models/conference_spec.rb' -# Offense count: 1 -# Cop supports --auto-correct. -Style/UnlessElse: - Exclude: - - 'config/routes.rb' - # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: WordRegex. # SupportedStyles: percent, brackets Style/WordArray: EnforcedStyle: percent MinSize: 6 -# Offense count: 532 -# Cop supports --auto-correct. -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# Offense count: 526 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https Layout/LineLength: Max: 619 From 76145f0874289b2d78dd33fe96dddde90d4b9273 Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Mon, 8 May 2023 13:48:43 +0200 Subject: [PATCH 14/57] Include rubocop-rails in configuration --- .rubocop.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index ff82c04cc..5238ee6bb 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,4 +1,6 @@ -require: rubocop-rspec +require: + - rubocop-rspec + - rubocop-rails inherit_from: .rubocop_todo.yml From 7b85b86e159175e6edc4ed82f905574205bb5aaf Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Mon, 8 May 2023 13:52:04 +0200 Subject: [PATCH 15/57] Introduces rubocop-capybara --- .rubocop.yml | 1 + Gemfile | 1 + Gemfile.lock | 3 +++ 3 files changed, 5 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index 5238ee6bb..edb15a050 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,6 +1,7 @@ require: - rubocop-rspec - rubocop-rails + - rubocop-capybara inherit_from: .rubocop_todo.yml diff --git a/Gemfile b/Gemfile index 301ff1a62..5879c729c 100644 --- a/Gemfile +++ b/Gemfile @@ -235,6 +235,7 @@ group :development do gem 'rubocop', require: false gem 'rubocop-rspec', require: false gem 'rubocop-rails', require: false + gem 'rubocop-capybara', require: false gem 'haml_lint' # to open mails gem 'letter_opener' diff --git a/Gemfile.lock b/Gemfile.lock index de790a77f..da8c96e20 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -507,6 +507,8 @@ GEM unicode-display_width (>= 2.4.0, < 3.0) rubocop-ast (1.28.0) parser (>= 3.2.1.0) + rubocop-capybara (2.18.0) + rubocop (~> 1.41) rubocop-rails (2.15.0) activesupport (>= 4.2.0) rack (>= 1.1) @@ -716,6 +718,7 @@ DEPENDENCIES rspec-activemodel-mocks rspec-rails rubocop + rubocop-capybara rubocop-rails rubocop-rspec ruby-oembed From ff52f02fa4e00e9763add6d7dcc111e218e8d2c2 Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Mon, 8 May 2023 13:53:15 +0200 Subject: [PATCH 16/57] Introduces rubocop-performance --- .rubocop.yml | 1 + Gemfile | 1 + Gemfile.lock | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index edb15a050..c8635706b 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -2,6 +2,7 @@ require: - rubocop-rspec - rubocop-rails - rubocop-capybara + - rubocop-performance inherit_from: .rubocop_todo.yml diff --git a/Gemfile b/Gemfile index 5879c729c..32452659a 100644 --- a/Gemfile +++ b/Gemfile @@ -236,6 +236,7 @@ group :development do gem 'rubocop-rspec', require: false gem 'rubocop-rails', require: false gem 'rubocop-capybara', require: false + gem 'rubocop-performance', require: false gem 'haml_lint' # to open mails gem 'letter_opener' diff --git a/Gemfile.lock b/Gemfile.lock index da8c96e20..43f514bae 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -509,6 +509,9 @@ GEM parser (>= 3.2.1.0) rubocop-capybara (2.18.0) rubocop (~> 1.41) + rubocop-performance (1.17.1) + rubocop (>= 1.7.0, < 2.0) + rubocop-ast (>= 0.4.0) rubocop-rails (2.15.0) activesupport (>= 4.2.0) rack (>= 1.1) @@ -719,6 +722,7 @@ DEPENDENCIES rspec-rails rubocop rubocop-capybara + rubocop-performance rubocop-rails rubocop-rspec ruby-oembed From 0c322b2541f924d10bd5f207977ce956aba698ac Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Mon, 8 May 2023 13:54:26 +0200 Subject: [PATCH 17/57] Update rubocop TODO for the new rails, capybara and performance cops. --- .rubocop_todo.yml | 428 +++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 408 insertions(+), 20 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 7ac6e2389..bb27ea754 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,12 +1,12 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2023-05-08 11:46:10 UTC using RuboCop version 1.50.2. +# on 2023-05-08 11:54:05 UTC using RuboCop version 1.50.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 2 +# Offense count: 3 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include. # Include: **/*.gemfile, **/Gemfile, **/gems.rb @@ -14,6 +14,41 @@ Bundler/OrderedGems: Exclude: - 'Gemfile' +# Offense count: 350 +# This cop supports safe autocorrection (--autocorrect). +Capybara/CurrentPathExpectation: + Exclude: + - 'spec/features/base_controller_spec.rb' + - 'spec/features/cfp_ability_spec.rb' + - 'spec/features/conference_registration_spec.rb' + - 'spec/features/info_desk_ability_spec.rb' + - 'spec/features/organization_admin_ability_spec.rb' + - 'spec/features/organizer_ability_spec.rb' + - 'spec/features/proposals_spec.rb' + - 'spec/features/registration_periods_spec.rb' + - 'spec/features/splashpage_spec.rb' + - 'spec/features/ticket_purchases_spec.rb' + - 'spec/features/track_organizer_ability_spec.rb' + - 'spec/features/user_ability_spec.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: have_no, not_to +Capybara/NegationMatcher: + Exclude: + - 'spec/features/versions_spec.rb' + +# Offense count: 82 +# This cop supports safe autocorrection (--autocorrect). +Capybara/SpecificFinders: + Enabled: false + +# Offense count: 1 +Capybara/SpecificMatcher: + Exclude: + - 'spec/features/sponsor_spec.rb' + # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: IndentationWidth. @@ -467,12 +502,12 @@ Metrics/BlockNesting: Metrics/ClassLength: Max: 652 -# Offense count: 27 +# Offense count: 26 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: Max: 16 -# Offense count: 152 +# Offense count: 151 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 56 @@ -482,7 +517,7 @@ Metrics/MethodLength: Metrics/ModuleLength: Max: 174 -# Offense count: 24 +# Offense count: 23 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/PerceivedComplexity: Max: 19 @@ -538,6 +573,32 @@ Naming/VariableNumber: - 'spec/models/payment_spec.rb' - 'spec/models/ticket_purchase_spec.rb' +# Offense count: 1 +# Configuration parameters: MinSize. +Performance/CollectionLiteralInLoop: + Exclude: + - 'app/models/conference.rb' + +# Offense count: 4 +# This cop supports unsafe autocorrection (--autocorrect-all). +Performance/InefficientHashSearch: + Exclude: + - 'app/controllers/admin/versions_controller.rb' + - 'app/helpers/versions_helper.rb' + +# Offense count: 2 +# This cop supports unsafe autocorrection (--autocorrect-all). +Performance/MapCompact: + Exclude: + - 'app/datatables/registration_datatable.rb' + - 'lib/tasks/events_registrations.rake' + +# Offense count: 2 +# This cop supports unsafe autocorrection (--autocorrect-all). +Performance/StringInclude: + Exclude: + - 'app/models/commercial.rb' + # Offense count: 28 RSpec/AnyInstance: Exclude: @@ -907,6 +968,343 @@ RSpec/VoidExpect: Exclude: - 'spec/models/conference_spec.rb' +# Offense count: 4 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ActiveRecordAliases: + Exclude: + - 'db/migrate/20141104131625_generate_username.rb' + - 'db/migrate/20141117214230_move_banner_description_to_conference.rb' + - 'db/migrate/20141118153918_change_venue_conference_association.rb' + - 'db/migrate/20141118162030_change_lodging_association_to_conference.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/ActiveRecordCallbacksOrder: + Exclude: + - 'app/models/event.rb' + - 'app/models/track.rb' + - 'app/models/venue.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ApplicationController: + Exclude: + - 'app/controllers/api/base_controller.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ApplicationMailer: + Exclude: + - 'app/mailers/mailbot.rb' + +# Offense count: 129 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ApplicationRecord: + Enabled: false + +# Offense count: 10 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent. +Rails/Blank: + Exclude: + - 'app/controllers/conferences_controller.rb' + - 'app/controllers/users/omniauth_callbacks_controller.rb' + - 'app/models/program.rb' + - 'app/models/user.rb' + - 'spec/factories/event_schedule.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/CompactBlank: + Exclude: + - 'app/controllers/surveys_controller.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Rails/ContentTag: + Exclude: + - 'app/helpers/application_helper.rb' + +# Offense count: 20 +# Configuration parameters: Include. +# Include: db/migrate/*.rb +Rails/CreateTableWithTimestamps: + Enabled: false + +# Offense count: 103 +# Configuration parameters: EnforcedStyle, AllowToTime. +# SupportedStyles: strict, flexible +Rails/Date: + Enabled: false + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforceForPrefixed. +Rails/Delegate: + Exclude: + - 'app/models/event.rb' + - 'app/models/room.rb' + - 'app/models/track.rb' + +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +Rails/DuplicateAssociation: + Exclude: + - 'app/models/program.rb' + - 'app/models/user.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +Rails/DurationArithmetic: + Exclude: + - 'spec/models/program_spec.rb' + - 'spec/models/user_spec.rb' + +# Offense count: 3 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Whitelist, AllowedMethods, AllowedReceivers. +# Whitelist: find_by_sql +# AllowedMethods: find_by_sql +# AllowedReceivers: Gem::Specification +Rails/DynamicFindBy: + Exclude: + - 'app/controllers/admin/events_controller.rb' + - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' + +# Offense count: 5 +# This cop supports safe autocorrection (--autocorrect). +Rails/EagerEvaluationLogMessage: + Exclude: + - 'app/controllers/admin/events_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/controllers/proposals_controller.rb' + - 'app/models/event.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/EnumHash: + Exclude: + - 'app/models/conference.rb' + - 'app/models/survey.rb' + - 'app/models/survey_question.rb' + +# Offense count: 7 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: slashes, arguments +Rails/FilePath: + Exclude: + - 'app/pdfs/ticket_pdf.rb' + - 'config/initializers/carrierwave.rb' + - 'lib/tasks/migrate_config.rake' + - 'spec/features/lodgings_spec.rb' + - 'spec/features/sponsor_spec.rb' + - 'spec/support/deprecation_shitlist.rb' + +# Offense count: 6 +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/HasAndBelongsToMany: + Exclude: + - 'app/models/conference.rb' + - 'app/models/qanswer.rb' + - 'app/models/question.rb' + - 'app/models/registration.rb' + - 'app/models/vchoice.rb' + +# Offense count: 24 +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/HasManyOrHasOneDependent: + Enabled: false + +# Offense count: 5 +# Configuration parameters: Include. +# Include: app/helpers/**/*.rb +Rails/HelperInstanceVariable: + Exclude: + - 'app/helpers/application_helper.rb' + - 'app/helpers/events_helper.rb' + - 'app/helpers/format_helper.rb' + +# Offense count: 8 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: numeric, symbolic +Rails/HttpStatus: + Exclude: + - 'app/controllers/admin/commercials_controller.rb' + - 'app/controllers/admin/event_schedules_controller.rb' + - 'app/controllers/admin/programs_controller.rb' + - 'app/controllers/admin/tracks_controller.rb' + - 'app/controllers/admin/venue_commercials_controller.rb' + - 'app/controllers/commercials_controller.rb' + +# Offense count: 99 +Rails/I18nLocaleTexts: + Enabled: false + +# Offense count: 7 +# Configuration parameters: IgnoreScopes, Include. +# Include: app/models/**/*.rb +Rails/InverseOf: + Exclude: + - 'app/models/booth.rb' + - 'app/models/conference.rb' + - 'app/models/event.rb' + - 'app/models/user.rb' + +# Offense count: 1 +# Configuration parameters: Include. +# Include: app/controllers/**/*.rb, app/mailers/**/*.rb +Rails/LexicallyScopedActionFilter: + Exclude: + - 'app/controllers/registrations_controller.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Rails/LinkToBlank: + Exclude: + - 'app/helpers/format_helper.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Include. +# Include: app/mailers/**/*.rb +Rails/MailerName: + Exclude: + - 'app/mailers/mailbot.rb' + +# Offense count: 3 +Rails/OutputSafety: + Exclude: + - 'app/helpers/events_helper.rb' + - 'app/models/commercial.rb' + +# Offense count: 6 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: conservative, aggressive +Rails/PluckInWhere: + Exclude: + - 'app/models/ability.rb' + - 'app/models/admin_ability.rb' + +# Offense count: 16 +# This cop supports safe autocorrection (--autocorrect). +Rails/PluralizationGrammar: + Exclude: + - 'spec/models/conference_spec.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Rails/Presence: + Exclude: + - 'app/controllers/schedules_controller.rb' + - 'app/models/user.rb' + +# Offense count: 15 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank. +Rails/Present: + Exclude: + - 'app/models/cfp.rb' + - 'app/models/email_settings.rb' + - 'app/models/event.rb' + - 'app/models/program.rb' + - 'app/models/venue.rb' + +# Offense count: 6 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Include. +# Include: **/Rakefile, **/*.rake +Rails/RakeEnvironment: + Exclude: + - 'lib/tasks/dump_db.rake' + - 'lib/tasks/spec.rake' + +# Offense count: 21 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/RedundantPresenceValidationOnBelongsTo: + Enabled: false + +# Offense count: 2 +Rails/RenderInline: + Exclude: + - 'app/controllers/conferences_controller.rb' + - 'app/controllers/schedules_controller.rb' + +# Offense count: 4 +# Configuration parameters: Include. +# Include: db/**/*.rb +Rails/ReversibleMigration: + Exclude: + - 'db/migrate/20170108053041_add_default_to_revision_in_conference.rb' + - 'db/migrate/20170715131706_make_track_state_not_null_and_add_default_value.rb' + - 'db/migrate/20170720134353_make_track_cfp_active_not_null.rb' + - 'db/migrate/20171118113113_change_visit_id_type_of_ahoy_events_to_integer.rb' + +# Offense count: 48 +# Configuration parameters: ForbiddenMethods, AllowedMethods. +# ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all +Rails/SkipsModelValidations: + Enabled: false + +# Offense count: 40 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: strict, flexible +Rails/TimeZone: + Exclude: + - 'app/models/comment.rb' + - 'app/models/conference.rb' + - 'config/environments/test.rb' + - 'db/migrate/20180226032958_add_created_at_and_updated_at_to_event_types.rb' + - 'db/migrate/20180313012253_add_timestamps_to_tickets.rb' + - 'lib/tasks/dump_db.rake' + - 'spec/controllers/admin/comments_controller_spec.rb' + - 'spec/factories/users.rb' + - 'spec/models/conference_spec.rb' + +# Offense count: 13 +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/UniqueValidationWithoutIndex: + Exclude: + - 'app/models/booth.rb' + - 'app/models/cfp.rb' + - 'app/models/commercial.rb' + - 'app/models/conference.rb' + - 'app/models/events_registration.rb' + - 'app/models/organization.rb' + - 'app/models/registration.rb' + - 'app/models/role.rb' + - 'app/models/subscription.rb' + - 'app/models/survey_reply.rb' + - 'app/models/survey_submission.rb' + - 'app/models/track.rb' + - 'app/models/vote.rb' + +# Offense count: 17 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/WhereEquals: + Exclude: + - 'app/controllers/admin/registrations_controller.rb' + - 'app/models/admin_ability.rb' + - 'app/models/conference.rb' + - 'app/models/event_schedule.rb' + - 'app/models/program.rb' + - 'app/models/user.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Rails/WhereNot: + Exclude: + - 'db/migrate/20140820093735_migrating_supporter_registrations_to_ticket_users.rb' + # Offense count: 3 Security/Open: Exclude: @@ -1002,15 +1400,13 @@ Style/Encoding: - 'app/uploaders/picture_uploader.rb' - 'spec/models/conference_spec.rb' -# Offense count: 3 +# Offense count: 1 # This cop supports safe autocorrection (--autocorrect). Style/ExpandPathArguments: Exclude: - - 'bin/bundle' - - 'bin/rspec' - 'spec/spec_helper.rb' -# Offense count: 39 +# Offense count: 36 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -1068,7 +1464,7 @@ Style/HashTransformValues: - 'app/controllers/admin/comments_controller.rb' - 'app/helpers/chart_helper.rb' -# Offense count: 60 +# Offense count: 58 # This cop supports safe autocorrection (--autocorrect). Style/IfUnlessModifier: Enabled: false @@ -1345,27 +1741,19 @@ Style/SoleNestedConditional: - 'db/migrate/20140801170430_move_event_media_to_commercial.rb' - 'db/migrate/20151018152439_create_programs_table.rb' -# Offense count: 1 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: RequireEnglish. -# SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names -Style/SpecialGlobalVars: - EnforcedStyle: use_perl_names - # Offense count: 28 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Mode. Style/StringConcatenation: Enabled: false -# Offense count: 25 +# Offense count: 17 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Exclude: - 'Gemfile' - - 'bin/rspec' - 'config/deploy.rb' - 'config/environments/production.rb' - 'config/puma.rb' @@ -1432,7 +1820,7 @@ Style/WordArray: EnforcedStyle: percent MinSize: 6 -# Offense count: 526 +# Offense count: 524 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https From e07846018827d2d5a7869d8868f477cb60428751 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 12:30:21 +0000 Subject: [PATCH 18/57] Update sqlite3 to version 1.6.2 --- Gemfile.lock | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index b78b2f103..48d8cd5ad 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -576,7 +576,8 @@ GEM actionpack (>= 5.2) activesupport (>= 5.2) sprockets (>= 3.0.0) - sqlite3 (1.4.4) + sqlite3 (1.6.2) + mini_portile2 (~> 2.8.0) ssrf_filter (1.1.1) stripe (5.53.0) stripe-ruby-mock (3.1.0.rc3) From f1efe98f6990ac7549b54d27b25aef3b756a41a3 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 12:35:36 +0000 Subject: [PATCH 19/57] Update font-awesome-sass to version 6.4.0 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index b78b2f103..dfb1d4704 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -226,7 +226,7 @@ GEM fastimage (2.2.6) feature (1.4.0) ffi (1.15.5) - font-awesome-sass (6.1.1) + font-awesome-sass (6.4.0) sassc (~> 2.0) geckodriver-helper (0.24.0) archive-zip (~> 0.7) From d9f86d05640e17cf1933bbf413aaa54402d4dd0c Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Fri, 28 Apr 2023 14:15:45 +0000 Subject: [PATCH 20/57] Drop country_select We are using i18n_data directly. --- Gemfile | 2 +- Gemfile.lock | 14 ++------------ app/models/venue.rb | 3 +-- app/views/conferences/_header.haml | 2 +- 4 files changed, 5 insertions(+), 16 deletions(-) diff --git a/Gemfile b/Gemfile index 301ff1a62..cf878fe02 100644 --- a/Gemfile +++ b/Gemfile @@ -137,7 +137,7 @@ gem 'leaflet-rails' gem 'gravtastic' # for country selects -gem 'country_select' +gem 'i18n_data' # as PDF generator gem 'prawn-qrcode' diff --git a/Gemfile.lock b/Gemfile.lock index bd04e54ef..b7998a3a7 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -170,12 +170,6 @@ GEM concurrent-ruby (1.2.2) countable-rails (0.0.1) railties (>= 3.1) - countries (5.0.2) - i18n_data (~> 0.16.0) - sixarm_ruby_unaccent (~> 1.1) - country_select (7.0.0) - countries (~> 5.0) - sort_alphabetical (~> 1.1) crack (0.4.5) rexml crass (1.0.6) @@ -256,7 +250,7 @@ GEM domain_name (~> 0.5) i18n (1.13.0) concurrent-ruby (~> 1.0) - i18n_data (0.16.0) + i18n_data (0.17.1) simple_po_parser (~> 1.1) icalendar (2.8.0) ice_cube (~> 0.16) @@ -552,14 +546,11 @@ GEM simplecov (~> 0.19) simplecov-html (0.12.3) simplecov_json_formatter (0.1.4) - sixarm_ruby_unaccent (1.2.0) skylight (5.3.4) activesupport (>= 5.2.0) snaky_hash (2.0.1) hashie version_gem (~> 1.1, >= 1.1.1) - sort_alphabetical (1.1.0) - unicode_utils (>= 1.2.2) sprockets (4.2.0) concurrent-ruby (~> 1.0) rack (>= 2.2.4, < 4) @@ -594,7 +585,6 @@ GEM unf_ext unf_ext (0.0.8.2) unicode-display_width (2.4.2) - unicode_utils (1.4.0) unobtrusive_flash (3.3.1) railties version_gem (1.1.2) @@ -647,7 +637,6 @@ DEPENDENCIES cloudinary cocoon countable-rails - country_select daemons dalli database_cleaner @@ -663,6 +652,7 @@ DEPENDENCIES gravtastic haml-rails haml_lint + i18n_data icalendar iso-639 jquery-datatables-rails diff --git a/app/models/venue.rb b/app/models/venue.rb index 5df7c60e1..0064b5c46 100644 --- a/app/models/venue.rb +++ b/app/models/venue.rb @@ -20,8 +20,7 @@ def address end def country_name - name = ISO3166::Country[country] - name&.iso_short_name + I18nData.countries[country] end def location? diff --git a/app/views/conferences/_header.haml b/app/views/conferences/_header.haml index c3a75bbca..cc9ffa8fb 100644 --- a/app/views/conferences/_header.haml +++ b/app/views/conferences/_header.haml @@ -22,7 +22,7 @@ = sanitize link_to(venue.name, venue.website) - else = venue.city - - if venue.country_name != 'US' + - if venue.country_name • = venue.country_name From ad73522f997bd31c824e6978005b0dba10a1185d Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 15:30:36 +0000 Subject: [PATCH 21/57] Update devise to version 4.9.2 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 60e958fef..5de7becc7 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -187,7 +187,7 @@ GEM delayed_job_active_record (4.1.7) activerecord (>= 3.0, < 8.0) delayed_job (>= 3.0, < 5) - devise (4.8.1) + devise (4.9.2) bcrypt (~> 3.0) orm_adapter (~> 0.1) railties (>= 4.1.0) From 2b4ae30075bb4facff26c4ac9a3019dd8ab877f0 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 15:35:44 +0000 Subject: [PATCH 22/57] Update capybara to version 3.39.0 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index f7747543d..243b5a61f 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -127,7 +127,7 @@ GEM builder (3.2.4) byebug (11.1.3) cancancan (3.5.0) - capybara (3.37.1) + capybara (3.39.0) addressable matrix mini_mime (>= 0.1.3) From bd4b417f32d1ef8f1ab017fac97197078250834c Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 12:15:31 +0000 Subject: [PATCH 23/57] Update rubocop-rails to version 2.19.1 --- .rubocop_todo.yml | 81 +++++++++++++++++++++++++++++++++++------------ Gemfile.lock | 6 ++-- 2 files changed, 64 insertions(+), 23 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index bb27ea754..1614d0808 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2023-05-08 11:54:05 UTC using RuboCop version 1.50.2. +# on 2023-05-08 15:38:24 UTC using RuboCop version 1.50.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -89,7 +89,7 @@ Layout/EmptyLineAfterMagicComment: Exclude: - 'spec/models/conference_spec.rb' -# Offense count: 102 +# Offense count: 100 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, no_empty_lines @@ -436,12 +436,6 @@ Lint/DuplicateHashKey: - 'db/migrate/20140801164901_move_conference_media_to_commercial.rb' - 'db/migrate/20140801170430_move_event_media_to_commercial.rb' -# Offense count: 1 -# Configuration parameters: AllowComments, AllowEmptyLambdas. -Lint/EmptyBlock: - Exclude: - - 'spec/features/user_spec.rb' - # Offense count: 4 Lint/IneffectiveAccessModifier: Exclude: @@ -627,7 +621,7 @@ RSpec/Capybara/CurrentPathExpectation: - 'spec/features/track_organizer_ability_spec.rb' - 'spec/features/user_ability_spec.rb' -# Offense count: 159 +# Offense count: 161 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnabledMethods. RSpec/Capybara/FeatureMethods: @@ -719,7 +713,7 @@ RSpec/EmptyLineAfterSubject: - 'spec/models/survey_spec.rb' - 'spec/models/track_spec.rb' -# Offense count: 213 +# Offense count: 215 # Configuration parameters: CountAsOne. RSpec/ExampleLength: Max: 187 @@ -968,6 +962,14 @@ RSpec/VoidExpect: Exclude: - 'spec/models/conference_spec.rb' +# Offense count: 24 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: ExpectedOrder, Include. +# ExpectedOrder: index, show, new, edit, create, update, destroy +# Include: app/controllers/**/*.rb +Rails/ActionOrder: + Enabled: false + # Offense count: 4 # This cop supports unsafe autocorrection (--autocorrect-all). Rails/ActiveRecordAliases: @@ -1027,11 +1029,24 @@ Rails/ContentTag: Exclude: - 'app/helpers/application_helper.rb' -# Offense count: 20 +# Offense count: 13 # Configuration parameters: Include. # Include: db/migrate/*.rb Rails/CreateTableWithTimestamps: - Enabled: false + Exclude: + - 'db/migrate/20121223115117_create_rooms_table.rb' + - 'db/migrate/20121223120413_create_event_types.rb' + - 'db/migrate/20130202130737_create_supporter_level_table.rb' + - 'db/migrate/20130202130923_create_table_supporter_registrations.rb' + - 'db/migrate/20130216070725_create_social_events_table.rb' + - 'db/migrate/20131228214532_create_vchoices.rb' + - 'db/migrate/20140109191145_create_qanswers.rb' + - 'db/migrate/20140623100942_create_visits.rb' + - 'db/migrate/20140623101032_create_ahoy_events.rb' + - 'db/migrate/20160309182642_remove_social_events_table.rb' + - 'db/migrate/20160628093634_create_survey_questions.rb' + - 'db/migrate/20170129075434_create_resources_table.rb' + - 'db/migrate/20170529215453_create_organizations.rb' # Offense count: 103 # Configuration parameters: EnforcedStyle, AllowToTime. @@ -1050,6 +1065,7 @@ Rails/Delegate: # Offense count: 4 # This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Severity. Rails/DuplicateAssociation: Exclude: - 'app/models/program.rb' @@ -1065,9 +1081,9 @@ Rails/DurationArithmetic: # Offense count: 3 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Whitelist, AllowedMethods, AllowedReceivers. -# Whitelist: find_by_sql -# AllowedMethods: find_by_sql -# AllowedReceivers: Gem::Specification +# Whitelist: find_by_sql, find_by_token_for +# AllowedMethods: find_by_sql, find_by_token_for +# AllowedReceivers: Gem::Specification, page Rails/DynamicFindBy: Exclude: - 'app/controllers/admin/events_controller.rb' @@ -1143,7 +1159,7 @@ Rails/HttpStatus: - 'app/controllers/admin/venue_commercials_controller.rb' - 'app/controllers/commercials_controller.rb' -# Offense count: 99 +# Offense count: 100 Rails/I18nLocaleTexts: Enabled: false @@ -1237,6 +1253,18 @@ Rails/RenderInline: - 'app/controllers/conferences_controller.rb' - 'app/controllers/schedules_controller.rb' +# Offense count: 10 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Include. +# Include: spec/controllers/**/*.rb, spec/requests/**/*.rb, test/controllers/**/*.rb, test/integration/**/*.rb +Rails/ResponseParsedBody: + Exclude: + - 'spec/controllers/api/v1/conferences_controller_spec.rb' + - 'spec/controllers/api/v1/events_controller_spec.rb' + - 'spec/controllers/api/v1/rooms_controller_spec.rb' + - 'spec/controllers/api/v1/speakers_controller_spec.rb' + - 'spec/controllers/api/v1/tracks_controller_spec.rb' + # Offense count: 4 # Configuration parameters: Include. # Include: db/**/*.rb @@ -1253,6 +1281,12 @@ Rails/ReversibleMigration: Rails/SkipsModelValidations: Enabled: false +# Offense count: 77 +# Configuration parameters: Include. +# Include: db/**/*.rb +Rails/ThreeStateBooleanColumn: + Enabled: false + # Offense count: 40 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. @@ -1269,6 +1303,13 @@ Rails/TimeZone: - 'spec/factories/users.rb' - 'spec/models/conference_spec.rb' +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Severity. +Rails/TopLevelHashWithIndifferentAccess: + Exclude: + - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' + # Offense count: 13 # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -1310,10 +1351,11 @@ Security/Open: Exclude: - 'app/pdfs/ticket_pdf.rb' -# Offense count: 2 +# Offense count: 3 # This cop supports unsafe autocorrection (--autocorrect-all). Style/ArrayIntersect: Exclude: + - 'app/helpers/application_helper.rb' - 'app/models/admin_ability.rb' # Offense count: 1 @@ -1780,15 +1822,14 @@ Style/StringLiteralsInInterpolation: Style/SymbolArray: Enabled: false -# Offense count: 11 +# Offense count: 10 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments. -# AllowedMethods: define_method +# AllowedMethods: define_method, mail, respond_to Style/SymbolProc: Exclude: - 'app/controllers/admin/comments_controller.rb' - 'app/controllers/admin/questions_controller.rb' - - 'app/controllers/admin/tracks_controller.rb' - 'app/models/ability.rb' - 'app/models/admin_ability.rb' - 'db/migrate/20140730104658_migrate_roles_for_cancancan.rb' diff --git a/Gemfile.lock b/Gemfile.lock index b78b2f103..1aa49d08e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -508,17 +508,17 @@ GEM rubocop-ast (>= 1.28.0, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 2.4.0, < 3.0) - rubocop-ast (1.28.0) + rubocop-ast (1.28.1) parser (>= 3.2.1.0) rubocop-capybara (2.18.0) rubocop (~> 1.41) rubocop-performance (1.17.1) rubocop (>= 1.7.0, < 2.0) rubocop-ast (>= 0.4.0) - rubocop-rails (2.15.0) + rubocop-rails (2.19.1) activesupport (>= 4.2.0) rack (>= 1.1) - rubocop (>= 1.7.0, < 2.0) + rubocop (>= 1.33.0, < 2.0) rubocop-rspec (2.11.1) rubocop (~> 1.19) ruby-oembed (0.16.1) From 7067870949a1d241b5574ea40d082805c2805c94 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 15:55:34 +0000 Subject: [PATCH 24/57] Update recaptcha to version 5.13.0 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index fb26bcf9c..adc79dc05 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -451,7 +451,7 @@ GEM zeitwerk (~> 2.5) rainbow (3.1.1) rake (13.0.6) - recaptcha (5.10.0) + recaptcha (5.13.0) json redcarpet (3.6.0) regexp_parser (2.8.0) From abaf51fda58f61fd490902a2350d1c3056ea05c4 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 15:34:33 +0000 Subject: [PATCH 25/57] Update leaflet-rails to version 1.9.3 --- Gemfile.lock | 116 +++++++++++++++++++++--------------------- config/application.rb | 2 + 2 files changed, 59 insertions(+), 59 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index f7747543d..b3d348988 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -26,47 +26,47 @@ GEM remote: https://rubygems.org/ specs: Ascii85 (1.1.0) - actioncable (7.0.1) - actionpack (= 7.0.1) - activesupport (= 7.0.1) + actioncable (7.0.4.3) + actionpack (= 7.0.4.3) + activesupport (= 7.0.4.3) nio4r (~> 2.0) websocket-driver (>= 0.6.1) - actionmailbox (7.0.1) - actionpack (= 7.0.1) - activejob (= 7.0.1) - activerecord (= 7.0.1) - activestorage (= 7.0.1) - activesupport (= 7.0.1) + actionmailbox (7.0.4.3) + actionpack (= 7.0.4.3) + activejob (= 7.0.4.3) + activerecord (= 7.0.4.3) + activestorage (= 7.0.4.3) + activesupport (= 7.0.4.3) mail (>= 2.7.1) net-imap net-pop net-smtp - actionmailer (7.0.1) - actionpack (= 7.0.1) - actionview (= 7.0.1) - activejob (= 7.0.1) - activesupport (= 7.0.1) + actionmailer (7.0.4.3) + actionpack (= 7.0.4.3) + actionview (= 7.0.4.3) + activejob (= 7.0.4.3) + activesupport (= 7.0.4.3) mail (~> 2.5, >= 2.5.4) net-imap net-pop net-smtp rails-dom-testing (~> 2.0) - actionpack (7.0.1) - actionview (= 7.0.1) - activesupport (= 7.0.1) + actionpack (7.0.4.3) + actionview (= 7.0.4.3) + activesupport (= 7.0.4.3) rack (~> 2.0, >= 2.2.0) rack-test (>= 0.6.3) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.2.0) - actiontext (7.0.1) - actionpack (= 7.0.1) - activerecord (= 7.0.1) - activestorage (= 7.0.1) - activesupport (= 7.0.1) + actiontext (7.0.4.3) + actionpack (= 7.0.4.3) + activerecord (= 7.0.4.3) + activestorage (= 7.0.4.3) + activesupport (= 7.0.4.3) globalid (>= 0.6.0) nokogiri (>= 1.8.5) - actionview (7.0.1) - activesupport (= 7.0.1) + actionview (7.0.4.3) + activesupport (= 7.0.4.3) builder (~> 3.1) erubi (~> 1.4) rails-dom-testing (~> 2.0) @@ -76,22 +76,22 @@ GEM activemodel (>= 4.1, < 7.1) case_transform (>= 0.2) jsonapi-renderer (>= 0.1.1.beta1, < 0.3) - activejob (7.0.1) - activesupport (= 7.0.1) + activejob (7.0.4.3) + activesupport (= 7.0.4.3) globalid (>= 0.3.6) - activemodel (7.0.1) - activesupport (= 7.0.1) - activerecord (7.0.1) - activemodel (= 7.0.1) - activesupport (= 7.0.1) - activestorage (7.0.1) - actionpack (= 7.0.1) - activejob (= 7.0.1) - activerecord (= 7.0.1) - activesupport (= 7.0.1) + activemodel (7.0.4.3) + activesupport (= 7.0.4.3) + activerecord (7.0.4.3) + activemodel (= 7.0.4.3) + activesupport (= 7.0.4.3) + activestorage (7.0.4.3) + actionpack (= 7.0.4.3) + activejob (= 7.0.4.3) + activerecord (= 7.0.4.3) + activesupport (= 7.0.4.3) marcel (~> 1.0) mini_mime (>= 1.1.0) - activesupport (7.0.1) + activesupport (7.0.4.3) concurrent-ruby (~> 1.0, >= 1.0.2) i18n (>= 1.6, < 2) minitest (>= 5.1) @@ -182,6 +182,7 @@ GEM activerecord (>= 5.a) database_cleaner-core (~> 2.0.0) database_cleaner-core (2.0.1) + date (3.3.3) delayed_job (4.1.11) activesupport (>= 3.0, < 8.0) delayed_job_active_record (4.1.7) @@ -196,7 +197,6 @@ GEM devise_ichain_authenticatable (0.3.2) devise (>= 2.2) diff-lcs (1.5.0) - digest (3.1.1) docile (1.4.0) domain_name (0.5.20190701) unf (>= 0.0.5, < 1.0.0) @@ -278,7 +278,7 @@ GEM jwt (2.7.0) launchy (2.5.2) addressable (~> 2.8) - leaflet-rails (1.7.0) + leaflet-rails (1.9.3) rails (>= 4.2.0) letter_opener (1.8.1) launchy (>= 2.2, < 3) @@ -327,10 +327,9 @@ GEM multi_json (1.15.0) multi_xml (0.6.0) mysql2 (0.5.5) - net-imap (0.2.3) - digest + net-imap (0.3.4) + date net-protocol - strscan net-pop (0.1.2) net-protocol net-protocol (0.2.1) @@ -416,20 +415,20 @@ GEM rack rack-test (2.1.0) rack (>= 1.3) - rails (7.0.1) - actioncable (= 7.0.1) - actionmailbox (= 7.0.1) - actionmailer (= 7.0.1) - actionpack (= 7.0.1) - actiontext (= 7.0.1) - actionview (= 7.0.1) - activejob (= 7.0.1) - activemodel (= 7.0.1) - activerecord (= 7.0.1) - activestorage (= 7.0.1) - activesupport (= 7.0.1) + rails (7.0.4.3) + actioncable (= 7.0.4.3) + actionmailbox (= 7.0.4.3) + actionmailer (= 7.0.4.3) + actionpack (= 7.0.4.3) + actiontext (= 7.0.4.3) + actionview (= 7.0.4.3) + activejob (= 7.0.4.3) + activemodel (= 7.0.4.3) + activerecord (= 7.0.4.3) + activestorage (= 7.0.4.3) + activesupport (= 7.0.4.3) bundler (>= 1.15.0) - railties (= 7.0.1) + railties (= 7.0.4.3) rails-controller-testing (1.0.5) actionpack (>= 5.0.1.rc1) actionview (>= 5.0.1.rc1) @@ -442,9 +441,9 @@ GEM rails-i18n (7.0.6) i18n (>= 0.7, < 2) railties (>= 6.0.0, < 8) - railties (7.0.1) - actionpack (= 7.0.1) - activesupport (= 7.0.1) + railties (7.0.4.3) + actionpack (= 7.0.4.3) + activesupport (= 7.0.4.3) method_source rake (>= 12.2) thor (~> 1.0) @@ -575,7 +574,6 @@ GEM dante (>= 0.2.0) multi_json (~> 1.0) stripe (> 5, < 6) - strscan (3.0.1) sysexits (1.2.0) temple (0.10.0) thor (1.2.1) diff --git a/config/application.rb b/config/application.rb index 9897473ca..1953c5290 100644 --- a/config/application.rb +++ b/config/application.rb @@ -35,5 +35,7 @@ class Application < Rails::Application config.generators.system_tests = nil # This is a nightmare with our current data model, no one ever thought about this. config.active_record.belongs_to_required_by_default = false + # https://discuss.rubyonrails.org/t/cve-2022-32224-possible-rce-escalation-bug-with-serialized-columns-in-active-record/81017 + config.active_record.yaml_column_permitted_classes = ['Date', 'DateTime', 'Symbol', 'Time'] end end From 50abebf494c13c7688b1da470c33628c9c75f1ac Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 16:15:44 +0000 Subject: [PATCH 26/57] Update all of sentry-ruby-core to version 5.9.0 --- Gemfile.lock | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 9920935a2..81db170e8 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -538,11 +538,14 @@ GEM rexml (~> 3.2, >= 3.2.5) rubyzip (>= 1.2.2, < 3.0) websocket (~> 1.0) - sentry-rails (5.3.0) + sentry-rails (5.9.0) railties (>= 5.0) - sentry-ruby-core (~> 5.3.0) - sentry-ruby-core (5.3.0) + sentry-ruby (~> 5.9.0) + sentry-ruby (5.9.0) + concurrent-ruby (~> 1.0, >= 1.0.2) + sentry-ruby-core (5.9.0) concurrent-ruby + sentry-ruby (= 5.9.0) shoulda-matchers (5.3.0) activesupport (>= 5.2.0) simple_po_parser (1.1.6) From d691d161633d447758681c93da2894d362371d13 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 16:11:35 +0000 Subject: [PATCH 27/57] Update rubocop-rspec to version 2.20.0 --- .rubocop_todo.yml | 106 +++++++++++++++++++++++++++++++++++++--------- Gemfile.lock | 5 ++- 2 files changed, 89 insertions(+), 22 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 1614d0808..1f07e324b 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2023-05-08 15:38:24 UTC using RuboCop version 1.50.2. +# on 2023-05-08 16:19:23 UTC using RuboCop version 1.50.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -604,22 +604,12 @@ RSpec/AnyInstance: - 'spec/controllers/proposals_controller_spec.rb' - 'spec/controllers/tracks_controller_spec.rb' -# Offense count: 350 +# Offense count: 5 # This cop supports safe autocorrection (--autocorrect). -RSpec/Capybara/CurrentPathExpectation: +RSpec/BeEmpty: Exclude: - - 'spec/features/base_controller_spec.rb' - - 'spec/features/cfp_ability_spec.rb' - - 'spec/features/conference_registration_spec.rb' - - 'spec/features/info_desk_ability_spec.rb' - - 'spec/features/organization_admin_ability_spec.rb' - - 'spec/features/organizer_ability_spec.rb' - - 'spec/features/proposals_spec.rb' - - 'spec/features/registration_periods_spec.rb' - - 'spec/features/splashpage_spec.rb' - - 'spec/features/ticket_purchases_spec.rb' - - 'spec/features/track_organizer_ability_spec.rb' - - 'spec/features/user_ability_spec.rb' + - 'spec/controllers/conference_registration_controller_spec.rb' + - 'spec/models/conference_spec.rb' # Offense count: 161 # This cop supports safe autocorrection (--autocorrect). @@ -628,7 +618,7 @@ RSpec/Capybara/FeatureMethods: Enabled: false # Offense count: 318 -# Configuration parameters: Prefixes. +# Configuration parameters: Prefixes, AllowedPatterns. # Prefixes: when, with, without RSpec/ContextWording: Enabled: false @@ -685,8 +675,9 @@ RSpec/EmptyLineAfterFinalLet: - 'spec/models/payment_spec.rb' - 'spec/models/ticket_spec.rb' -# Offense count: 17 +# Offense count: 16 # This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowConsecutiveOneLiners. RSpec/EmptyLineAfterHook: Exclude: - 'spec/controllers/admin/booths_controller_spec.rb' @@ -720,7 +711,8 @@ RSpec/ExampleLength: # Offense count: 15 # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: CustomTransform, IgnoredWords. +# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples. +# DisallowedExamples: works RSpec/ExampleWording: Exclude: - 'spec/controllers/admin/organizations_controller_spec.rb' @@ -754,6 +746,19 @@ RSpec/ExpectChange: - 'spec/models/event_spec.rb' - 'spec/models/user_spec.rb' +# Offense count: 12 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: require_parentheses, omit_parentheses +RSpec/FactoryBot/ConsistentParenthesesStyle: + Exclude: + - 'spec/controllers/proposals_controller_spec.rb' + - 'spec/features/proposals_spec.rb' + - 'spec/features/roles_spec.rb' + - 'spec/features/surveys_spec.rb' + - 'spec/models/resource_spec.rb' + - 'spec/models/ticket_spec.rb' + # Offense count: 9 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly. # Include: **/*_spec*rb*, **/spec/**/* @@ -805,7 +810,7 @@ RSpec/ImplicitExpect: # Offense count: 39 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. -# SupportedStyles: single_line_only, single_statement_only, disallow +# SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit RSpec/ImplicitSubject: Exclude: - 'spec/ability/ability_spec.rb' @@ -819,6 +824,18 @@ RSpec/ImplicitSubject: - 'spec/models/ticket_purchase_spec.rb' - 'spec/models/ticket_spec.rb' +# Offense count: 19 +# Configuration parameters: Max. +RSpec/IndexedLet: + Exclude: + - 'spec/controllers/admin/reports_controller_spec.rb' + - 'spec/controllers/admin/roles_controller_spec.rb' + - 'spec/features/voting_spec.rb' + - 'spec/models/conference_spec.rb' + - 'spec/models/ticket_purchase_spec.rb' + - 'spec/models/ticket_spec.rb' + - 'spec/models/user_spec.rb' + # Offense count: 321 # Configuration parameters: AssignmentOnly. RSpec/InstanceVariable: @@ -851,6 +868,14 @@ RSpec/LeadingSubject: RSpec/LetSetup: Enabled: false +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +RSpec/MatchArray: + Exclude: + - 'spec/controllers/admin/conferences_controller_spec.rb' + - 'spec/controllers/admin/users_controller_spec.rb' + - 'spec/models/conference_spec.rb' + # Offense count: 12 # Configuration parameters: . # SupportedStyles: have_received, receive @@ -872,7 +897,8 @@ RSpec/MultipleMemoizedHelpers: Max: 32 # Offense count: 396 -# Configuration parameters: IgnoreSharedExamples. +# Configuration parameters: EnforcedStyle, IgnoreSharedExamples. +# SupportedStyles: always, named_only RSpec/NamedSubject: Exclude: - 'spec/models/conference_spec.rb' @@ -881,9 +907,19 @@ RSpec/NamedSubject: - 'spec/models/track_spec.rb' # Offense count: 208 +# Configuration parameters: AllowedGroups. RSpec/NestedGroups: Max: 7 +# Offense count: 3 +# Configuration parameters: AllowedPatterns. +# AllowedPatterns: ^expect_, ^assert_ +RSpec/NoExpectationExample: + Exclude: + - 'spec/controllers/admin/conferences_controller_spec.rb' + - 'spec/controllers/admin/registration_periods_controller_spec.rb' + - 'spec/features/voting_spec.rb' + # Offense count: 83 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. @@ -903,6 +939,29 @@ RSpec/Rails/AvoidSetupHook: - 'spec/features/versions_spec.rb' - 'spec/helpers/events_helper_spec.rb' +# Offense count: 2 +# This cop supports unsafe autocorrection (--autocorrect-all). +RSpec/Rails/HaveHttpStatus: + Exclude: + - 'spec/controllers/admin/event_schedules_controller_spec.rb' + +# Offense count: 11 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Inferences. +RSpec/Rails/InferredSpecType: + Exclude: + - 'spec/controllers/admin/comments_controller_spec.rb' + - 'spec/controllers/admin/programs_controller_spec.rb' + - 'spec/controllers/application_controller_spec.rb' + - 'spec/controllers/conference_registration_controller_spec.rb' + - 'spec/helpers/application_helper_spec.rb' + - 'spec/helpers/conference_helper_spec.rb' + - 'spec/helpers/date_time_helper_spec.rb' + - 'spec/helpers/events_helper_spec.rb' + - 'spec/helpers/format_helper_spec.rb' + - 'spec/helpers/users_helper_spec.rb' + - 'spec/routing/routing_spec.rb' + # Offense count: 4 RSpec/RepeatedDescription: Exclude: @@ -934,10 +993,17 @@ RSpec/ScatteredLet: - 'spec/models/payment_spec.rb' # Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). RSpec/ScatteredSetup: Exclude: - 'spec/models/payment_spec.rb' +# Offense count: 32 +# This cop supports safe autocorrection (--autocorrect). +RSpec/SortMetadata: + Exclude: + - 'spec/features/versions_spec.rb' + # Offense count: 9 RSpec/StubbedMock: Exclude: diff --git a/Gemfile.lock b/Gemfile.lock index 9920935a2..ee00feb41 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -513,8 +513,9 @@ GEM activesupport (>= 4.2.0) rack (>= 1.1) rubocop (>= 1.33.0, < 2.0) - rubocop-rspec (2.11.1) - rubocop (~> 1.19) + rubocop-rspec (2.20.0) + rubocop (~> 1.33) + rubocop-capybara (~> 2.17) ruby-oembed (0.16.1) ruby-openid (2.9.2) ruby-progressbar (1.13.0) From c263bc40cebe8c9fd20304232b6dc73629d24d47 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 16:20:27 +0000 Subject: [PATCH 28/57] Update next_rails to version 1.2.4 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 22ab9eaf7..5f4253220 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -337,7 +337,7 @@ GEM net-smtp (0.3.3) net-protocol netrc (0.11.0) - next_rails (1.0.5) + next_rails (1.2.4) colorize (>= 0.8.1) nio4r (2.5.9) nokogiri (1.14.3) From 9775fc4a359abab1a3ed3b1e3dad716858221dc6 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 16:25:22 +0000 Subject: [PATCH 29/57] Update caxlsx to version 3.4.1 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 22ab9eaf7..32e2d81ee 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -150,7 +150,7 @@ GEM fastimage case_transform (0.2) activesupport - caxlsx (3.2.0) + caxlsx (3.4.1) htmlentities (~> 4.3, >= 4.3.4) marcel (~> 1.0) nokogiri (~> 1.10, >= 1.10.4) From 6c538775e0c81307ae933d899478059eb839f850 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 16:35:19 +0000 Subject: [PATCH 30/57] Update pg to version 1.5.3 --- Gemfile.lock | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index b7326c601..637040e27 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -390,7 +390,7 @@ GEM hashery (~> 2.0) ruby-rc4 ttfunk - pg (1.4.6) + pg (1.5.3) prawn (2.4.0) pdf-core (~> 0.9.0) ttfunk (~> 1.7) @@ -543,9 +543,6 @@ GEM sentry-ruby (~> 5.9.0) sentry-ruby (5.9.0) concurrent-ruby (~> 1.0, >= 1.0.2) - sentry-ruby-core (5.9.0) - concurrent-ruby - sentry-ruby (= 5.9.0) shoulda-matchers (5.3.0) activesupport (>= 5.2.0) simple_po_parser (1.1.6) From 519f38f753563924862defae9f9a8196b3b0ac6f Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 16:50:34 +0000 Subject: [PATCH 31/57] Update haml to version 6.1.1 --- Gemfile.lock | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 02cf54343..201b0f2e9 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -227,16 +227,17 @@ GEM globalid (1.1.0) activesupport (>= 5.0) gravtastic (3.2.6) - haml (5.2.2) - temple (>= 0.8.0) + haml (6.1.1) + temple (>= 0.8.2) + thor tilt haml-rails (2.1.0) actionpack (>= 5.1) activesupport (>= 5.1) haml (>= 4.0.6) railties (>= 5.1) - haml_lint (0.40.0) - haml (>= 4.0, < 5.3) + haml_lint (0.45.0) + haml (>= 4.0, < 6.2) parallel (~> 1.10) rainbow rubocop (>= 0.50.0) From f86149ec61afa2a65fc086e07eb1f644309d3ec2 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 8 May 2023 16:55:26 +0000 Subject: [PATCH 32/57] Update simplecov to version 0.22.0 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 02cf54343..f0e84a49a 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -546,7 +546,7 @@ GEM shoulda-matchers (5.3.0) activesupport (>= 5.2.0) simple_po_parser (1.1.6) - simplecov (0.21.2) + simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) simplecov_json_formatter (~> 0.1) From 3207c2050a15ead7c8b250cb4dcc635d728e5247 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 10 May 2023 06:45:19 +0000 Subject: [PATCH 33/57] Update chartkick to version 5.0.2 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 02cf54343..26e97c00e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -158,7 +158,7 @@ GEM caxlsx_rails (0.6.3) actionpack (>= 3.1) caxlsx (>= 3.0) - chartkick (4.2.0) + chartkick (5.0.2) chronic (0.10.2) chunky_png (1.4.0) climate_control (1.2.0) From a14b7c4953ca2069b0f630948d307b19409a8eb3 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Fri, 12 May 2023 14:00:28 +0000 Subject: [PATCH 34/57] Update rspec-rails to version 6.0.2 --- Gemfile.lock | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 6bc56b651..d6d960456 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -293,9 +293,9 @@ GEM activesupport (>= 4) railties (>= 4) request_store (~> 1.0) - loofah (2.20.0) + loofah (2.21.2) crass (~> 1.0.2) - nokogiri (>= 1.5.9) + nokogiri (>= 1.12.0) mail (2.8.1) mini_mime (>= 0.1.1) net-imap @@ -341,7 +341,7 @@ GEM next_rails (1.2.4) colorize (>= 0.8.1) nio4r (2.5.9) - nokogiri (1.14.3) + nokogiri (1.14.4) mini_portile2 (~> 2.8.0) racc (~> 1.4) oauth2 (2.0.9) @@ -483,14 +483,14 @@ GEM rspec-mocks (3.12.5) diff-lcs (>= 1.2.0, < 2.0) rspec-support (~> 3.12.0) - rspec-rails (6.0.1) + rspec-rails (6.0.2) actionpack (>= 6.1) activesupport (>= 6.1) railties (>= 6.1) - rspec-core (~> 3.11) - rspec-expectations (~> 3.11) - rspec-mocks (~> 3.11) - rspec-support (~> 3.11) + rspec-core (~> 3.12) + rspec-expectations (~> 3.12) + rspec-mocks (~> 3.12) + rspec-support (~> 3.12) rspec-support (3.12.0) rubocop (1.50.2) json (~> 2.3) @@ -578,7 +578,7 @@ GEM stripe (> 5, < 6) sysexits (1.2.0) temple (0.10.0) - thor (1.2.1) + thor (1.2.2) tilt (2.1.0) timecop (0.9.6) timeout (0.3.2) From c792ab1d84927e2b3d2e7ae680f9dadbf493474f Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Fri, 12 May 2023 14:05:40 +0000 Subject: [PATCH 35/57] Update recaptcha to version 5.14.0 --- Gemfile.lock | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 6bc56b651..ca7c7e43c 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -451,8 +451,7 @@ GEM zeitwerk (~> 2.5) rainbow (3.1.1) rake (13.0.6) - recaptcha (5.13.0) - json + recaptcha (5.14.0) redcarpet (3.6.0) regexp_parser (2.8.0) request_store (1.5.1) From 2619448b09fa90b840c3bc2a3d66b6f268a8c220 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Fri, 12 May 2023 14:11:20 +0000 Subject: [PATCH 36/57] Update web-console to version 4.2.0 --- Gemfile.lock | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 6bc56b651..95e42c6b9 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -293,9 +293,9 @@ GEM activesupport (>= 4) railties (>= 4) request_store (~> 1.0) - loofah (2.20.0) + loofah (2.21.2) crass (~> 1.0.2) - nokogiri (>= 1.5.9) + nokogiri (>= 1.12.0) mail (2.8.1) mini_mime (>= 0.1.1) net-imap @@ -341,7 +341,7 @@ GEM next_rails (1.2.4) colorize (>= 0.8.1) nio4r (2.5.9) - nokogiri (1.14.3) + nokogiri (1.14.4) mini_portile2 (~> 2.8.0) racc (~> 1.4) oauth2 (2.0.9) @@ -578,7 +578,7 @@ GEM stripe (> 5, < 6) sysexits (1.2.0) temple (0.10.0) - thor (1.2.1) + thor (1.2.2) tilt (2.1.0) timecop (0.9.6) timeout (0.3.2) @@ -600,7 +600,7 @@ GEM version_gem (1.1.2) warden (1.2.9) rack (>= 2.0.9) - web-console (4.1.0) + web-console (4.2.0) actionview (>= 6.0.0) activemodel (>= 6.0.0) bindex (>= 0.4.0) From a28030770214b42c6bfd390a7b4cf2a3d62f21c2 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Fri, 12 May 2023 14:25:42 +0000 Subject: [PATCH 37/57] Update faker to version 3.2.0 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 6bc56b651..3bece6c37 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -211,7 +211,7 @@ GEM factory_bot_rails (6.2.0) factory_bot (~> 6.2.0) railties (>= 5.0.0) - faker (2.21.0) + faker (3.2.0) i18n (>= 1.8.11, < 2) faraday (2.7.4) faraday-net_http (>= 2.0, < 3.1) From 5aab8be9b11968a0f0005a89d1ca8499f3e42e53 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 17 May 2023 12:25:22 +0000 Subject: [PATCH 38/57] Update puma to version 6.2.2 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 27510a652..69079859d 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -405,7 +405,7 @@ GEM prawn-table (0.2.2) prawn (>= 1.3.0, < 3.0.0) public_suffix (5.0.1) - puma (5.6.4) + puma (6.2.2) nio4r (~> 2.0) racc (1.6.2) rack (2.2.7) From a00f0a4b8cf6209717e60b31d3cb71bbf8667551 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 17 May 2023 12:30:33 +0000 Subject: [PATCH 39/57] Update json-schema to version 4.0.0 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 27510a652..f20fac2a8 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -273,7 +273,7 @@ GEM jquery-ui-rails (6.0.1) railties (>= 3.2.16) json (2.6.3) - json-schema (3.0.0) + json-schema (4.0.0) addressable (>= 2.8) jsonapi-renderer (0.2.2) jwt (2.7.0) From fdc979b5d825a559f81573bf8940a4f526e87a4c Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 17 May 2023 14:39:50 +0000 Subject: [PATCH 40/57] Update acts_as_commentable_with_threading to version 2.0.1 --- Gemfile.lock | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 09cbf8429..498cadaee 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -96,10 +96,10 @@ GEM i18n (>= 1.6, < 2) minitest (>= 5.1) tzinfo (~> 2.0) - acts_as_commentable_with_threading (1.2.0) - activerecord (>= 3.0) - activesupport (>= 3.0) - awesome_nested_set (>= 2.0) + acts_as_commentable_with_threading (2.0.1) + activerecord (>= 4.0) + activesupport (>= 4.0) + awesome_nested_set (>= 3.0) acts_as_list (1.1.0) activerecord (>= 4.2) addressable (2.8.4) From e02c6aae174d42e5c3e5a2600aef24a96938500c Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 17 May 2023 14:40:01 +0000 Subject: [PATCH 41/57] Update daemons to version 1.4.1 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 09cbf8429..46da2085a 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -173,7 +173,7 @@ GEM crack (0.4.5) rexml crass (1.0.6) - daemons (1.4.0) + daemons (1.4.1) dalli (3.2.4) dante (0.2.0) database_cleaner (2.0.2) From 6d7110453be390d6aa803849ff5e98848ba9c7c2 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 17 May 2023 14:41:05 +0000 Subject: [PATCH 42/57] Update temple to version 0.10.1 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 09cbf8429..e11544c6d 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -576,7 +576,7 @@ GEM multi_json (~> 1.0) stripe (> 5, < 6) sysexits (1.2.0) - temple (0.10.0) + temple (0.10.1) thor (1.2.2) tilt (2.1.0) timecop (0.9.6) From 916a32ba60c74c3761b4148e86e7e24647585016 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 17 May 2023 14:41:14 +0000 Subject: [PATCH 43/57] Update nokogiri to version 1.15.0 --- Gemfile.lock | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 09cbf8429..1676e717e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -341,8 +341,8 @@ GEM next_rails (1.2.4) colorize (>= 0.8.1) nio4r (2.5.9) - nokogiri (1.14.4) - mini_portile2 (~> 2.8.0) + nokogiri (1.15.0) + mini_portile2 (~> 2.8.2) racc (~> 1.4) oauth2 (2.0.9) faraday (>= 0.17.3, < 3.0) From 43c4948b73d8bc411d1941cfa7ff88f40f5edf12 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 17 May 2023 14:41:30 +0000 Subject: [PATCH 44/57] Update loofah to version 2.21.3 --- Gemfile.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 09cbf8429..225359292 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -293,7 +293,7 @@ GEM activesupport (>= 4) railties (>= 4) request_store (~> 1.0) - loofah (2.21.2) + loofah (2.21.3) crass (~> 1.0.2) nokogiri (>= 1.12.0) mail (2.8.1) @@ -341,8 +341,8 @@ GEM next_rails (1.2.4) colorize (>= 0.8.1) nio4r (2.5.9) - nokogiri (1.14.4) - mini_portile2 (~> 2.8.0) + nokogiri (1.15.0) + mini_portile2 (~> 2.8.2) racc (~> 1.4) oauth2 (2.0.9) faraday (>= 0.17.3, < 3.0) From 78089f1f4938c05b8b83468922f1ad44d289e93f Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 17 May 2023 14:41:36 +0000 Subject: [PATCH 45/57] Update rails-i18n to version 7.0.7 --- Gemfile.lock | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 09cbf8429..69e1067cd 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -293,7 +293,7 @@ GEM activesupport (>= 4) railties (>= 4) request_store (~> 1.0) - loofah (2.21.2) + loofah (2.21.3) crass (~> 1.0.2) nokogiri (>= 1.12.0) mail (2.8.1) @@ -341,8 +341,8 @@ GEM next_rails (1.2.4) colorize (>= 0.8.1) nio4r (2.5.9) - nokogiri (1.14.4) - mini_portile2 (~> 2.8.0) + nokogiri (1.15.0) + mini_portile2 (~> 2.8.2) racc (~> 1.4) oauth2 (2.0.9) faraday (>= 0.17.3, < 3.0) @@ -439,7 +439,7 @@ GEM nokogiri (>= 1.6) rails-html-sanitizer (1.5.0) loofah (~> 2.19, >= 2.19.1) - rails-i18n (7.0.6) + rails-i18n (7.0.7) i18n (>= 0.7, < 2) railties (>= 6.0.0, < 8) railties (7.0.4.3) From 738bc5ff382204970a9a26bfd35bcba004abaca5 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 17 May 2023 14:41:44 +0000 Subject: [PATCH 46/57] Update capybara to version 3.39.1 --- Gemfile.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 09cbf8429..4c2b35b39 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -127,7 +127,7 @@ GEM builder (3.2.4) byebug (11.1.3) cancancan (3.5.0) - capybara (3.39.0) + capybara (3.39.1) addressable matrix mini_mime (>= 0.1.3) @@ -341,8 +341,8 @@ GEM next_rails (1.2.4) colorize (>= 0.8.1) nio4r (2.5.9) - nokogiri (1.14.4) - mini_portile2 (~> 2.8.0) + nokogiri (1.15.0) + mini_portile2 (~> 2.8.2) racc (~> 1.4) oauth2 (2.0.9) faraday (>= 0.17.3, < 3.0) From 912f0f268067fa20823d67f493811043e4dd8bb5 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 17 May 2023 14:42:20 +0000 Subject: [PATCH 47/57] Update rubocop to version 1.51.0 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 09cbf8429..dee7ad335 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -491,7 +491,7 @@ GEM rspec-mocks (~> 3.12) rspec-support (~> 3.12) rspec-support (3.12.0) - rubocop (1.50.2) + rubocop (1.51.0) json (~> 2.3) parallel (~> 1.10) parser (>= 3.2.0.0) From 234762fe8e4c0d2999806f607afdbb969f816596 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 24 May 2023 10:00:22 +0000 Subject: [PATCH 48/57] Update sqlite3 to version 1.6.3 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 92bbb3c47..3b4d26997 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -567,7 +567,7 @@ GEM actionpack (>= 5.2) activesupport (>= 5.2) sprockets (>= 3.0.0) - sqlite3 (1.6.2) + sqlite3 (1.6.3) mini_portile2 (~> 2.8.0) ssrf_filter (1.1.1) stripe (5.53.0) From b2cd0043bded0f7dc313d833c71614b8217a74a4 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Wed, 24 May 2023 10:05:40 +0000 Subject: [PATCH 49/57] Update rqrcode to version 2.2.0 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 92bbb3c47..08c531e8c 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -466,7 +466,7 @@ GEM netrc (~> 0.8) rexml (3.2.5) rolify (6.0.1) - rqrcode (2.1.2) + rqrcode (2.2.0) chunky_png (~> 1.0) rqrcode_core (~> 1.0) rqrcode_core (1.2.0) From 31ffa102a7cf157f8ecfa8101867c14afd6d333f Mon Sep 17 00:00:00 2001 From: Andrew Kvalheim Date: Fri, 9 Jun 2023 11:06:17 -0700 Subject: [PATCH 50/57] Allow runtime configuration of Sentry tracing sample rate --- config/initializers/sentry.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/initializers/sentry.rb b/config/initializers/sentry.rb index 3a8276ac6..e87be344b 100644 --- a/config/initializers/sentry.rb +++ b/config/initializers/sentry.rb @@ -4,7 +4,7 @@ # To activate performance monitoring, set one of these options. # We recommend adjusting the value in production: - config.traces_sample_rate = 0.5 + config.traces_sample_rate = ENV.fetch('OSEM_SENTRY_TRACES_SAMPLE_RATE', '0.5').to_f # or # config.traces_sampler = lambda do |context| # true From ed774a853f0094b62375dc49b5cb5dc009fa3e4f Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Thu, 29 Jun 2023 11:45:25 +0000 Subject: [PATCH 51/57] Update selenium-webdriver to version 4.10.0 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 47d59c6ea..cb783c32e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -534,7 +534,7 @@ GEM sprockets-rails tilt selectize-rails (0.12.6) - selenium-webdriver (4.9.0) + selenium-webdriver (4.10.0) rexml (~> 3.2, >= 3.2.5) rubyzip (>= 1.2.2, < 3.0) websocket (~> 1.0) From 1c3e76e83a094c5597e710208b4258d3c2f2dbbf Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Thu, 29 Jun 2023 11:50:20 +0000 Subject: [PATCH 52/57] Update capybara to version 3.39.2 --- Gemfile.lock | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 47d59c6ea..382c70f4b 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -127,7 +127,7 @@ GEM builder (3.2.4) byebug (11.1.3) cancancan (3.5.0) - capybara (3.39.1) + capybara (3.39.2) addressable matrix mini_mime (>= 0.1.3) @@ -341,7 +341,7 @@ GEM next_rails (1.2.4) colorize (>= 0.8.1) nio4r (2.5.9) - nokogiri (1.15.0) + nokogiri (1.15.2) mini_portile2 (~> 2.8.2) racc (~> 1.4) oauth2 (2.0.9) @@ -407,7 +407,7 @@ GEM public_suffix (5.0.1) puma (6.2.2) nio4r (~> 2.0) - racc (1.6.2) + racc (1.7.1) rack (2.2.7) rack-openid (1.4.2) rack (>= 1.1.0) @@ -453,7 +453,7 @@ GEM rake (13.0.6) recaptcha (5.14.0) redcarpet (3.6.0) - regexp_parser (2.8.0) + regexp_parser (2.8.1) request_store (1.5.1) rack (>= 1.4) responders (3.1.0) From 8026a803064e684e24494c70a3debcc0435c3550 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Thu, 29 Jun 2023 11:55:22 +0000 Subject: [PATCH 53/57] Update carrierwave to version 2.2.4 --- Gemfile.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 47d59c6ea..ac5bc57b7 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -136,7 +136,7 @@ GEM rack-test (>= 0.6.3) regexp_parser (>= 1.5, < 3.0) xpath (~> 3.2) - carrierwave (2.2.3) + carrierwave (2.2.4) activemodel (>= 5.0.0) activesupport (>= 5.0.0) addressable (~> 2.6) @@ -249,7 +249,7 @@ GEM http-accept (1.7.0) http-cookie (1.0.5) domain_name (~> 0.5) - i18n (1.13.0) + i18n (1.14.1) concurrent-ruby (~> 1.0) i18n_data (0.17.1) simple_po_parser (~> 1.1) @@ -313,7 +313,7 @@ GEM mini_magick (4.12.0) mini_mime (1.1.2) mini_portile2 (2.8.2) - minitest (5.18.0) + minitest (5.18.1) momentjs-rails (2.29.4.1) railties (>= 3.1) monetize (1.12.0) From 920a2c2a89472aa10e43f9d72bbfcac376ae4aac Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Fri, 11 Aug 2023 13:23:32 +0000 Subject: [PATCH 54/57] Update webdrivers to version 5.3.1 --- Gemfile.lock | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 49a3b2c9e..b0901fc0b 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -312,7 +312,7 @@ GEM rake mini_magick (4.12.0) mini_mime (1.1.2) - mini_portile2 (2.8.2) + mini_portile2 (2.8.4) minitest (5.18.1) momentjs-rails (2.29.4.1) railties (>= 3.1) @@ -341,7 +341,7 @@ GEM next_rails (1.2.4) colorize (>= 0.8.1) nio4r (2.5.9) - nokogiri (1.15.2) + nokogiri (1.15.3) mini_portile2 (~> 2.8.2) racc (~> 1.4) oauth2 (2.0.9) @@ -464,7 +464,7 @@ GEM http-cookie (>= 1.0.2, < 2.0) mime-types (>= 1.16, < 4.0) netrc (~> 0.8) - rexml (3.2.5) + rexml (3.2.6) rolify (6.0.1) rqrcode (2.2.0) chunky_png (~> 1.0) @@ -604,10 +604,10 @@ GEM activemodel (>= 6.0.0) bindex (>= 0.4.0) railties (>= 6.0.0) - webdrivers (5.2.0) + webdrivers (5.3.1) nokogiri (~> 1.6) rubyzip (>= 1.3.0) - selenium-webdriver (~> 4.0) + selenium-webdriver (~> 4.0, < 4.11) webmock (3.18.1) addressable (>= 2.8.0) crack (>= 0.3.2) From 78ccabbd40f0076f0323550e4a88e3adfec52686 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Fri, 11 Aug 2023 13:50:33 +0000 Subject: [PATCH 55/57] Update jwt to version 2.7.1 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index b0901fc0b..242d329d2 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -276,7 +276,7 @@ GEM json-schema (4.0.0) addressable (>= 2.8) jsonapi-renderer (0.2.2) - jwt (2.7.0) + jwt (2.7.1) launchy (2.5.2) addressable (~> 2.8) leaflet-rails (1.9.3) From 5e18261960707513d25a12db4718961eb3378a25 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Fri, 11 Aug 2023 13:40:56 +0000 Subject: [PATCH 56/57] Update dalli to version 3.2.5 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index b0901fc0b..71305f87c 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -174,7 +174,7 @@ GEM rexml crass (1.0.6) daemons (1.4.1) - dalli (3.2.4) + dalli (3.2.5) dante (0.2.0) database_cleaner (2.0.2) database_cleaner-active_record (>= 2, < 3) From 0a58249cdd39af6f47a190eaf1bca06696739f80 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Fri, 11 Aug 2023 13:46:10 +0000 Subject: [PATCH 57/57] Update fastimage to version 2.2.7 --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index b0901fc0b..74ad21138 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -217,7 +217,7 @@ GEM faraday-net_http (>= 2.0, < 3.1) ruby2_keywords (>= 0.0.4) faraday-net_http (3.0.2) - fastimage (2.2.6) + fastimage (2.2.7) feature (1.4.0) ffi (1.15.5) font-awesome-sass (6.4.0)