diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index d91611ee1..809087730 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2023-05-08 16:19:23 UTC using RuboCop version 1.50.2. +# on 2024-02-13 03:28:14 UTC using RuboCop version 1.56.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -14,23 +14,6 @@ Bundler/OrderedGems: Exclude: - 'Gemfile' -# Offense count: 350 -# This cop supports safe autocorrection (--autocorrect). -Capybara/CurrentPathExpectation: - Exclude: - - 'spec/features/base_controller_spec.rb' - - 'spec/features/cfp_ability_spec.rb' - - 'spec/features/conference_registration_spec.rb' - - 'spec/features/info_desk_ability_spec.rb' - - 'spec/features/organization_admin_ability_spec.rb' - - 'spec/features/organizer_ability_spec.rb' - - 'spec/features/proposals_spec.rb' - - 'spec/features/registration_periods_spec.rb' - - 'spec/features/splashpage_spec.rb' - - 'spec/features/ticket_purchases_spec.rb' - - 'spec/features/track_organizer_ability_spec.rb' - - 'spec/features/user_ability_spec.rb' - # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. @@ -39,360 +22,42 @@ Capybara/NegationMatcher: Exclude: - 'spec/features/versions_spec.rb' -# Offense count: 82 +# Offense count: 98 # This cop supports safe autocorrection (--autocorrect). Capybara/SpecificFinders: Enabled: false -# Offense count: 1 -Capybara/SpecificMatcher: - Exclude: - - 'spec/features/sponsor_spec.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: IndentationWidth. -Layout/AssignmentIndentation: - Exclude: - - 'app/helpers/format_helper.rb' - -# Offense count: 4 -# This cop supports safe autocorrection (--autocorrect). -Layout/ClosingParenthesisIndentation: - Exclude: - - 'app/controllers/conference_registrations_controller.rb' - - 'app/controllers/proposals_controller.rb' - - 'app/models/commercial.rb' - - 'spec/controllers/users/omniauth_callbacks_controller_spec.rb' - -# Offense count: 5 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowForAlignment. -Layout/CommentIndentation: - Exclude: - - 'app/controllers/admin/comments_controller.rb' - - 'app/controllers/admin/difficulty_levels_controller.rb' - - 'app/models/conference.rb' - - 'app/models/program.rb' - - 'app/models/track.rb' - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -Layout/EmptyLineAfterGuardClause: - Exclude: - - 'app/controllers/subscriptions_controller.rb' - - 'app/models/program.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Layout/EmptyLineAfterMagicComment: - Exclude: - - 'spec/models/conference_spec.rb' - -# Offense count: 100 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: empty_lines, no_empty_lines -Layout/EmptyLinesAroundBlockBody: - Enabled: false - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Layout/EmptyLinesAroundExceptionHandlingKeywords: - Exclude: - - 'app/models/payment.rb' - -# Offense count: 6 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. -Layout/ExtraSpacing: - Exclude: - - 'app/controllers/application_controller.rb' - - 'app/views/admin/events/_all_with_comments.xlsx.axlsx' - - 'db/migrate/20140623101032_create_ahoy_events.rb' - - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' - - 'db/migrate/20140719160903_create_delayed_jobs.rb' - - 'spec/models/conference_spec.rb' - -# Offense count: 43 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses -Layout/FirstArgumentIndentation: - Enabled: false - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: special_inside_parentheses, consistent, align_brackets -Layout/FirstArrayElementIndentation: - Exclude: - - 'app/models/conference.rb' - -# Offense count: 4 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: special_inside_parentheses, consistent, align_braces -Layout/FirstHashElementIndentation: - Exclude: - - 'app/models/user.rb' - - 'config/routes.rb' - - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: normal, indented_internal_methods -Layout/IndentationConsistency: - Exclude: - - 'app/controllers/users_controller.rb' - - 'app/models/event.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: IndentationWidth, EnforcedStyle. -# SupportedStyles: spaces, tabs -Layout/IndentationStyle: - Exclude: - - 'app/controllers/admin/resources_controller.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: Width, AllowedPatterns. -Layout/IndentationWidth: - Exclude: - - 'app/controllers/users_controller.rb' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment. -Layout/LeadingCommentSpace: - Exclude: - - 'app/models/comment.rb' - -# Offense count: 18 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: space, no_space -Layout/LineContinuationSpacing: - Exclude: - - 'app/controllers/admin/booths_controller.rb' - - 'app/controllers/admin/cfps_controller.rb' - - 'app/controllers/admin/commercials_controller.rb' - - 'app/controllers/admin/difficulty_levels_controller.rb' - - 'app/controllers/admin/event_types_controller.rb' - - 'app/controllers/admin/registrations_controller.rb' - - 'app/controllers/admin/splashpages_controller.rb' - - 'app/controllers/admin/venue_commercials_controller.rb' - - 'app/controllers/admin/venues_controller.rb' - - 'app/controllers/conference_registrations_controller.rb' - - 'app/models/cfp.rb' - -# Offense count: 32 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: aligned, indented -Layout/LineEndStringConcatenationIndentation: - Enabled: false - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: symmetrical, new_line, same_line -Layout/MultilineArrayBraceLayout: - Exclude: - - 'app/controllers/conference_registrations_controller.rb' - -# Offense count: 5 -# This cop supports safe autocorrection (--autocorrect). -Layout/MultilineBlockLayout: - Exclude: - - 'app/serializers/conference_serializer.rb' - -# Offense count: 7 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: symmetrical, new_line, same_line -Layout/MultilineHashBraceLayout: - Exclude: - - 'app/serializers/conference_serializer.rb' - - 'config/routes.rb' - - 'spec/models/event_spec.rb' - -# Offense count: 33 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: symmetrical, new_line, same_line -Layout/MultilineMethodCallBraceLayout: - Enabled: false - -# Offense count: 47 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: aligned, indented, indented_relative_to_receiver -Layout/MultilineMethodCallIndentation: - Enabled: false - -# Offense count: 18 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: aligned, indented -Layout/MultilineOperationIndentation: - Exclude: - - 'app/controllers/application_controller.rb' - - 'app/models/conference.rb' - - 'app/models/event.rb' - - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' - -# Offense count: 64 -# This cop supports safe autocorrection (--autocorrect). -Layout/SpaceAfterComma: - Exclude: - - 'app/views/admin/booths/_all_booths.xlsx.axlsx' - - 'app/views/admin/booths/_confirmed_booths.xlsx.axlsx' - - 'app/views/admin/events/_all_events.xlsx.axlsx' - - 'app/views/admin/events/_all_with_comments.xlsx.axlsx' - - 'app/views/admin/events/_confirmed_events.xlsx.axlsx' - - 'app/views/admin/tracks/_all_tracks.xlsx.axlsx' - - 'app/views/admin/tracks/_confirmed_tracks.xlsx.axlsx' - - 'lib/tasks/data_demo.rake' - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: space, no_space -Layout/SpaceAroundEqualsInParameterDefault: - Exclude: - - 'app/helpers/format_helper.rb' - - 'app/models/event.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Layout/SpaceAroundKeyword: - Exclude: - - 'config/initializers/feature.rb' - -# Offense count: 4 -# This cop supports safe autocorrection (--autocorrect). -Layout/SpaceAroundMethodCallOperator: - Exclude: - - 'spec/features/cfp_ability_spec.rb' - - 'spec/features/organization_admin_ability_spec.rb' - - 'spec/features/organizer_ability_spec.rb' - - 'spec/models/program_spec.rb' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator. -# SupportedStylesForExponentOperator: space, no_space -Layout/SpaceAroundOperators: - Exclude: - - 'app/views/admin/events/_all_with_comments.xlsx.axlsx' - - 'lib/tasks/data.rake' - -# Offense count: 139 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. -# SupportedStyles: space, no_space -# SupportedStylesForEmptyBraces: space, no_space -Layout/SpaceBeforeBlockBraces: - Enabled: false - -# Offense count: 7 -# This cop supports safe autocorrection (--autocorrect). -Layout/SpaceBeforeComma: - Exclude: - - 'app/views/admin/booths/_all_booths.xlsx.axlsx' - - 'app/views/admin/booths/_confirmed_booths.xlsx.axlsx' - - 'app/views/admin/events/_all_events.xlsx.axlsx' - - 'app/views/admin/events/_confirmed_events.xlsx.axlsx' - - 'app/views/admin/tracks/_all_tracks.xlsx.axlsx' - - 'app/views/admin/tracks/_confirmed_tracks.xlsx.axlsx' - - 'lib/tasks/data_demo.rake' - -# Offense count: 5 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowForAlignment. -Layout/SpaceBeforeFirstArg: - Exclude: - - 'app/controllers/admin/booths_controller.rb' - # Offense count: 8 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets. -# SupportedStyles: space, no_space, compact -# SupportedStylesForEmptyBrackets: space, no_space -Layout/SpaceInsideArrayLiteralBrackets: - Exclude: - - 'config/initializers/devise.rb' - - 'config/routes.rb' - -# Offense count: 44 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. -# SupportedStyles: space, no_space -# SupportedStylesForEmptyBraces: space, no_space -Layout/SpaceInsideBlockBraces: +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Include, EnforcedStyle, NonImplicitAssociationMethodNames. +# Include: spec/factories.rb, spec/factories/**/*.rb, features/support/factories/**/*.rb +# SupportedStyles: explicit, implicit +FactoryBot/AssociationStyle: Exclude: - - 'app/controllers/admin/comments_controller.rb' - - 'app/controllers/admin/questions_controller.rb' - - 'app/helpers/application_helper.rb' - - 'app/models/program.rb' - - 'app/models/ticket.rb' - - 'app/models/user.rb' - - 'lib/tasks/events_registrations.rake' - - 'spec/ability/ability_spec.rb' - - 'spec/controllers/admin/event_schedules_controller_spec.rb' - - 'spec/controllers/admin/schedules_controller_spec.rb' - - 'spec/features/splashpage_spec.rb' - - 'spec/models/user_spec.rb' + - 'spec/factories/comments.rb' + - 'spec/factories/commercials.rb' + - 'spec/factories/conferences.rb' + - 'spec/factories/surveys.rb' + - 'spec/factories/tracks.rb' -# Offense count: 37 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. -# SupportedStyles: space, no_space, compact -# SupportedStylesForEmptyBraces: space, no_space -Layout/SpaceInsideHashLiteralBraces: +# Offense count: 28 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Include, EnforcedStyle, ExplicitOnly. +# Include: **/*_spec.rb, **/spec/**/*, spec/factories.rb, spec/factories/**/*.rb, features/support/factories/**/*.rb +# SupportedStyles: create_list, n_times +FactoryBot/CreateList: Exclude: - - 'app/controllers/api/v1/speakers_controller.rb' - - 'app/models/conference.rb' - - 'app/models/event_type.rb' - - 'app/models/user.rb' - - 'app/views/admin/booths/_all_booths.xlsx.axlsx' - - 'app/views/admin/booths/_confirmed_booths.xlsx.axlsx' - - 'app/views/admin/events/_all_events.xlsx.axlsx' - - 'app/views/admin/events/_confirmed_events.xlsx.axlsx' - - 'app/views/admin/events/events.xlsx.axlsx' - - 'app/views/admin/tracks/_all_tracks.xlsx.axlsx' - - 'app/views/admin/tracks/_confirmed_tracks.xlsx.axlsx' - - 'config/routes.rb' - - 'spec/models/event_spec.rb' - - 'spec/models/payment_spec.rb' + - 'spec/factories/question.rb' + - 'spec/models/conference_spec.rb' # Offense count: 4 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: space, compact, no_space -Layout/SpaceInsideParens: - Exclude: - - 'app/views/admin/registrations/index.xlsx.axlsx' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -Layout/SpaceInsidePercentLiteralDelimiters: - Exclude: - - 'Gemfile' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: final_newline, final_blank_line -Layout/TrailingEmptyLines: +FactoryBot/FactoryAssociationWithStrategy: Exclude: - - 'lib/tasks/event_attatchments.rake' - - 'lib/tasks/roles.rake' + - 'spec/factories/booths.rb' + - 'spec/factories/users.rb' # Offense count: 13 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowedMethods, AllowedPatterns. Lint/AmbiguousBlockAssociation: Exclude: @@ -404,25 +69,6 @@ Lint/AmbiguousBlockAssociation: - 'spec/controllers/schedules_controller_spec.rb' - 'spec/models/user_spec.rb' -# Offense count: 13 -# This cop supports safe autocorrection (--autocorrect). -Lint/AmbiguousOperatorPrecedence: - Exclude: - - 'app/controllers/application_controller.rb' - - 'app/helpers/conference_helper.rb' - - 'app/models/admin_ability.rb' - - 'app/models/commercial.rb' - - 'app/models/conference.rb' - - 'app/models/track.rb' - - 'app/pdfs/ticket_pdf.rb' - -# Offense count: 1 -# Configuration parameters: AllowedMethods. -# AllowedMethods: enums -Lint/ConstantDefinitionInBlock: - Exclude: - - 'lib/tasks/data.rake' - # Offense count: 5 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches. Lint/DuplicateBranch: @@ -430,84 +76,34 @@ Lint/DuplicateBranch: - 'app/helpers/format_helper.rb' - 'app/uploaders/picture_uploader.rb' -# Offense count: 1 -# Configuration parameters: AllowComments, AllowEmptyLambdas. -Lint/EmptyBlock: - Exclude: - - 'spec/features/user_spec.rb' - -# Offense count: 2 -Lint/DuplicateHashKey: - Exclude: - - 'db/migrate/20140801164901_move_conference_media_to_commercial.rb' - - 'db/migrate/20140801170430_move_event_media_to_commercial.rb' - # Offense count: 4 Lint/IneffectiveAccessModifier: Exclude: - 'app/models/commercial.rb' - 'app/models/conference.rb' -# Offense count: 4 -# This cop supports unsafe autocorrection (--autocorrect-all). -Lint/NonAtomicFileOperation: - Exclude: - - 'spec/support/save_feature_failures.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Lint/RedundantCopDisableDirective: - Exclude: - - 'spec/support/save_feature_failures.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. -Lint/UnusedBlockArgument: - Exclude: - - 'lib/tasks/user.rake' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. -Lint/UnusedMethodArgument: - Exclude: - - 'config/initializers/fuckups.rb' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -Lint/UriRegexp: - Exclude: - - 'app/models/commercial.rb' - - 'app/models/contact.rb' - -# Offense count: 127 +# Offense count: 111 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: Max: 72 -# Offense count: 28 +# Offense count: 19 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode. # AllowedMethods: refine Metrics/BlockLength: - Max: 211 - -# Offense count: 1 -# Configuration parameters: CountBlocks. -Metrics/BlockNesting: - Max: 4 + Max: 227 -# Offense count: 14 +# Offense count: 13 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 283 + Max: 270 # Offense count: 26 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: - Max: 16 + Max: 15 -# Offense count: 151 +# Offense count: 127 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 55 @@ -517,7 +113,7 @@ Metrics/MethodLength: Metrics/ModuleLength: Max: 168 -# Offense count: 23 +# Offense count: 25 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/PerceivedComplexity: Max: 17 @@ -554,14 +150,6 @@ Naming/PredicateName: - 'app/models/comment.rb' - 'app/models/contact.rb' -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: PreferredName. -Naming/RescuedExceptionsVariableName: - Exclude: - - 'app/models/commercial.rb' - - 'app/models/payment.rb' - # Offense count: 9 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns. # SupportedStyles: snake_case, normalcase, non_integer @@ -573,6 +161,12 @@ Naming/VariableNumber: - 'spec/models/payment_spec.rb' - 'spec/models/ticket_purchase_spec.rb' +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Performance/Casecmp: + Exclude: + - 'config/environments/production.rb' + # Offense count: 1 # Configuration parameters: MinSize. Performance/CollectionLiteralInLoop: @@ -586,12 +180,11 @@ Performance/InefficientHashSearch: - 'app/controllers/admin/versions_controller.rb' - 'app/helpers/versions_helper.rb' -# Offense count: 2 +# Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). Performance/MapCompact: Exclude: - 'app/datatables/registration_datatable.rb' - - 'lib/tasks/events_registrations.rake' # Offense count: 2 # This cop supports unsafe autocorrection (--autocorrect-all). @@ -599,7 +192,7 @@ Performance/StringInclude: Exclude: - 'app/models/commercial.rb' -# Offense count: 28 +# Offense count: 32 RSpec/AnyInstance: Exclude: - 'spec/controllers/admin/rooms_controller_spec.rb' @@ -618,105 +211,32 @@ RSpec/BeEmpty: - 'spec/controllers/conference_registration_controller_spec.rb' - 'spec/models/conference_spec.rb' -# Offense count: 161 +# Offense count: 12 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnabledMethods. RSpec/Capybara/FeatureMethods: - Enabled: false + Exclude: + - 'spec/features/proposals_spec.rb' + - 'spec/features/user_spec.rb' + - 'spec/features/voting_spec.rb' -# Offense count: 318 +# Offense count: 338 # Configuration parameters: Prefixes, AllowedPatterns. # Prefixes: when, with, without RSpec/ContextWording: Enabled: false -# Offense count: 73 +# Offense count: 141 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: SkipBlocks, EnforcedStyle. # SupportedStyles: described_class, explicit RSpec/DescribedClass: Enabled: false -# Offense count: 11 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowConsecutiveOneLiners. -RSpec/EmptyLineAfterExample: - Exclude: - - 'spec/ability/ability_spec.rb' - - 'spec/controllers/admin/comments_controller_spec.rb' - - 'spec/controllers/admin/registration_periods_controller_spec.rb' - - 'spec/controllers/admin/users_controller_spec.rb' - - 'spec/helpers/events_helper_spec.rb' - - 'spec/models/event_spec.rb' - - 'spec/models/survey_spec.rb' - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -RSpec/EmptyLineAfterExampleGroup: - Exclude: - - 'spec/controllers/admin/users_controller_spec.rb' - -# Offense count: 11 -# This cop supports safe autocorrection (--autocorrect). -RSpec/EmptyLineAfterFinalLet: - Exclude: - - 'spec/controllers/admin/event_schedules_controller_spec.rb' - - 'spec/controllers/admin/users_controller_spec.rb' - - 'spec/controllers/application_controller_spec.rb' - - 'spec/features/conference_spec.rb' - - 'spec/models/conference_spec.rb' - - 'spec/models/payment_spec.rb' - - 'spec/models/ticket_spec.rb' - -# Offense count: 16 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowConsecutiveOneLiners. -RSpec/EmptyLineAfterHook: - Exclude: - - 'spec/controllers/admin/booths_controller_spec.rb' - - 'spec/controllers/admin/comments_controller_spec.rb' - - 'spec/controllers/admin/organizations_controller_spec.rb' - - 'spec/controllers/admin/ticket_scannings_controller_spec.rb' - - 'spec/controllers/admin/users_controller_spec.rb' - - 'spec/features/organization_spec.rb' - - 'spec/features/roles_spec.rb' - - 'spec/models/conference_spec.rb' - - 'spec/models/payment_spec.rb' - - 'spec/models/program_spec.rb' - -# Offense count: 8 -# This cop supports safe autocorrection (--autocorrect). -RSpec/EmptyLineAfterSubject: - Exclude: - - 'spec/ability/ability_spec.rb' - - 'spec/models/booth_spec.rb' - - 'spec/models/cfp_spec.rb' - - 'spec/models/event_spec.rb' - - 'spec/models/program_spec.rb' - - 'spec/models/registration_spec.rb' - - 'spec/models/survey_spec.rb' - - 'spec/models/track_spec.rb' - -# Offense count: 215 +# Offense count: 248 # Configuration parameters: CountAsOne. RSpec/ExampleLength: - Max: 187 - -# Offense count: 15 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples. -# DisallowedExamples: works -RSpec/ExampleWording: - Exclude: - - 'spec/controllers/admin/organizations_controller_spec.rb' - - 'spec/controllers/admin/registration_periods_controller_spec.rb' - - 'spec/helpers/application_helper_spec.rb' - - 'spec/helpers/events_helper_spec.rb' - - 'spec/helpers/format_helper_spec.rb' - - 'spec/models/conference_spec.rb' - - 'spec/models/event_spec.rb' - - 'spec/models/ticket_purchase_spec.rb' - - 'spec/models/ticket_spec.rb' + Max: 222 # Offense count: 37 # This cop supports unsafe autocorrection (--autocorrect-all). @@ -754,69 +274,38 @@ RSpec/FilePath: - 'spec/models/comment_spec.rb' - 'spec/models/openid.rb' -# Offense count: 172 +# Offense count: 1 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: implicit, each, example RSpec/HookArgument: - Enabled: false + Exclude: + - 'spec/features/voting_spec.rb' # Offense count: 2 RSpec/IdenticalEqualityAssertion: Exclude: - 'spec/controllers/admin/conferences_controller_spec.rb' -# Offense count: 140 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: is_expected, should -RSpec/ImplicitExpect: - Exclude: - - 'spec/ability/ability_spec.rb' - - 'spec/models/commercial_spec.rb' - - 'spec/models/conference_spec.rb' - - 'spec/models/event_schedule_spec.rb' - - 'spec/models/event_type_spec.rb' - - 'spec/models/organization_spec.rb' - - 'spec/models/registration_period_spec.rb' - - 'spec/models/room_spec.rb' - - 'spec/models/schedule_spec.rb' - - 'spec/models/sponsor_spec.rb' - - 'spec/models/sponsorship_level_spec.rb' - - 'spec/models/ticket_purchase_spec.rb' - - 'spec/models/ticket_spec.rb' - - 'spec/models/user_spec.rb' - -# Offense count: 39 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit -RSpec/ImplicitSubject: - Exclude: - - 'spec/ability/ability_spec.rb' - - 'spec/models/booth_spec.rb' - - 'spec/models/conference_spec.rb' - - 'spec/models/event_type_spec.rb' - - 'spec/models/organization_spec.rb' - - 'spec/models/registration_period_spec.rb' - - 'spec/models/sponsor_spec.rb' - - 'spec/models/sponsorship_level_spec.rb' - - 'spec/models/ticket_purchase_spec.rb' - - 'spec/models/ticket_spec.rb' - -# Offense count: 19 +# Offense count: 53 # Configuration parameters: Max. RSpec/IndexedLet: Exclude: - 'spec/controllers/admin/reports_controller_spec.rb' - 'spec/controllers/admin/roles_controller_spec.rb' + - 'spec/controllers/schedules_controller_spec.rb' + - 'spec/features/proposals_spec.rb' + - 'spec/features/splashpage_spec.rb' - 'spec/features/voting_spec.rb' + - 'spec/helpers/conference_helper_spec.rb' - 'spec/models/conference_spec.rb' + - 'spec/models/event_schedule_spec.rb' - 'spec/models/ticket_purchase_spec.rb' - 'spec/models/ticket_spec.rb' - 'spec/models/user_spec.rb' + - 'spec/services/full_calendar_formatter_spec.rb' -# Offense count: 321 +# Offense count: 344 # Configuration parameters: AssignmentOnly. RSpec/InstanceVariable: Exclude: @@ -836,15 +325,7 @@ RSpec/InstanceVariable: - 'spec/models/track_spec.rb' - 'spec/models/user_spec.rb' -# Offense count: 4 -# This cop supports safe autocorrection (--autocorrect). -RSpec/LeadingSubject: - Exclude: - - 'spec/ability/ability_spec.rb' - - 'spec/models/conference_spec.rb' - - 'spec/models/ticket_spec.rb' - -# Offense count: 61 +# Offense count: 64 RSpec/LetSetup: Enabled: false @@ -867,16 +348,16 @@ RSpec/MultipleDescribes: Exclude: - 'spec/models/conference_spec.rb' -# Offense count: 270 +# Offense count: 298 RSpec/MultipleExpectations: Max: 97 -# Offense count: 249 +# Offense count: 272 # Configuration parameters: AllowSubject. RSpec/MultipleMemoizedHelpers: Max: 32 -# Offense count: 396 +# Offense count: 438 # Configuration parameters: EnforcedStyle, IgnoreSharedExamples. # SupportedStyles: always, named_only RSpec/NamedSubject: @@ -896,46 +377,37 @@ RSpec/NamedSubject: - 'spec/models/ticket_spec.rb' - 'spec/models/track_spec.rb' -# Offense count: 208 +# Offense count: 219 # Configuration parameters: AllowedGroups. RSpec/NestedGroups: Max: 7 -# Offense count: 3 +# Offense count: 4 # Configuration parameters: AllowedPatterns. # AllowedPatterns: ^expect_, ^assert_ RSpec/NoExpectationExample: Exclude: - 'spec/controllers/admin/conferences_controller_spec.rb' - 'spec/controllers/admin/registration_periods_controller_spec.rb' + - 'spec/features/proposals_spec.rb' - 'spec/features/voting_spec.rb' -# Offense count: 83 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: not_to, to_not -RSpec/NotToNot: - Enabled: false - # Offense count: 1 RSpec/OverwritingSetup: Exclude: - 'spec/controllers/admin/booths_controller_spec.rb' -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -RSpec/Rails/AvoidSetupHook: +# Offense count: 11 +RSpec/PendingWithoutReason: Exclude: + - 'spec/ability/ability_spec.rb' + - 'spec/controllers/admin/conferences_controller_spec.rb' + - 'spec/datatables/user_datatable_spec.rb' + - 'spec/features/proposals_spec.rb' - 'spec/features/versions_spec.rb' - - 'spec/helpers/events_helper_spec.rb' - -# Offense count: 2 -# This cop supports unsafe autocorrection (--autocorrect-all). -RSpec/Rails/HaveHttpStatus: - Exclude: - - 'spec/controllers/admin/event_schedules_controller_spec.rb' + - 'spec/models/user_spec.rb' -# Offense count: 11 +# Offense count: 12 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Inferences. RSpec/Rails/InferredSpecType: @@ -944,6 +416,7 @@ RSpec/Rails/InferredSpecType: - 'spec/controllers/admin/programs_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/conference_registration_controller_spec.rb' + - 'spec/features/omniauth_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/conference_helper_spec.rb' - 'spec/helpers/date_time_helper_spec.rb' @@ -967,440 +440,41 @@ RSpec/RepeatedExampleGroupBody: Exclude: - 'spec/models/conference_spec.rb' -# Offense count: 10 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: and_return, block -RSpec/ReturnFromStub: - Exclude: - - 'spec/helpers/events_helper_spec.rb' - -# Offense count: 19 -# This cop supports safe autocorrection (--autocorrect). -RSpec/ScatteredLet: - Exclude: - - 'spec/ability/ability_spec.rb' - - 'spec/models/payment_spec.rb' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -RSpec/ScatteredSetup: - Exclude: - - 'spec/models/payment_spec.rb' - -# Offense count: 32 -# This cop supports safe autocorrection (--autocorrect). -RSpec/SortMetadata: - Exclude: - - 'spec/features/versions_spec.rb' - -# Offense count: 9 -RSpec/StubbedMock: - Exclude: - - 'spec/helpers/events_helper_spec.rb' - -# Offense count: 7 -RSpec/SubjectStub: - Exclude: - - 'spec/models/registration_spec.rb' - - 'spec/models/room_spec.rb' - - 'spec/models/track_spec.rb' - -# Offense count: 3 -# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames. -RSpec/VerifiedDoubles: - Exclude: - - 'spec/datatables/user_datatable_spec.rb' - - 'spec/pdfs/ticket_pdf_spec.rb' - -# Offense count: 1 -RSpec/VoidExpect: - Exclude: - - 'spec/models/conference_spec.rb' - -# Offense count: 24 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: ExpectedOrder, Include. -# ExpectedOrder: index, show, new, edit, create, update, destroy -# Include: app/controllers/**/*.rb -Rails/ActionOrder: - Enabled: false - -# Offense count: 4 -# This cop supports unsafe autocorrection (--autocorrect-all). -Rails/ActiveRecordAliases: - Exclude: - - 'db/migrate/20141104131625_generate_username.rb' - - 'db/migrate/20141117214230_move_banner_description_to_conference.rb' - - 'db/migrate/20141118153918_change_venue_conference_association.rb' - - 'db/migrate/20141118162030_change_lodging_association_to_conference.rb' - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/ActiveRecordCallbacksOrder: - Exclude: - - 'app/models/event.rb' - - 'app/models/track.rb' - - 'app/models/venue.rb' - -# Offense count: 1 -# This cop supports unsafe autocorrection (--autocorrect-all). -Rails/ApplicationController: - Exclude: - - 'app/controllers/api/base_controller.rb' - -# Offense count: 1 -# This cop supports unsafe autocorrection (--autocorrect-all). -Rails/ApplicationMailer: - Exclude: - - 'app/mailers/mailbot.rb' - -# Offense count: 129 -# This cop supports unsafe autocorrection (--autocorrect-all). -Rails/ApplicationRecord: - Enabled: false - -# Offense count: 10 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent. -Rails/Blank: - Exclude: - - 'app/controllers/conferences_controller.rb' - - 'app/controllers/users/omniauth_callbacks_controller.rb' - - 'app/models/program.rb' - - 'app/models/user.rb' - - 'spec/factories/event_schedule.rb' - -# Offense count: 1 -# This cop supports unsafe autocorrection (--autocorrect-all). -Rails/CompactBlank: - Exclude: - - 'app/controllers/surveys_controller.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Rails/ContentTag: - Exclude: - - 'app/helpers/application_helper.rb' - -# Offense count: 13 -# Configuration parameters: Include. -# Include: db/migrate/*.rb -Rails/CreateTableWithTimestamps: - Exclude: - - 'db/migrate/20121223115117_create_rooms_table.rb' - - 'db/migrate/20121223120413_create_event_types.rb' - - 'db/migrate/20130202130737_create_supporter_level_table.rb' - - 'db/migrate/20130202130923_create_table_supporter_registrations.rb' - - 'db/migrate/20130216070725_create_social_events_table.rb' - - 'db/migrate/20131228214532_create_vchoices.rb' - - 'db/migrate/20140109191145_create_qanswers.rb' - - 'db/migrate/20140623100942_create_visits.rb' - - 'db/migrate/20140623101032_create_ahoy_events.rb' - - 'db/migrate/20160309182642_remove_social_events_table.rb' - - 'db/migrate/20160628093634_create_survey_questions.rb' - - 'db/migrate/20170129075434_create_resources_table.rb' - - 'db/migrate/20170529215453_create_organizations.rb' - -# Offense count: 103 -# Configuration parameters: EnforcedStyle, AllowToTime. -# SupportedStyles: strict, flexible -Rails/Date: - Enabled: false - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforceForPrefixed. -Rails/Delegate: - Exclude: - - 'app/models/event.rb' - - 'app/models/room.rb' - - 'app/models/track.rb' - -# Offense count: 4 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: Severity. -Rails/DuplicateAssociation: - Exclude: - - 'app/models/program.rb' - - 'app/models/user.rb' - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -Rails/DurationArithmetic: - Exclude: - - 'spec/models/program_spec.rb' - - 'spec/models/user_spec.rb' - -# Offense count: 3 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: Whitelist, AllowedMethods, AllowedReceivers. -# Whitelist: find_by_sql, find_by_token_for -# AllowedMethods: find_by_sql, find_by_token_for -# AllowedReceivers: Gem::Specification, page -Rails/DynamicFindBy: - Exclude: - - 'app/controllers/admin/events_controller.rb' - - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' - -# Offense count: 5 -# This cop supports safe autocorrection (--autocorrect). -Rails/EagerEvaluationLogMessage: - Exclude: - - 'app/controllers/admin/events_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/controllers/proposals_controller.rb' - - 'app/models/event.rb' - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/EnumHash: - Exclude: - - 'app/models/conference.rb' - - 'app/models/survey.rb' - - 'app/models/survey_question.rb' - -# Offense count: 7 -# Configuration parameters: EnforcedStyle. -# SupportedStyles: slashes, arguments -Rails/FilePath: - Exclude: - - 'app/pdfs/ticket_pdf.rb' - - 'config/initializers/carrierwave.rb' - - 'lib/tasks/migrate_config.rake' - - 'spec/features/lodgings_spec.rb' - - 'spec/features/sponsor_spec.rb' - - 'spec/support/deprecation_shitlist.rb' - -# Offense count: 6 -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/HasAndBelongsToMany: - Exclude: - - 'app/models/conference.rb' - - 'app/models/qanswer.rb' - - 'app/models/question.rb' - - 'app/models/registration.rb' - - 'app/models/vchoice.rb' - -# Offense count: 24 -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/HasManyOrHasOneDependent: - Enabled: false - -# Offense count: 5 -# Configuration parameters: Include. -# Include: app/helpers/**/*.rb -Rails/HelperInstanceVariable: - Exclude: - - 'app/helpers/application_helper.rb' - - 'app/helpers/events_helper.rb' - - 'app/helpers/format_helper.rb' - -# Offense count: 8 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: numeric, symbolic -Rails/HttpStatus: - Exclude: - - 'app/controllers/admin/commercials_controller.rb' - - 'app/controllers/admin/event_schedules_controller.rb' - - 'app/controllers/admin/programs_controller.rb' - - 'app/controllers/admin/tracks_controller.rb' - - 'app/controllers/admin/venue_commercials_controller.rb' - - 'app/controllers/commercials_controller.rb' - -# Offense count: 100 -Rails/I18nLocaleTexts: - Enabled: false - -# Offense count: 7 -# Configuration parameters: IgnoreScopes, Include. -# Include: app/models/**/*.rb -Rails/InverseOf: - Exclude: - - 'app/models/booth.rb' - - 'app/models/conference.rb' - - 'app/models/event.rb' - - 'app/models/user.rb' - -# Offense count: 1 -# Configuration parameters: Include. -# Include: app/controllers/**/*.rb, app/mailers/**/*.rb -Rails/LexicallyScopedActionFilter: - Exclude: - - 'app/controllers/registrations_controller.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Rails/LinkToBlank: - Exclude: - - 'app/helpers/format_helper.rb' - -# Offense count: 1 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: Include. -# Include: app/mailers/**/*.rb -Rails/MailerName: - Exclude: - - 'app/mailers/mailbot.rb' - -# Offense count: 3 -Rails/OutputSafety: - Exclude: - - 'app/helpers/events_helper.rb' - - 'app/models/commercial.rb' - -# Offense count: 6 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: conservative, aggressive -Rails/PluckInWhere: - Exclude: - - 'app/models/ability.rb' - - 'app/models/admin_ability.rb' - -# Offense count: 16 -# This cop supports safe autocorrection (--autocorrect). -Rails/PluralizationGrammar: - Exclude: - - 'spec/models/conference_spec.rb' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -Rails/Presence: - Exclude: - - 'app/controllers/schedules_controller.rb' - - 'app/models/user.rb' - -# Offense count: 15 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank. -Rails/Present: - Exclude: - - 'app/models/cfp.rb' - - 'app/models/email_settings.rb' - - 'app/models/event.rb' - - 'app/models/program.rb' - - 'app/models/venue.rb' - -# Offense count: 6 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: Include. -# Include: **/Rakefile, **/*.rake -Rails/RakeEnvironment: - Exclude: - - 'lib/tasks/dump_db.rake' - - 'lib/tasks/spec.rake' - -# Offense count: 21 -# This cop supports unsafe autocorrection (--autocorrect-all). -Rails/RedundantPresenceValidationOnBelongsTo: - Enabled: false - -# Offense count: 2 -Rails/RenderInline: - Exclude: - - 'app/controllers/conferences_controller.rb' - - 'app/controllers/schedules_controller.rb' - -# Offense count: 10 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: Include. -# Include: spec/controllers/**/*.rb, spec/requests/**/*.rb, test/controllers/**/*.rb, test/integration/**/*.rb -Rails/ResponseParsedBody: - Exclude: - - 'spec/controllers/api/v1/conferences_controller_spec.rb' - - 'spec/controllers/api/v1/events_controller_spec.rb' - - 'spec/controllers/api/v1/rooms_controller_spec.rb' - - 'spec/controllers/api/v1/speakers_controller_spec.rb' - - 'spec/controllers/api/v1/tracks_controller_spec.rb' - -# Offense count: 4 -# Configuration parameters: Include. -# Include: db/**/*.rb -Rails/ReversibleMigration: - Exclude: - - 'db/migrate/20170108053041_add_default_to_revision_in_conference.rb' - - 'db/migrate/20170715131706_make_track_state_not_null_and_add_default_value.rb' - - 'db/migrate/20170720134353_make_track_cfp_active_not_null.rb' - - 'db/migrate/20171118113113_change_visit_id_type_of_ahoy_events_to_integer.rb' - -# Offense count: 48 -# Configuration parameters: ForbiddenMethods, AllowedMethods. -# ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all -Rails/SkipsModelValidations: - Enabled: false - -# Offense count: 77 -# Configuration parameters: Include. -# Include: db/**/*.rb -Rails/ThreeStateBooleanColumn: - Enabled: false - -# Offense count: 40 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: strict, flexible -Rails/TimeZone: - Exclude: - - 'app/models/comment.rb' - - 'app/models/conference.rb' - - 'config/environments/test.rb' - - 'db/migrate/20180226032958_add_created_at_and_updated_at_to_event_types.rb' - - 'db/migrate/20180313012253_add_timestamps_to_tickets.rb' - - 'lib/tasks/dump_db.rake' - - 'spec/controllers/admin/comments_controller_spec.rb' - - 'spec/factories/users.rb' - - 'spec/models/conference_spec.rb' - -# Offense count: 1 +# Offense count: 2 # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: Severity. -Rails/TopLevelHashWithIndifferentAccess: +RSpec/ScatteredSetup: Exclude: - - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' + - 'spec/models/payment_spec.rb' -# Offense count: 13 -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/UniqueValidationWithoutIndex: +# Offense count: 32 +# This cop supports safe autocorrection (--autocorrect). +RSpec/SortMetadata: Exclude: - - 'app/models/booth.rb' - - 'app/models/cfp.rb' - - 'app/models/commercial.rb' - - 'app/models/conference.rb' - - 'app/models/events_registration.rb' - - 'app/models/organization.rb' - - 'app/models/registration.rb' - - 'app/models/role.rb' - - 'app/models/subscription.rb' - - 'app/models/survey_reply.rb' - - 'app/models/survey_submission.rb' - - 'app/models/track.rb' - - 'app/models/vote.rb' - -# Offense count: 17 -# This cop supports unsafe autocorrection (--autocorrect-all). -Rails/WhereEquals: + - 'spec/features/versions_spec.rb' + +# Offense count: 9 +RSpec/StubbedMock: Exclude: - - 'app/controllers/admin/registrations_controller.rb' - - 'app/models/admin_ability.rb' - - 'app/models/conference.rb' - - 'app/models/event_schedule.rb' - - 'app/models/program.rb' - - 'app/models/user.rb' + - 'spec/helpers/events_helper_spec.rb' + +# Offense count: 7 +RSpec/SubjectStub: + Exclude: + - 'spec/models/registration_spec.rb' + - 'spec/models/room_spec.rb' + - 'spec/models/track_spec.rb' + +# Offense count: 3 +# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames. +RSpec/VerifiedDoubles: + Exclude: + - 'spec/datatables/user_datatable_spec.rb' + - 'spec/pdfs/ticket_pdf_spec.rb' # Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Rails/WhereNot: +RSpec/VoidExpect: Exclude: - - 'db/migrate/20140820093735_migrating_supporter_registrations_to_ticket_users.rb' + - 'spec/models/conference_spec.rb' # Offense count: 3 Security/Open: @@ -1421,90 +495,12 @@ Style/CaseLikeIf: Exclude: - 'app/views/admin/events/events.xlsx.axlsx' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: is_a?, kind_of? -Style/ClassCheck: - Exclude: - - 'app/models/email_settings.rb' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -Style/ColonMethodCall: - Exclude: - - 'app/models/commercial.rb' - - 'app/models/contact.rb' - -# Offense count: 1 -Style/CombinableLoops: - Exclude: - - 'db/migrate/20140820093735_migrating_supporter_registrations_to_ticket_users.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: Keywords, RequireColon. -# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE -Style/CommentAnnotation: - Exclude: - - 'spec/controllers/admin/versions_controller_spec.rb' - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions. -# SupportedStyles: assign_to_condition, assign_inside_condition -Style/ConditionalAssignment: - Exclude: - - 'app/helpers/format_helper.rb' - - 'db/migrate/20140610165551_migrate_data_person_to_user.rb' - - 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb' - -# Offense count: 518 +# Offense count: 103 # Configuration parameters: AllowedConstants. Style/Documentation: Enabled: false -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -Style/EmptyCaseCondition: - Exclude: - - 'app/helpers/format_helper.rb' - - 'app/helpers/versions_helper.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Style/EmptyLiteral: - Exclude: - - 'spec/models/conference_spec.rb' - -# Offense count: 7 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: compact, expanded -Style/EmptyMethod: - Exclude: - - 'app/controllers/admin/lodgings_controller.rb' - - 'app/controllers/users_controller.rb' - - 'db/migrate/20121223115125_create_tracks_table.rb' - - 'db/migrate/20121223115135_create_events_table.rb' - - 'db/migrate/20130103134212_create_registrations_table.rb' - - 'db/migrate/20130206192339_rename_attending_social_events_with_partner.rb' - - 'db/migrate/20130216122155_set_registration_defaults_to_false.rb' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -Style/Encoding: - Exclude: - - 'app/uploaders/picture_uploader.rb' - - 'spec/models/conference_spec.rb' - -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Style/ExpandPathArguments: - Exclude: - - 'spec/spec_helper.rb' - -# Offense count: 36 +# Offense count: 40 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -1517,44 +513,18 @@ Style/GlobalStdStream: Exclude: - 'config/environments/production.rb' -# Offense count: 28 +# Offense count: 36 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: MinBodyLength, AllowConsecutiveConditionals. Style/GuardClause: Enabled: false -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: braces, no_braces -Style/HashAsLastArrayItem: - Exclude: - - 'app/controllers/admin/schedules_controller.rb' - - 'app/models/user.rb' - -# Offense count: 5 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowSplatArgument. -Style/HashConversion: - Exclude: - - 'app/helpers/chart_helper.rb' - - 'app/models/conference.rb' - - 'spec/factories/event_users.rb' - # Offense count: 1 # Configuration parameters: MinBranchesCount. Style/HashLikeCase: Exclude: - 'app/helpers/versions_helper.rb' -# Offense count: 367 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. -# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys -# SupportedShorthandSyntax: always, never, either, consistent -Style/HashSyntax: - Enabled: false - # Offense count: 2 # This cop supports unsafe autocorrection (--autocorrect-all). Style/HashTransformValues: @@ -1562,7 +532,14 @@ Style/HashTransformValues: - 'app/controllers/admin/comments_controller.rb' - 'app/helpers/chart_helper.rb' -# Offense count: 58 +# Offense count: 4 +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/IdenticalConditionalBranches: + Exclude: + - 'app/controllers/admin/booths_controller.rb' + - 'app/controllers/admin/events_controller.rb' + +# Offense count: 32 # This cop supports safe autocorrection (--autocorrect). Style/IfUnlessModifier: Enabled: false @@ -1574,18 +551,12 @@ Style/LineEndConcatenation: - 'spec/features/conference_spec.rb' - 'spec/features/registration_periods_spec.rb' -# Offense count: 1 +# Offense count: 3 # This cop supports unsafe autocorrection (--autocorrect-all). Style/MapToHash: Exclude: - 'app/controllers/admin/comments_controller.rb' - -# Offense count: 9 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline -Style/MethodDefParentheses: - Exclude: + - 'app/helpers/chart_helper.rb' - 'app/models/conference.rb' # Offense count: 3 @@ -1600,13 +571,12 @@ Style/MixinUsage: Exclude: - 'spec/spec_helper.rb' -# Offense count: 7 -# This cop supports safe autocorrection (--autocorrect). -Style/MultilineIfModifier: +# Offense count: 1 +Style/MultilineBlockChain: Exclude: - 'app/controllers/admin/comments_controller.rb' -# Offense count: 2 +# Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: literals, strict @@ -1614,43 +584,7 @@ Style/MutableConstant: Exclude: - 'app/models/event_user.rb' -# Offense count: 4 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowedMethods. -# AllowedMethods: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with -Style/NestedParenthesizedCalls: - Exclude: - - 'spec/features/conference_spec.rb' - - 'spec/models/conference_spec.rb' - -# Offense count: 27 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, MinBodyLength. -# SupportedStyles: skip_modifier_ifs, always -Style/Next: - Enabled: false - -# Offense count: 115 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedOctalStyle. -# SupportedOctalStyles: zero_with_o, zero_only -Style/NumericLiteralPrefix: - Exclude: - - 'config/environments/test.rb' - - 'spec/controllers/admin/conferences_controller_spec.rb' - - 'spec/helpers/date_time_helper_spec.rb' - - 'spec/models/conference_spec.rb' - - 'spec/models/email_settings_spec.rb' - - 'spec/serializers/conference_serializer_spec.rb' - - 'spec/serializers/event_serializer_spec.rb' - -# Offense count: 7 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: Strict, AllowedNumbers, AllowedPatterns. -Style/NumericLiterals: - MinDigits: 15 - -# Offense count: 36 +# Offense count: 32 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns. # SupportedStyles: predicate, comparison @@ -1681,75 +615,13 @@ Style/OptionalBooleanParameter: - 'app/helpers/format_helper.rb' - 'app/models/event.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Style/OrAssignment: - Exclude: - - 'app/controllers/schedules_controller.rb' - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions. -Style/ParenthesesAroundCondition: - Exclude: - - 'app/controllers/admin/base_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/helpers/format_helper.rb' - -# Offense count: 17 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: PreferredDelimiters. -Style/PercentLiteralDelimiters: - Exclude: - - 'Gemfile' - - 'app/controllers/admin/users_controller.rb' - - 'app/models/cfp.rb' - - 'app/models/comment.rb' - - 'app/models/commercial.rb' - - 'app/models/conference.rb' - - 'app/models/contact.rb' - - 'app/models/registration.rb' - - 'app/models/subscription.rb' - - 'app/models/track.rb' - - 'app/uploaders/picture_uploader.rb' - - 'config/deploy.rb' - - 'spec/models/program_spec.rb' - -# Offense count: 1 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: short, verbose -Style/PreferredHashMethods: - Exclude: - - 'lib/tasks/migrate_config.rake' - -# Offense count: 6 +# Offense count: 2 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowedCompactTypes. # SupportedStyles: compact, exploded Style/RaiseArgs: EnforcedStyle: compact -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Style/RandomWithOffset: - Exclude: - - 'spec/factories/sponsors.rb' - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -Style/RedundantAssignment: - Exclude: - - 'app/helpers/application_helper.rb' - - 'app/helpers/format_helper.rb' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -Style/RedundantCondition: - Exclude: - - 'app/helpers/versions_helper.rb' - - 'app/models/ticket.rb' - # Offense count: 2 # This cop supports safe autocorrection (--autocorrect). Style/RedundantConstantBase: @@ -1764,112 +636,19 @@ Style/RedundantFetchBlock: Exclude: - 'config/puma.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Style/RedundantParentheses: - Exclude: - - 'app/controllers/admin/base_controller.rb' - -# Offense count: 6 -# This cop supports safe autocorrection (--autocorrect). -Style/RedundantRegexpEscape: - Exclude: - - 'spec/models/room_spec.rb' - - 'spec/models/user_spec.rb' - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowMultipleReturnValues. -Style/RedundantReturn: - Exclude: - - 'app/controllers/admin/booths_controller.rb' - - 'app/controllers/admin/events_controller.rb' - - 'app/controllers/admin/organizations_controller.rb' - # Offense count: 2 # This cop supports safe autocorrection (--autocorrect). Style/RedundantStringEscape: Exclude: - 'app/models/conference.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, AllowInnerSlashes. -# SupportedStyles: slashes, percent_r, mixed -Style/RegexpLiteral: - Exclude: - - 'app/uploaders/picture_uploader.rb' - -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: implicit, explicit -Style/RescueStandardError: - Exclude: - - 'app/controllers/users/omniauth_callbacks_controller.rb' - - 'lib/tasks/migrate_config.rake' - -# Offense count: 3 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: only_raise, only_fail, semantic -Style/SignalException: - Exclude: - - 'lib/tasks/user.rake' - - 'spec/support/flash.rb' - -# Offense count: 6 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowModifier. -Style/SoleNestedConditional: - Exclude: - - 'app/controllers/admin/users_controller.rb' - - 'app/models/event.rb' - - 'app/models/user.rb' - - 'db/migrate/20140801164901_move_conference_media_to_commercial.rb' - - 'db/migrate/20140801170430_move_event_media_to_commercial.rb' - - 'db/migrate/20151018152439_create_programs_table.rb' - -# Offense count: 28 +# Offense count: 34 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Mode. Style/StringConcatenation: Enabled: false -# Offense count: 17 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. -# SupportedStyles: single_quotes, double_quotes -Style/StringLiterals: - Exclude: - - 'Gemfile' - - 'config/deploy.rb' - - 'config/environments/production.rb' - - 'config/puma.rb' - - 'lib/tasks/dump_db.rake' - - 'lib/tasks/events_registrations.rake' - - 'lib/tasks/factory_bot.rake' - - 'lib/tasks/user.rake' - -# Offense count: 14 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: single_quotes, double_quotes -Style/StringLiteralsInInterpolation: - Exclude: - - 'app/views/admin/events/_all_events.xlsx.axlsx' - - 'app/views/admin/events/_all_with_comments.xlsx.axlsx' - - 'app/views/admin/events/_confirmed_events.xlsx.axlsx' - - 'lib/tasks/dump_db.rake' - -# Offense count: 110 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, MinSize. -# SupportedStyles: percent, brackets -Style/SymbolArray: - Enabled: false - -# Offense count: 10 +# Offense count: 11 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments. # AllowedMethods: define_method, mail, respond_to @@ -1882,32 +661,15 @@ Style/SymbolProc: - 'spec/controllers/admin/conferences_controller_spec.rb' - 'spec/support/flash.rb' -# Offense count: 2 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyle, AllowSafeAssignment. -# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex -Style/TernaryParentheses: - Exclude: - - 'app/helpers/format_helper.rb' - -# Offense count: 21 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: EnforcedStyleForMultiline. -# SupportedStylesForMultiline: comma, consistent_comma, no_comma -Style/TrailingCommaInHashLiteral: - Exclude: - - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' - - 'spec/models/conference_spec.rb' - -# Offense count: 3 +# Offense count: 1 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: WordRegex. # SupportedStyles: percent, brackets Style/WordArray: EnforcedStyle: percent - MinSize: 6 + MinSize: 5 -# Offense count: 524 +# Offense count: 260 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https