ICU4J dependency

[gsmet]

Hi Santiago,

We are using galimatias for quite some time now without any issue.

You recently introduced a dependency to ICU4J in this commit 5ce2cb9 and I was wondering if there was a way to fix the issue without adding this dependency.

You might have missed it but ICU4J is a 10 MB jar which is quite huge.

Thanks for your work.

[dadmin-admin]

+1

[smola]

As far as I know, ICU4J contains the only full IDNA:2008 implementation in Java, which is required to fully support the URL standard. I will consider any other implementation if it is available. It might also be possible to extract a subset of ICU4J and vendor it here, but I didn't check how much code would be required.

PRs or suggestions are welcome.

[sideshowbarker]

As far as I know, ICU4J contains the only full IDNA:2008 implementation in Java

Right. Specifically, java.net.IDN still doesn’t have IDNA:2008 support. Neither does the GNU Libidn Java port. (The GNU Libidn2 C library implements IDNA:2008, but there’s no Java port of it.)

which is required to fully support the URL standard. I will consider any other implementation if it is available. It might also be possible to extract a subset of ICU4J and vendor it here, but I didn't check how much code would be required.

It seems to me that the level of effort required to extract what’s needed for galimatias’s purpose would be quite high. So while I’m not super happy either with the ICU4J dependency, it really does seem like we’re pretty much stuck with it — at least if the goal continues to be to provide an implementation that conforms to the URL standard (which I strongly agree it should be).