feat: enable endpoint discovery #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es instances across `withClient` calls
aajtodd
reviewed
Jul 17, 2023
| import kotlin.reflect.KClass | ||
|
|
||
| @InternalApi | ||
| public class DiscoveredEndpointErrorInterceptor( |
There was a problem hiding this comment.
nit: Documentation/reason for existing
|
|
||
| actual.shouldContainOnlyOnceWithDiff( | ||
| """ | ||
| internal suspend fun asEndpointResolver(client: TestClient, delegate: EndpointResolverAdapter) = EndpointResolver { request -> |
There was a problem hiding this comment.
correctness: Why does the conversion asEndpointResolver need to be suspend?
There was a problem hiding this comment.
Good catch, it does not need to be.
lauzadis
approved these changes
Jul 17, 2023
Comment on lines
+29
to
+30
| assertEquals(0, cache.get("a") { uncachedValue() }) | ||
| assertEquals(1, cache.get("b") { uncachedValue() }) |
There was a problem hiding this comment.
here instead of uncachedValue() it could be better to pass a function that throws an exception, to check that the cached value is read instead of the pass-through function being invoked
aajtodd
approved these changes
Jul 18, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Closes #146
Description of changes
Enables endpoint discovery for services that specify the correct traits in their models. Specifically:
Note that this does not fully implement the Smithy spec because it assumes that no operation name or identifiers are passed to the discover endpoints operation, which is true for all AWS services that currently support endpoint discovery (i.e., DynamoDB, Timestream Query, and Timestream Write).
Companion PR: aws-sdk-kotlin#976
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.