feat(go): handle unhandled orphanShapes #761
Open
+314
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishav-karanjit
changed the title
…ng/smithy-dafny into rishav/go/orphanShapes
…into rishav/go/orphanShapes
This reverts commit ca63226.
rishav-karanjit
changed the title
| github.com/dafny-lang/DafnyRuntimeGo/v4 v4.9.1 | ||
| github.com/dafny-lang/DafnyStandardLibGo v0.0.0 | ||
| github.com/dafny-lang/DafnyRuntimeGo/v4 v4.9.2 | ||
| github.com/aws/aws-cryptographic-material-providers-library/releases/go/smithy-dafny-standard-library v0.0.0 |
There was a problem hiding this comment.
I see TestModels are using Crypto Tools' MPL's StandardLibrary. Did we run this be @robin-aws ? I just want to make sure everyone's aware of the weird dependency graph going around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
For extra credit this is the diff in MPL from this branch https://github.com/aws/aws-cryptographic-material-providers-library/pull/1225/files. This PR in MPL created only to run CI and see diff
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.