fix(Go): always generate code in an order #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishav-karanjit
changed the title
rishav-karanjit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We want smithy dafny generated code to have same order so that we can check git diff. To have same order, we need to avoid hashmap and hashsets. This PR sorts the top level shape before getting into shape visitor in a natural order (like A-Z for strings, or 1,2,3 for numbers). Once inside shape visitor, all the shapes will be sorted in the order they are getting visited.
Reference:
https://docs.oracle.com/javase/8/docs/api/?java/util/HashMap.html
https://docs.oracle.com/javase/8/docs/api/java/util/HashSet.html
Similar PR in for Smithy Dafny Java: #238
Testing
Tested these changes in MPL on https://github.com/aws/aws-cryptographic-material-providers-library/tree/check-go-polymorph-diff. See the github action triggered from the latest commit on this branch (I made changes to workflow file to run CI to check diff when I commit on this branch)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.