Removed executor memoization from useExecutor

smikhalevski · Nov 25, 2024 · 28ff817 · 28ff817
1 parent e66bc3c
commit 28ff817
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/src/main/useExecutor.ts b/src/main/useExecutor.ts
@@ -1,4 +1,3 @@
-import { useMemo } from 'react';
 import type { Executor, ExecutorPlugin, ExecutorTask, NoInfer } from './types';
 import { useExecutorManager } from './useExecutorManager';
 import { useExecutorSubscription } from './useExecutorSubscription';
@@ -48,9 +47,7 @@ export function useExecutor(
   initialValue?: unknown,
   plugins?: Array<ExecutorPlugin | null | undefined>
 ): Executor {
-  const manager = useExecutorManager();
-
-  const executor = useMemo(() => manager.getOrCreate(key, initialValue, plugins), Array.isArray(key) ? key : [key]);
+  const executor = useExecutorManager().getOrCreate(key, initialValue, plugins);
 
   useExecutorSubscription(executor);
 

diff --git a/src/test/useExecutor.test.tsx b/src/test/useExecutor.test.tsx
@@ -44,9 +44,7 @@ describe('useExecutor', () => {
   });
 
   test('returns the same executor for an array-of-primitives key', () => {
-    const manager = new ExecutorManager({
-      keySerializer: key => key,
-    });
+    const manager = new ExecutorManager();
 
     const hook = renderHook(() => useExecutor(['xxx', 111]), {
       wrapper: props => (