Add PHP 8.4 support to Smarty

[Visualq]

This pull request updates the code base to support the deprecations introduced in PHP 8.4. It should be backwards compatible.

1. Updated the function signatures that had implicit null assignment to typed parameters.
2. Added PHP 8.4 to the 'run tests'-shell script.
3. Bumped the PHP version in the README.md

[scottchiefbaker]

Wow... way to stay ahead of things. I support this effort in theory, but is the PHP 8.4 syntax 100% nailed down? Does it make sense to wait until we're 100% sure the syntax isn't gonna change.

I didn't even know PHP 8.4 alpha was out until I saw this issue :)

[Visualq]

Wow... way to stay ahead of things. I support this effort in theory, but is the PHP 8.4 syntax 100% nailed down? Does it make sense to wait until we're 100% sure the syntax isn't gonna change.

I didn't even know PHP 8.4 alpha was out until I saw this issue :)

I ran the test suite against the PHP 8.4 alpha version (no errors/or deprecation warnings). There has been a feature stop and it appears that a lot of 'proposed' deprecations for PHP 8.4 are still being discussed (https://wiki.php.net/rfc/deprecations_php_8_4). Functions that would require attention if all the deprecations are implemented/pass are:

• md5()
• sha1()
• strtok()
• passing E_USER_ERROR to trigger_error()
• E_STRICT Constant

The md5() and sha1() could be replaced with hash() however that would bump Smarty's minimum's PHP version to 8.0 or they could be polyfilled but this might be a performance debate. Maybe a simple function_exists could solve this without to much performance degredation

The strtok() is used once within Smarty and can be replaced.

The two deprecations regarding the error constants can easily be solved

This might not be a full PHP 8.4 support update for when it's released. The adjustments are safe down to PHP 7.1.

[eileenmcnaughton]

I took a look at this & support it being merged. I guess the only contentious part of merging it from my point of view is whether you want to declare php8.4 support - the other changes all seem to be fine as 'preparation' if you are not prepared to go all in

[marclaporte]

is the PHP 8.4 syntax 100% nailed down

The next planned release is RC1 so syntax changes are unlikely at this point.
https://wiki.php.net/todo/php84

[Visualq]

This should cover all the PHP 8.4 deprecations. I ran the tests against the PHP 8.4 RC1 release and besides the small E_STRICT deprecation it works as intended.

I added the PHP 8.4 to CI and, for now, the PHP 8.4 RC1 docker image to the test suite.

One final note:

In smarty-lexer project the following line in Parser.php:
$n = strtok(substr($z, $j), " \t");

can be replaced with:
$n = preg_split("/[ \t]/",substr($z, $j), 2)[0];

to make the lexer php 8.4 compatible aswell, for now this doesn't effect the Smarty library.

[carloscz]

Hi, PHP 8.4 should be released next week, we run compatibility tests and Smarty emits a lot of deprecation warnings solved in this PR so good job 👍 :) when do You think this could be released?

[Hlavtox]

PHP 8.4 coming thursday, let's go! :-)

[eileenmcnaughton]

yay

[matks]

Great work 🎉

[jolelievre]

Thanks @Visualq and @wisskid

I proposed a similar PR for the version 4 #1084 mostly inspired by this one
It's my first time contributing on Smarty so I'm not sure if my PR has the right format, if it targets the right branch for Smarty 4

Also, the CI doesn't seem to run for now, maybe because a committer needs to approve the run?

[wisskid]

I’ll review and run the checks ASAP.thanks!Op 21 nov 2024 om 12:21 heeft Jonathan Lelievre ***@***.***> het volgende geschreven: Thanks @Visualq and @wisskid I proposed a similar PR for the version 4 #1084 mostly inspired by this one It's my first time contributing on Smarty so I'm not sure if my PR has the right format, if it targets the right branch for Smarty 4 Also, the CI doesn't seem to run for now, maybe because a committer needs to approve the run? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[eileenmcnaughton]

Thank you for your work on this!!