[Cherry Pick] Zircuit ZK Overflow detection #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support Zircuit fraud transactions detection and zk overflow detection, need dedup and unit test * add dedup * fix test * add unit tests * rm * update chaintype * update for testnet chainType * address comments * update log level
* add nil ptr check for findBroadcastedAttempts * add changeset * fix loop variable lint * remove comment * add nil ptr check for BroadcastBeforeBlockNum * add error log * update log fmt * break logs * update sanity check * add unit test coverage for empty BroadcastBeforeBlockNum * update comments * fix test name * fix make
stackman27
changed the base branch from
ccip-develop
to
release/2.15.0-ccip1.5
stackman27
requested review from
a team,
makramkd,
RayXpub,
jmank88 and
krehermann
as code owners
stackman27
changed the base branch from
release/2.15.0-ccip1.5
to
ccip-develop
stackman27
changed the base branch from
ccip-develop
to
release/2.17.0-ccip1.5
stackman27
requested review from
winder,
asoliman92,
dimkouv,
mateusz-sekara,
0xAustinWang and
b-gopalswami
and removed request for
a team
ogtownsend
approved these changes
Jan 8, 2025
stackman27
changed the base branch from
release/2.17.0-ccip1.5
to
ccip-develop
stackman27
approved these changes
Jan 8, 2025
stackman27
added a commit
that referenced
this pull request
Jan 9, 2025
Support Zircuit fraud transactions detection and zk overflow detection, need dedup and unit test --------- Co-authored-by: Joe Huang <joe.huang@smartcontract.com> Co-authored-by: stackman27 <sishir.giri@smartcontract.com>
stackman27
added a commit
that referenced
this pull request
Jan 9, 2025
Support Zircuit fraud transactions detection and zk overflow detection, need dedup and unit test --------- ## Motivation ## Solution Co-authored-by: amit-momin <108959691+amit-momin@users.noreply.github.com> Co-authored-by: Joe Huang <joe.huang@smartcontract.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Zircuit fraud transactions detection and zk overflow detection, need dedup and unit test