Detachment of the list of commands for selecting a signal source from the list of signal sources. #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the list of signal sources. There is one serious flaw in the current implementation of the media player: if I don't want to see channels in the source list (on TV), then I can't select a channel using a script (with a number). This happens because channel switching commands are removed from the list of commands using a custom configuration (not everyone needs channel numbers in the list of sources, this is personally inconvenient for me). Adding a copy of the dictionary with commands for generating a list of signal sources solves this problem, since in this case the original set of commands remains unchanged and switching channels by number will be available. At the same time, the list of devices will be based on the list of commands from the device configuration, but can be shortened (edited) by the user in the yaml device configuration without affecting the functionality of the device.
glebsterx
changed the title
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Almost 2 years have passed, and I consider the test passed and successful, because I use the component with the modification from this PR every day |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one serious flaw in the current implementation of the media player: if I don't want to see channels in the source list (on TV), then I can't select a channel using a script (with a number).
This happens because channel switching commands are removed from the list of commands using a custom configuration (not everyone needs channel numbers in the list of sources, this is personally inconvenient for me).
Adding a copy of the dictionary with commands for generating a list of signal sources solves this problem, since in this case the original set of commands remains unchanged and switching channels by number will be available. At the same time, the list of devices will be based on the list of commands from the device configuration, but can be shortened (edited) by the user in the yaml device configuration without affecting the functionality of the device.