chore: update documentation #758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitormattos
force-pushed
the
chore/427/update-documentation
branch
from
90ce3bc to
2edc3ac
Compare
Follow up of issue smalot#427 using the suggested code at issue smalot#472. Notes: Have PDF files that the pdfparser can't get the MediaBox, as fallback to get the page dimension is possible to use the BBox (Bounding Box). The Bounding Box could not have the real dimension of a page put is a solution to have a value that could be the page dimension at cases that isn't possible to found the MediaBox. The BBox only was found at the first page, maybe would be good to check if have a best way to get the page dimensions only using the MediaBox and solving the issue that hide this information. Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
force-pushed
the
chore/427/update-documentation
branch
from
2edc3ac to
435d932
Compare
|
Thank you for this PR. I re-run all the tests but they keep failing. Would you mind having a closer look? |
|
I made more tests from my side and identified that the workaround didn't solved the edge case. I think that would be best close this PR and don't merge for now. The BBox don't return the page size at all cases. I think that have a problem at parse when identify the MediaBox but this is too complex to me at this moment to identify what's happening. |
|
Alright, but thanks anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of issue #427 using the suggested code at issue #472.
Notes:
Have PDF files that the pdfparser can't get the MediaBox, as fallback to get the page dimension is possible to use the BBox (Bounding Box).
The Bounding Box could not have the real dimension of a page put is a solution to have a value that could be the page dimension at cases that isn't possible to found the MediaBox.
Type of pull request
About
Checklist for code / configuration changes
See [CONTRIBUTING.md] for all essential information about contributing.