Skip to content
This repository has been archived by the owner on Dec 26, 2023. It is now read-only.

use switch instead of if, and case insensitize #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bransonf
Copy link
Member

  • switch is better practice/cleaner than many else if's
  • enforcing capitalization can be frustrating and is unnecessary

@chris-prener
Copy link
Member

I'm happy to make the "switch" (made myself laugh) but this PR seems to have broken all of the unit testing on here.

@bransonf
Copy link
Member Author

bransonf commented Oct 15, 2019 via email

@bransonf
Copy link
Member Author

Forgot to lint first time around, but I fixed the missing comma.

As far as why Appveyor is failing, the configuration doesn't have testthat or covr installed since they're only suggests:

@chris-prener
Copy link
Member

No, the suggests is all that is needed I believe. I'll have to look into this...

@bransonf
Copy link
Member Author

bransonf commented Oct 18, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants