Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix materialized_minmax test failing on aarch64-apple-darwin #6567

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix materialized_minmax test failing on aarch64-apple-darwin #6567

merged 1 commit into from
Oct 16, 2024

Conversation

tronical
Copy link
Member

Don't cast FLT_MAX to int, that's undefined behaviour.

@tronical
Fix materialized_minmax test failing on aarch64-apple-darwin
476002f 
Don't cast FLT_MAX to int, that's undefined behaviour.
ogoffart
ogoffart approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah well. Sad that it fails and we don't fix the root cause. But whatever works.

@tronical tronical merged commit 0d28920 into master Oct 16, 2024
36 checks passed
@tronical tronical deleted the simon/layout-minmax-float branch October 16, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogoffart ogoffart ogoffart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tronical @ogoffart