Skip to content

Require a minimum Rogue version #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

Require a minimum Rogue version #1258

merged 2 commits into from
Apr 18, 2025

Conversation

bengineerd
Copy link
Contributor

Description

Set the minimum Rogue version to 6.1.0

Details

In 6.1.0 we changed it so that bitSize is no longer necessary for arrays.

            self.add(pr.RemoteVariable(
                name        = "Mem",
                description = "Memory Array",
                offset      = 0x0000,
                numValues   = nelms,
                valueBits   = 32,
                valueStride = 32,
                bitSize     = 32 * nelms, # This is no longer necessary
                bulkOpEn    = False,
            ))

But if it's not set, older rogue will default to bitSize=32 then fail.
Then the uses gets a cryptic (to them) error from inside library code they don't know.
When the real problem is just that they need to update rogue to match the version of surf they are using.

We could do this individually for each Rogue python file that needs it, but that seems difficult to manage.

@ruck314 ruck314 merged commit bf9a547 into pre-release Apr 18, 2025
3 checks passed
@ruck314 ruck314 deleted the rogue-minversion branch April 18, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants