FIX: Pick up changes to UI files when the main window is reloaded #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As a result of #965 when a user chooses to reload a display, it will reset itself but changes to any underlying
.uifiles are not picked up since the compiled file from the cache is used instead. This PR adds a function for clearing that cache, and calling this new function when reloading a display. To reproduce can open up a display from a ui file, change the ui file while the display is running, and then try to reload and see the change is not reflected in the running display.Testing
Added a test that would have caught the issue, confirmed it fails prior to this code change and passes after. Manually tested changing a file and reloading the display and confirmed it works now.